Uh oh!
There was an error while loading. Please reload this page.
Be more precise when expression syntax ${{ }} can be omitted in if statement - #27497
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
cmwilson21
commented
Aug 18, 2023
@programmer04 Thanks so much for submitting a PR! I'll get this triaged for review ⚡ |
jc-clark
left a comment
There was a problem hiding this comment.
Thank you @programmer04 for finding this and helping with the fix!
While I was searching around the other articles, I found some text on if conditionals in the "Variables" article as well.
What do you think about updating this line with the same text?
Uh oh!
There was an error while loading. Please reload this page.
programmer04
commented
Aug 24, 2023
Thanks for the review and suggestion @jc-clark! For this syntax, it's even a little bit more complicated, because you can also write such expressions as
|
576aa94 to
09eb9c9Comparejc-clark
commented
Aug 25, 2023
🤔 I see what you're saying @programmer04. I think it would make sense to document the two examples you listed. I think the paragraph in the There's one problem though. We can't just add line breaks because the reusable also exists in a bulleted list on this line. Adding line breaks will break the formatting in the bulleted list. It seems to me that we can delete this bullet point in the note since the same information is at the top of the article. Then we'd be able to add some line breaks and more information to the reusable. What do you think of that? |
09eb9c9 to
3d9e294Comparecmwilson21
commented
Aug 30, 2023
👋 @programmer04 - just checking in. Is this one ready for another review? |
3d9e294 to
18bd007CompareAutomatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
programmer04
commented
Sep 1, 2023
I made suggested adjustments, it's ready for review @jc-clark and @cmwilson21. Btw. it would be easier if GH would always require |
ac68dae to
148445eCompareCo-authored-by: Joe Clark <31087804+jc-clark@users.noreply.github.com>
148445e to
ef4507fCompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Joe Clark <31087804+jc-clark@users.noreply.github.com>
jc-clark
commented
Sep 5, 2023
Looks great to me. Many thanks for helping keep this updated @programmer04. I'll get this set up to merge. |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Unfortunately, you can't always omit
${{ }}in theifstatement and it's not documented anywhere. Consider below examplesthe above works as expected, but the below that only differs by order of statements in
ifdoesn't workends with
This is due to the YAML format see
basically, it can't start with
!, because it has meaning in YAML specification.What's being changed (if available, include any code snippets, screenshots, or gifs):
The description for the
ifconditional.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.For content changes, I have completed the self-review checklist.