Uh oh!
There was an error while loading. Please reload this page.
Trim pre- and post-amble in the CC-BY license text - #291
Conversation
jeffmcaffer
commented
Oct 8, 2020
Need to validate that the new text is properly detected by licensee. Hold off merging until validated. |
zeke
left a comment
There was a problem hiding this comment.
Looks good. Thanks for working on this 👍🏼
jeffmcaffer
commented
Oct 8, 2020
Turns out that licensee does NOT detect this new text correctly. I chatted briefly with @benbalter and opened licensee/licensee#464. Two choices here:
I have no preference one way or another. |
mlinksva
commented
Oct 11, 2020
The repo UI isn't going to state a specific license regardless of what happens with this PR due to #204 ( I would not recommend merging this. Most of the text cut is recognized to be optional, but is in the canonical version provided by CC, and in general I'd discourage fiddling with license texts merely to save a few bytes. |
jeffmcaffer
commented
Oct 12, 2020
I was intending on proposing some updates to the GitHub UI that would add support for showing multiple licenses. in that case, the licensee output (having found both LICENSE and LICENSE-CODE) could be rendered usefully. The overall outcome is NOASSERTION but there is a list of high confidence licenses that could be rendered. In any event, since currently licensee does not recognize the trimmed down text, I suggest not merging this. Once licensee does, we can reconsider. |
chiedo
commented
Oct 19, 2020
Sold! |
Why:
The CC-BY license file has extra text that is not intended to be part of the license itself.
See #275
closes#275
What's being changed:
Trim the extraneous text with guidance from the legal team.