Uh oh!
There was an error while loading. Please reload this page.
Add caveat about expression syntax - #3362
Merged
Merged
Conversation
For if conditionals, expressions must be explicitly marked for evaluation if they contain any operators. Resolvesgithub#3001
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
janiceilene
commented
Feb 1, 2021
Contributor
@jidicula Thanks so much for opening a PR! I'll get this triaged for review ✨ |
janiceilene
commented
Feb 16, 2021
Contributor
It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛 |
jidicula
commented
Feb 16, 2021
ContributorAuthor
@janiceilene oh phew, thanks for reopening! 😅 |
hubwriter
approved these changes
Mar 4, 2021
hubwriter
left a comment
Contributor
There was a problem hiding this comment.
@jidicula - that's a great clarification. Many thanks for taking time to make this improvement to the docs, and for the supporting evidence that you linked to in your issue. Much appreciated - thanks again.
I'll get this merged so that it's live on the docs site very soon.
hubwriter
enabled auto-merge (squash)
March 4, 2021 14:37
jidicula
commented
Mar 4, 2021
ContributorAuthor
My pleasure @hubwriter ! |
hubwriter
disabled auto-merge
March 4, 2021 14:53
KunKax added a commit
to KunKax/docs
that referenced
this pull request
Mar 14, 2021
* Add details around security of private pages * Update content/github/setting-up-and-managing-your-github-user-account/permission-levels-for-a-user-account-repository.md Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> * Update metadata-syntax-for-github-actions.md (github#3468) * Update metadata-syntax-for-github-actions.md I tried to use another name than Dockerfile, the build fails saying: `docker: invalid reference format: repository name must be lowercase.` * Update content/actions/creating-actions/metadata-syntax-for-github-actions.md Thanks, I struggled to find the correct words and not change the text too much Co-authored-by: hubwriter <hubwriter@github.com> Co-authored-by: hubwriter <hubwriter@github.com> * Update updating-credentials-from-the-macos-keychain.md Cloning public repositories does not prompt for credentials. * redirect to Support site, not Contact form * Add caveat about expression syntax (github#3362) For if conditionals, expressions must be explicitly marked for evaluation if they contain any operators. Resolvesgithub#3001 Co-authored-by: hubwriter <hubwriter@github.com> * Remove Browser Tests until it works again (github#18088) * Remove Browser Test until it works again * Readd workflow and just disable the common triggers Co-authored-by: chiedo <chiedo@users.noreply.github.com> Co-authored-by: James M. Greene <jamesmgreene@github.com> * Remove redundant whitespace * Remove redundant releases element (enabled is default) * Use single repository element for owner * Remove optional repository name * Remove redundant releases (enabled is default) * Fixed spaces * Make 2nd example consistent * Only one repository element is required per owner * Update content/admin/enterprise-management/monitoring-using-snmp.md Co-authored-by: Meg Bird <megbird@github.com> * Consistency: Drop leading dot from OIDs * Update content/admin/enterprise-management/monitoring-using-snmp.md Co-authored-by: Meg Bird <megbird@github.com> * Bump to upload-artifact@v2 (github#3631) * Actions Docs: Using workflows from other private repositories (github#3627) Co-authored-by: Sarah Edwards <skedwards88@github.com> * Update OpenAPI Descriptions * repo sync (github#4236) * Apply suggestions from code review * add new deprecated field to release notes yaml * filter out deprecated patches in release notes middleware * Add slash command and workflow to remove issue or PR from FR board (github#18101) * change token (github#18105) * Use more permissive token (github#18106) * Slash fix (github#18107) * [MERGES AFTER GHAE CB ships] Remove "public repository" wording for GHAE (github#18008) * Empty commit * updated beta note for GHAE * more GHAE update + resolve conflict * more GHAE updates + prepare for screenshots * Apply suggestions from code review Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> * address remaining review comments * Revise "About GitHub AE" (github#17679) * add screenshots to the Configuring article * reworked to have a separate GHAE section * list numbering * more work on screenshots and conditions * add GHAE screenshots in article * review screenshots in article * added more screenshots and updated more articles * screenshot madness * fix liquid versioning * refactor the ghae script * [GHAE CB/Feb 22]: Add article about data residency for GitHub AE (github#17847) * add missing GHAE versioning to article * move screenshots to GHAE asset directory * forgot to change the path for these two images * replace CBB screenshot + add better screenshot * [GHAE CB/Feb 22]: Document upgrades for GitHub AE (github#17848) * Version article for GitHub AE * Replace unused variable * Incorporate reviewer feedback * Update intro Co-authored-by: Ethan P <56270045+ethanpalm@users.noreply.github.com> * [GHAE] Enable IP allow list (github#17691) * Notes for CC * Updat permission leves chart * Add updated article to further reading * Update gated feature callout with GitHub AE * Version "Managing allowed IP addresses for your organization" for AE * Update images * Update "Restricting network traffic to your enterprise" with new procedures * remove todo note * Update audited actions * Update info about Premium Runners * Use reusable for Premium Runners * Change "Premium Runners" to "AE hosted runners" * Incorporate reviewer feedback * Use correct reusable * Version reusable correctly * [Feb 22] GHAE: Code scanning beta (github#17830) * Add "github-ae" to all the frontmatter * GHAE-ify the reusables * Add some more changes * Re-use some content * 🔪 Semmle links * Revert change re "--external-repository-token" in the CodeQL runner * Update CodeQL runner token scopes * Update two screenshots * Remove mention of GitHub.com from AE + other fixes * Apply suggestions from code review Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> * Use `product_name` variable instead of `product_location` * Remove confusing phrase * [Feb 22] GHAE: Code scanning API and webhook docs (github#17883) * Version API and webhook docs * Actually add versioning for GHAE * Fix anchor * [TEMPORARY] Preview for API endpoints * Revert API previews * Update procedure step Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> * Update docs for AzureAD Group SCIM support in GHAE (github#17892) * Version out reference to public Pages site for GHAE * [GHAE CB] SMTP bootstrapping flow (github#17888) * draft * update with AE conntent * update with tons of versioning * remove that lie * fill out the rest of these steps * update with correct versioning * more edits * add images * reversion most of ae article * fix versioning * format correctlly * words matter * last image * update with permmissions * update versioning * add link * apply feedback ❤️ * update with differrent spacing * update with feedback * more feedback * Temporary GHAE release notes for consumables beta launch (github#17859) * Create release-notes.md * Add frontmatter * Add to index file * Update github-ae-release-notes.md * Add release notes from Google Doc * Update finalized docs links that have been reviewed * OAuth device flow link update * version for AE * few fixes * Update content/admin/overview/github-ae-release-notes.md * small edits * whoops * commit * update with different links * used wrong reusable * fix more brokenness * Update repository-references.js * Update repository-references.js Co-authored-by: Meg Bird <megbird@github.com> Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com> * [GHAE] Audit public repos (github#17917) * verifying what we mean by public * Apply suggestions from code review * Update content/developers/apps/installing-github-apps.md Co-authored-by: Laura Coursen <lecoursen@github.com> * fixing placememnt of liquid conditional Co-authored-by: Laura Coursen <lecoursen@github.com> * GHAE packages beta (github#17786) Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com> Co-authored-by: Martin Lopes <martin389@github.com> * Batch #1 of changes * Batch #2 * getting started article update * Update GraphQL article * Only public repository reference * Just update the link * Update endpoint title to use "internal" * fix build error * placeholder update for updating `public_repo` scope in UI * Remove unncessary versioning for now * fix broken links * Add REST API files * Remove versioning since the endpoint "title" didn't get updated * Version out the no scope option * Evergreen rewrite Co-Authored-By: Aaron Harpole <507570+aharpole@users.noreply.github.com> * Add back public key * Apply suggestions from code review Co-authored-by: Alex Slepak <ams11@github.com> Co-authored-by: Aaron Harpole <aharpole@github.com> * Remove versioning and add evergreen rewrite * Just the way it was before * fix confusing legacy bit * Apply suggestions from code review Co-authored-by: Alex Slepak <ams11@github.com> * Apply suggestions from code review Co-authored-by: Sarah Edwards <skedwards88@github.com> * Movin' on up * no versioning needed * internal gists exist! * Doesn't need versioning * Keep this as-is * Remove screenshots 💥 * Apply suggestions from code review Co-authored-by: Sarah Edwards <skedwards88@github.com> * Never updated REST API docs with different endpoint name * No versioning needed * Merge conflict fix: Updated this article from main branch * Apply suggestions from code review * Revert "Add REST API files" This reverts commit 1a8ad0adca47daaa1bf9d1b3642c4ec073564996. * checkout changes from main * Update OpenAPI Descriptions (github#18103) Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com> Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com> Co-authored-by: mchammer01 <42146119+mchammer01@users.noreply.github.com> Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> Co-authored-by: shati-patel <shati-patel@github.com> Co-authored-by: Sarah Schneider <sarahs@github.com> Co-authored-by: skedwards88 <skedwards88@github.com> Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com> Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> Co-authored-by: Felicity Chapman <felicitymay@github.com> Co-authored-by: Laura Coursen <lecoursen@github.com> Co-authored-by: Meg Bird <megbird@github.com> Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com> Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com> Co-authored-by: Martin Lopes <martin389@github.com> Co-authored-by: Aaron Harpole <507570+aharpole@users.noreply.github.com> Co-authored-by: Alex Slepak <ams11@github.com> Co-authored-by: Aaron Harpole <aharpole@github.com> Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com> * Mention Bounty program in security fixes * mentioned bounty program * Updating verbiage to mention bounty program for two security fixes * Issue github#4283 rewording section Issue github#4283 Line 80 has been changed from Users have specific permissions for each repository, so having the GITHUB_TOKEN for one repository grant access to another would impact the GitHub permission model if not implemented carefully. to Users have specific permissions for each repository, so allowing the GITHUB_TOKEN for one repository to grant access to another would impact the GitHub permission model if not implemented carefully. * [Ready to ship, Mar 5 2021] Secret scanning: notifications for commit authors (beta) (github#17967) * Adding footnote for "view secret scanning alerts in a repo" * update how to sign up for beta * update signup info * update contact procedure * Revert "update contact procedure" This reverts commit 007117b. * Revert "update signup info" This reverts commit 2b6e336. * Update okta-team-sync.md * avoid redirect in footer * Add docs engineering as codeowners for includes and layouts (#18134) * temporary puppeteer container changes to revert Chrome browser(github#18131) * Add pipfile to supported Python PIP formats (github#4302) See https://github.com/zendesk/pakkr/network/dependencies for an example of a pipfile in the dependency graph. * fix versioning for GHES >=3.1 * Update merged-notification.yml * Update configuring-data-encryption-for-your-enterprise.md * add clarification before ecosystem table * Create github-hubber-candidate-privacy-policy.md (github#17975) * Dotcom changes for committer-based billing M3 (github#18029) * Remove erroneous bugfix entry in 3.0.1 release notes (github#18118) * move patch version ID to outer div * Fix broken image in desktop article (github#18123) * run update branch on a cron (github#18138) * Only sync with site-policy repo from docs-internal (github#18132) * remove beta reusable file and links (github#18149) * Error middleware improvements (github#18169) * Defer logging to Failbot in error middleware until AFTER we finish responding * If headers have already been written, log to failbot and then delegate to the default error handler http://expressjs.com/en/guide/error-handling.html#the-default-error-handler * Comment tweak * [Ready to ship on March 4] Adding workflow note about dependabot token (github#17918) * adding workflows note about dependabot token * reworded a little to make active * Update data/reusables/actions/workflow-runs-dependabot-note.md Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> * Update enterprise-dates.json * Use official auto-merge for repo-sync PRs (github#17815) * Remove automerge label from repo-sync PRs to prevent automerge workflow from kicking in * Add github-script step to enable GitHub's official auto-merge on repo-sync PRs * Remove unused variable * Fix GraphQL syntax (github#18180) * Link to documentation on features mentioned in GitHub AE release notes (github#18152) * Known issue for 3.0 increased system log volume enterprise2/issues/25106 (#18130) * Clarifying Dependabot version update frequency (github#18027) * Clarifying Dependabot version update frequency * Adding a small clarification to adding a new dependency * Fixing a broken link * Clarifying manifests only start updates after failed updates * Update data/reusables/dependabot/initial-updates.md Co-authored-by: Jason Rudolph <jason@jasonrudolph.com> * Clarifying that closing PRs doesn't automatically open new PRs, only on new updates * Update content/github/administering-a-repository/configuration-options-for-dependency-updates.md Co-authored-by: hubwriter <hubwriter@github.com> * Want to give the more descriptive 'Frequency of Dependabot PRs' title, as it's the section title Co-authored-by: Jason Rudolph <jason@jasonrudolph.com> Co-authored-by: hubwriter <hubwriter@github.com> * Mention `[skip ci]` in the CI article (github#18119) * Mention the new skip instruction in commit messages * More details about the skip instruction * Update content/actions/guides/about-continuous-integration.md Co-authored-by: Martin Lopes <martin389@github.com> * Update content/actions/guides/about-continuous-integration.md Co-authored-by: Martin Lopes <martin389@github.com> * Change as per review comment. Clarify that 'on: pull_request_target' isn't affected by a skip instruction * One word addition to previous commit Co-authored-by: Martin Lopes <martin389@github.com> * Update known issues in 3.0 - deploy keys/lfs (github#18159) * Update known issues for 3.0.1 - lfs/deploy keys (github#18161) * 3.0.x Juypter Notebook rendering failure known issue (github#18164) * GHAE release notes / add PR auto-merge feature (github#18166) * GraphQL mutations require return values? (github#18186) * repo sync (github#18181) * update docs to specify Metadata access * remove outdated default metadata perms * Update content/developers/apps/setting-up-your-development-environment-to-create-a-github-app.md Co-authored-by: Georgi Knox <georgicodes@github.com> Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> Co-authored-by: James M. Greene <JamesMGreene@github.com> * Getting started category landing page (github#17841) * Start building out landing page in index file * Add articles * Add a couple more popular articles * Tweak intro to cover more audiences * Add TOC back with new organization * Update content/github/getting-started-with-github/index.md * Category as product guides section * Update breadcrumbs.js * Update server.js * Update product-landing.html * Remove TOC listing * Revert removing TOC * Update index.md * Update index.md * Update content/github/getting-started-with-github/index.md * Apply suggestions from code review Co-authored-by: Laura Coursen <lecoursen@github.com> Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com> Co-authored-by: Laura Coursen <lecoursen@github.com> * Revert repo-sync to its old auto-merge strategy (github#18189) * Add that Discussions are available in private repos & bug fixes (github#18165) Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> * Changes to devcontainer for codespaces (github#17805) * Changes to devcontainer for codespaces * Still run `npm start` Co-authored-by: James M. Greene <JamesMGreene@github.com> * Add a space (github#4390) Co-authored-by: Lee Dohm <1038121+lee-dohm@users.noreply.github.com> * Remove `npm start` from Codespaces postCreateCommand (github#18193) * Add timeout and abort middleware and processing halts (github#18177) * Add middleware to timeout requests after a period * Add halt-on-dropped-connection middleware to stop the middleware processing stack if the connection was already dropped * Add a few strategic bail-out spots for dropped connections during the render-page middleware * Handle 404s and HEAD requests earlier in the page rendering flow * Add a few more strategic bail-out spots for dropped connections during the render-page middleware * Add middleware to notice aborted requests * Add a check for aborted requests into the isConnectionDropped logic * Reformat comment for consistency * Handle aborted requests correctly in the error handler * Explicit returns for consistency * Update repo of Julia library (github#4408) The library has been moved to the `JuliaWeb` org. The previous link redirected to the new location. Co-authored-by: Lee Dohm <1038121+lee-dohm@users.noreply.github.com> * Revert "run update branch on a cron (github#18138)" (github#18203) This reverts commit e95c986. * [March 9] Update and rename Sensitive Data Removal Policy to Private Information Removal Policy (github#17029) * Update and rename github-sensitive-data-removal-policy.md to github-private-information-removal-policy.md * Update github-private-information-removal-policy.md * Update content/github/site-policy/github-private-information-removal-policy.md * Update github-private-information-removal-policy.md * Update content/github/site-policy/github-private-information-removal-policy.md Co-authored-by: Jesse Geraci <6133249+jessephus@users.noreply.github.com> * add link to Community Guidelines * add reference to ToS/AUP * Update github-private-information-removal-policy.md * replace "sensitive data" with "private information" * Update github-private-information-removal-policy.md * Update github-private-information-removal-policy.md * account for active forking and large networks * add link to AUP where we cite ToS in 1st sentence * Update content/github/site-policy/submitting-content-removal-requests.md Co-authored-by: Mike Linksvayer <mlinksva@github.com> * Update github-private-information-removal-policy.md * Fix some links * Add new article to TOC * Fix a link Co-authored-by: Jesse Geraci <6133249+jessephus@users.noreply.github.com> Co-authored-by: Mike Linksvayer <mlinksva@github.com> Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> Co-authored-by: Meg Bird <megbird@github.com> * Revise information about GitHub Actions in minimum specifications for GitHub Enterprise Server 2.22+ (github#18052) * Action ran graphql script"update-files" * Fix typo in jupyter spelling (github#18191) * Do not timeout requests during testing (github#18206) * Do not load the timeout middleware during testing * Run the link-check-server in testing mode to avoid loading the timeout middleware * Revert the change to 'package.json' * Also consider GITHUB_ACTIONS to be a testing environment to support the link checkers * Use promisified fs.readFile instead of fs.promises.readFile (github#18204) * Create a readFileAsync wrapper module * Use the readFileAsync wrapper module instead of fs.promises.readFile * Fix require path in test * Add workflow to move issues to "help wanted" column when "help wanted" or "good first issue" labels are added (github#18047) * Create production-config-change.md (github#18171) * Create production-config-change.md * Update production-config-change.md * Update production-config-change.md * rerun ci * Add dependency graph 3-0 release notes (github#18198) * Add dependency graph 3-0 release notes * Clarify combo of dg issue and logging duplication * Update data/release-notes/3-0/0.yml * Update data/release-notes/3-0/1.yml Co-authored-by: Meg Bird <megbird@github.com> Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com> * Middleware overhaul! (github#18218) * Middleware overhaul! - Remove unnecessary 'async' keywords from middleware functions - Ensure all middleware functions we create have names - Wrap the method contents of all async middleware functions in a try-catch+next(error) pattern * Use asyncMiddleware wrapper instead of try-catch+next(error) pattern * Remove unnecessary try-catch+next(error) pattern from context middleware * remove WhiteSource * Update early access docs (github#18205) * Pre-receive hooks can't create temporary files bug (github#18194) * Pre-receive hooks can't write/create temp file (github#18197) * Update event type * Align with the current instruction for password length (github#4436) * Align with the current instruction for password length * Update content/github/authenticating-to-github/creating-a-strong-password.md Change wording to make the required number of characters accurate Co-authored-by: Lee Dohm <1038121+lee-dohm@users.noreply.github.com> * Add dotenv config to server.js (github#18227) Co-authored-by: Jason Etcovitch <jasonetco@github.com> * add script to read topics spreadsheet (github#18175) * Prevent REALLY garbage request URLs (github#18216) * Block paths that do not normalize well * Add description about AE runner pools (github#18178) * Update about-ae-hosted-runners.md * Update about-ae-hosted-runners.md * Apply suggestions from code review Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> * Add the known issue about the timezone handling for the 3.0 series (github#18220) * Correcting RVA webhook payload * repo sync (github#4487) Co-authored-by: Octomerger Bot <63058869+Octomerger@users.noreply.github.com> Co-authored-by: Tommy Byrd <tcbyrd@github.com> Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com> Co-authored-by: Dominik Meyer <dmnkmyr@gmail.com> Co-authored-by: hubwriter <hubwriter@github.com> Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com> Co-authored-by: skullface <skullface@users.noreply.github.com> Co-authored-by: jidicula <johanan@forcepush.tech> Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com> Co-authored-by: chiedo <chiedo@users.noreply.github.com> Co-authored-by: James M. Greene <jamesmgreene@github.com> Co-authored-by: Janice <janiceilene@github.com> Co-authored-by: Jamie Cansdale <jcansdale@github.com> Co-authored-by: goldstar611 <goldstar611@users.noreply.github.com> Co-authored-by: Meg Bird <megbird@github.com> Co-authored-by: Mike McDonald <2575327+asciimike@users.noreply.github.com> Co-authored-by: Bradyn Poulsen <bradyn@bradynpoulsen.com> Co-authored-by: Sarah Edwards <skedwards88@github.com> Co-authored-by: github-openapi-bot <69533958+github-openapi-bot@users.noreply.github.com> Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com> Co-authored-by: Rachael Sewell <rachmari@github.com> Co-authored-by: jmarlena <6732600+jmarlena@users.noreply.github.com> Co-authored-by: Sarah Schneider <sarahs@github.com> Co-authored-by: Andrew Layman <andrewlayman@github.com> Co-authored-by: Matt Pollard <mattpollard@users.noreply.github.com> Co-authored-by: Ethan Palm <56270045+ethanpalm@users.noreply.github.com> Co-authored-by: shati-patel <shati-patel@github.com> Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com> Co-authored-by: Felicity Chapman <felicitymay@github.com> Co-authored-by: Laura Coursen <lecoursen@github.com> Co-authored-by: Kevin Heis <heiskr@users.noreply.github.com> Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com> Co-authored-by: Martin Lopes <martin389@github.com> Co-authored-by: Aaron Harpole <507570+aharpole@users.noreply.github.com> Co-authored-by: Alex Slepak <ams11@github.com> Co-authored-by: Aaron Harpole <aharpole@github.com> Co-authored-by: John Poulin <forced-request@github.com> Co-authored-by: Rami Zackary Shamir <ramizackshamir@icloud.com> Co-authored-by: Prashanth Kannan <prashkan@github.com> Co-authored-by: Jarryd McCree <jamccree@users.noreply.github.com> Co-authored-by: jamccree <jamccree@github.com> Co-authored-by: Justin Holguin <juxtin@github.com> Co-authored-by: Maya Ross <maya-ross@github.com> Co-authored-by: Tamaria Sanderson <52512629+TamariaS@users.noreply.github.com> Co-authored-by: Steffen Bjerkenås <53113003+stebje@users.noreply.github.com> Co-authored-by: Brett Westover <bwestover@github.com> Co-authored-by: djdefi <djdefi@github.com> Co-authored-by: Jason Rudolph <jason@jasonrudolph.com> Co-authored-by: chiph <chiph@github.com> Co-authored-by: Will Smythe <willsmythe@github.com> Co-authored-by: Georgi Knox <georgicodes@github.com> Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com> Co-authored-by: Matthew Isabel <matthewisabel@github.com> Co-authored-by: Jess Frazelle <jessfraz@users.noreply.github.com> Co-authored-by: Lee Dohm <1038121+lee-dohm@users.noreply.github.com> Co-authored-by: Sascha Mann <git@mail.saschamann.eu> Co-authored-by: Abby Vollmer <vollmera@users.noreply.github.com> Co-authored-by: Jesse Geraci <6133249+jessephus@users.noreply.github.com> Co-authored-by: Mike Linksvayer <mlinksva@github.com> Co-authored-by: rachmari <rachmari@users.noreply.github.com> Co-authored-by: Reid Draper <reiddraper@github.com> Co-authored-by: Olliec Funderburg <31467661+captain-wolf@users.noreply.github.com> Co-authored-by: Hammam <h.samara.74@gmail.com> Co-authored-by: Jason Etcovitch <jasonetco@github.com> Co-authored-by: Lucas Costi <lucascosti@users.noreply.github.com> Co-authored-by: Ryosuke Nakayama <catto@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
For if conditionals, expressions must be explicitly marked for evaluation if they contain any operators.
See #3001 for context.
What's being changed:
An inaccuracy in documentation about if conditionals implicitly evaluating expressions without needing to enclose with
${{ }}.Check off the following: