Skip to content

Fix broken link to "Grammar and usage" brand guide page - #345

Merged
janiceilene merged 2 commits into
github:mainfrom
Hans5958:patch-1
Oct 9, 2020
Merged

Fix broken link to "Grammar and usage" brand guide page#345
janiceilene merged 2 commits into
github:mainfrom
Hans5958:patch-1

Conversation

@Hans5958

@Hans5958Hans5958 commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

Why:

There is a broken link that I found when reading the content style guide. Turns out that some time ago the page name is changed and thus broke the link. I found the correct address of the page nonetheless, and I wanted to fix it.
(Also, I'm not sure which template should I choose, because this is about the repository's documentation, not https://docs.github.com. The change is quite minor so I hope this single PR is okay.)

What's being changed:

I have changed links that points to https://brand.github.com/content/grammar-usage/ so it points to https://brand.github.com/content/grammar.

Check off the following:

@welcome

welcomeBot commented Oct 9, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilenejaniceilene left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing this @Hans5958! I'll update the branch and get this merged as soon as tests are passing 🌟

@janiceilene
janiceilene merged commit 49327c6 into github:mainOct 9, 2020
@janiceilene

Copy link
Copy Markdown
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@Hans5958
Hans5958 deleted the patch-1 branch October 10, 2020 10:18
@Hans5958

Hans5958 commented Oct 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Hey, thanks for the merge. Glad to help you guys.

@allcontributors add @Hans5958 for bug

EDIT: well...

@allcontributors

Copy link
Copy Markdown
Contributor

@Hans5958

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 8560

docs-bot added a commit that referenced this pull request Aug 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Hans5958@janiceilene