Skip to content

GitHub Actions: Be precise about the format - #400

Merged
lucascosti merged 3 commits into
github:mainfrom
tillepille:patch-1
Oct 20, 2020
Merged

GitHub Actions: Be precise about the format#400
lucascosti merged 3 commits into
github:mainfrom
tillepille:patch-1

Conversation

@tillepille

@tillepilletillepille commented Oct 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

I stumbled across this to add the plain branch name to the Docker push action as a tag, which does not work with

with:
tags: tillepille/my-image: ${{ github.ref }}

Why:

I tried to get the plain branch name as a variable in my Action. The documentation suggested to me that this is the plain branch name e.g. master but it is in the format of refs/heads/master which isn't applicable as e.g a docker tag.

What's being changed:

Be more precise about the format of the variable.
I added in the form of refs/heads/<BRANCH_NAME> to the explanation.

Check off the following:

closes#476

@tillepille
Be precise about the format of the output
905352f
I stumbled across this to add the plain branch name to the [Docker push action](https://github.com/docker/build-push-action) as a tag, which does not work with ```yaml
with:
tags: tillepille/my-image: ${{ github.ref }}
```
@welcome

welcomeBot commented Oct 10, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

janiceilene commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@tillepille

tillepille commented Oct 13, 2020

Copy link
Copy Markdown
ContributorAuthor

@janiceilene Sorry, I missed it when opening the mr via whole UI workflow. Filled out, Issue also created

@tillepilletillepille mentioned this pull request Oct 13, 2020
Closed
@janiceilene

janiceilene commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

Thanks so much for filling out the template and opening an issue @tillepille 💛 I'll get this triaged for review!

@janiceilenejaniceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 13, 2020
@lucascostilucascosti self-assigned this Oct 20, 2020
lucascosti
lucascosti reviewed Oct 20, 2020
View reviewed changes
Comment threadcontent/actions/reference/context-and-expression-syntax-for-github-actions.md Outdated
lucascosti
lucascosti approved these changes Oct 20, 2020
View reviewed changes

@lucascostilucascosti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@lucascosti
lucascosti merged commit 7c159dd into github:mainOct 20, 2020
@github-actions

github-actionsBot commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lucascostilucascostilucascosti approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lucascostilucascosti

Labels

actionsThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Github Actions context variables data format not precise

3 participants

@tillepille@janiceilene@lucascosti