Actions: How to run jobs on issue_comment only if PR by Simran-B · Pull Request #438 · github/docs

Simran-B · 2020-10-12T12:34:20Z

Why:

The issue_comment event occurs for both, regular issues and pull requests. This should be pointed out.

What's being changed:

Add remark and also provide an example how to tell issues and PRs apart by testing for the presence of github.event.issue.pull_request.

Check off the following:

~~All of the tests are passing.~~
~~I have reviewed my changes in staging.~~
For content changes, I have reviewed the localization checklist
For content changes, I have reviewed the Content style guide for GitHub Docs.

janiceilene · 2020-10-12T23:49:17Z

Thanks for opening a PR @Simran-B! I'll get this triaged for review ⚡

github-actions · 2020-10-20T22:07:08Z

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

janiceilene · 2020-10-21T23:59:12Z

This is not stale! We're working our way through reviews 💛

rachmari

@Simran-B this is an excellent idea to add to the docs. Great suggestion and contribution. 👏

I had a few suggestions to add on to your example. If everything looks good with those suggestions, I can get this shipped for you!

Simran-B · 2020-11-04T17:27:25Z

Alright, please take another look if this is good to go now.

rachmari

@Simran-B that was the last thing I needed! I'll get this merged right away. Thanks again for all of your wonderful contributions! 🙏 💚

nschonni · 2020-11-04T22:56:08Z

@rachmari not really related to the change, but would using the automerge and autoupdate labels on these PRs help so you don't have to chase the up-to-date branch check?

rachmari · 2020-11-04T23:17:06Z

@nschonni

@rachmari not really related to the change, but would using the automerge and autoupdate labels on these PRs help so you don't have to chase the up-to-date branch check?

We don't have that capability yet, but we're working on it!

nschonni · 2020-11-04T23:18:28Z

Fair enough, I thought they were working already because they're used for the repo-sync job

rachmari · 2020-11-04T23:19:34Z

@nschonni soon hopefully🤞! Chasing down CI builds is definitely something for a 🤖 to do. 😂

github-actions · 2020-11-04T23:20:06Z

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

* Add link to developer docs on GH * Add link to developer docs on install page

* initial setup * remove update search index for now * major overhaul - links to console and new portal not changed * index page for mst * mst-multi-node * finish mst section content * convert forge links * General edits for wording, etc. (github#381) * update (github#386) * Add command to install timescaledb-tools (github#364) * Fix missing semi-colon (github#363) Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Remove 'repeatable' isolation level from multinode docs (github#361) Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Fix bad path (github#360) * add leading slash * Add version * typo Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Update install instructions (github#359) * Update install instructions * Change postgres to timescaledb repo * Add sudo * Remove extra whitespace * Update to correct key * Edits per feedback * Add step to install postgres repo * Apply suggestions from code review Co-authored-by: Cam Hutchison <35285934+camscale@users.noreply.github.com> Co-authored-by: Cam Hutchison <35285934+camscale@users.noreply.github.com> Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Fix/link checker error (github#370) * add absolute path to links * add slash * Fix incorrect sql query (github#362) Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Add the toolkit as a pre-req to the tutorial. (github#306) * Add the toolkit as a pre-req to the tutorial. * Fix link in admon * Point to correct URL * fix link Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Fix/link checker error (github#374) * add absolute path to links * add slash * add base url * add new to ignore * Fix/link checker error (github#376) * add absolute path to links * add slash * add base url * add new to ignore * add scheme * Document the differences between time_bucket() and time_bucket_ng() (github#354) Document the differences between time_bucket() and time_bucket_ng() Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update install instructions (github#379) * Update install instructions * Update timescaledb/how-to-guides/install-timescaledb/installation-apt-debian.md Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Add metadata for tutorials (github#380) * Add metadata for tutorials * Update page-index.js typo correction Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * Update page-index.js Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Cam Hutchison <35285934+camscale@users.noreply.github.com> Co-authored-by: Aleksander Alekseev <mail@eax.me> * change to cloud * cloud * Update time_bucket_ng.md (github#417) * Update cloud/cloud-multi-node.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update cloud/create-a-service.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/create-a-service.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update timescaledb/tutorials/setting-up-mst-for-prometheus.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update timescaledb/tutorials/setting-up-mst-for-prometheus.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update timescaledb/tutorials/setting-up-mst-for-prometheus.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update timescaledb/tutorials/setting-up-mst-for-prometheus.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update timescaledb/tutorials/setting-up-mst-for-prometheus.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update cloud/create-a-service.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update time_bucket_ng.md * Update cloud/create-a-service.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * update portal managed * Feature/timescale license comparison (github#453) * added timescale license comparison * edit title * update * Make sure window functions are listed as unsupported (github#393) Co-authored-by: Jacob Prall <prall.jacob@gmail.com> * update link (github#420) * update (github#422) * Fix/update link checker (github#424) * update * don't check if starts with / * add excludes (github#426) * Fix/linkchecker (github#428) * add excludes * update * Fix/linkchecker (github#430) * add excludes * update * update * Fix/linkchecker (github#432) * add excludes * update * update * comment out link checker * Fix/link checker again (github#433) * try to include link checker * reinstate index rebuild on merge * tweak yaml * remove link detector * tweak curl * remove link checker * remove search index from deploy * tweak update search * update search index * change name of action * stop search index for now * ignore search update * remove update search index * Add .NET C# quick start tutorial (github#412) * Add C# dotnet quickstart * Update dotnet.md Fixing steps to have numbers, a few heading formatting issues, and changing the "step" text above each method. * Apply suggestions from code review Applying most changes. I want to verify that auto numbering will work across code sections before accepting those. Co-authored-by: Lana Brindley <github@lanabrindley.com> * Apply suggestions from code review Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update dotnet.md Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> * update copy * update copy * add edition * Fix typo in JSON docs (github#441) Co-authored-by: Tadas Malinauskas <tadas.malinauskas@oxylabs.io> * Clarify behavior when deleting a data node (github#406) * Clarify behavior when deleting a data node When deleting a data node, the database (including its data) on the data node is left intact. This sometimes confuses users and this change clarifies this behavior and adds explanations for why this behavior exists. * Update api/delete_data_node.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update api/delete_data_node.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Apply suggestions from code review minor copy edits Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Jacob Prall <prall.jacob@gmail.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update README.md add newLabel to page-index read me * Add link to developer docs on GH (github#438) * Add link to developer docs on GH * Add link to developer docs on install page * remove new item Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Jônatas Davi Paganini <jonatasdp@gmail.com> Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Tadas Malinauskas <Taadas@users.noreply.github.com> Co-authored-by: Tadas Malinauskas <tadas.malinauskas@oxylabs.io> Co-authored-by: Erik Nordström <819732+erimatnor@users.noreply.github.com> * Update timescaledb-license-comparison.md * update timescale table * add terms of service links * update * add terms of service links * Update timescaledb-license-comparison.md * Update timescaledb-license-comparison.md Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Cam Hutchison <35285934+camscale@users.noreply.github.com> Co-authored-by: Aleksander Alekseev <mail@eax.me> Co-authored-by: Jônatas Davi Paganini <jonatasdp@gmail.com> Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Tadas Malinauskas <Taadas@users.noreply.github.com> Co-authored-by: Tadas Malinauskas <tadas.malinauskas@oxylabs.io> Co-authored-by: Erik Nordström <819732+erimatnor@users.noreply.github.com>

Simran-B added 2 commits October 12, 2020 14:22

Actions: How to run jobs on issue_comment only if PR
c8a9894

Make sentence a bit clearer
0a9a86c

janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 12, 2020

github-actionsBot added the stale There is no recent activity on this issue or pull request label Oct 20, 2020

janiceilene added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! and removed stale There is no recent activity on this issue or pull request labels Oct 21, 2020

rachmari reviewed Nov 3, 2020
View reviewed changes

Comment threadcontent/actions/reference/events-that-trigger-workflows.md Outdated
Comment threadcontent/actions/reference/events-that-trigger-workflows.md
Comment threadcontent/actions/reference/events-that-trigger-workflows.md

rachmari self-assigned this Nov 3, 2020

This comment has been minimized.
Sign in to view

Simran-Band others added 3 commits November 4, 2020 18:01

Update content/actions/reference/events-that-trigger-workflows.md
4885d33

Apply modified review suggestions
e7128b5

Improve example
cb31da6

rachmari reviewed Nov 4, 2020
View reviewed changes

Comment threadcontent/actions/reference/events-that-trigger-workflows.md Outdated

Update content/actions/reference/events-that-trigger-workflows.md
a795b0f

rachmari approved these changes Nov 4, 2020
View reviewed changes

Fix whitespace
cffd752

Merge branch 'main' into patch-1
68f1923

rachmari merged commit e89eef3 into github:mainNov 4, 2020

Simran-B deleted the patch-1 branch November 4, 2020 23:37

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Add link to developer docs on GH (github#438)
cbd3f3e
* Add link to developer docs on GH * Add link to developer docs on install page

Uh oh!

Conversation

Simran-B commented Oct 12, 2020

Why:

What's being changed:

Check off the following:

Uh oh!

janiceilene commented Oct 12, 2020

Uh oh!

github-actionsBot commented Oct 20, 2020

Uh oh!

janiceilene commented Oct 21, 2020

Uh oh!

rachmari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

Simran-B commented Nov 4, 2020

Uh oh!

Uh oh!

rachmari left a comment

Choose a reason for hiding this comment

Uh oh!

nschonni commented Nov 4, 2020

Uh oh!

rachmari commented Nov 4, 2020

Uh oh!

nschonni commented Nov 4, 2020

Uh oh!

rachmari commented Nov 4, 2020

Uh oh!

github-actionsBot commented Nov 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants