Skip to content

Clearer instructions - #4419

Merged
saritai merged 3 commits into
github:mainfrom
kwinkunks:patch-1
Apr 1, 2021
Merged

Clearer instructions#4419
saritai merged 3 commits into
github:mainfrom
kwinkunks:patch-1

Conversation

@kwinkunks

@kwinkunkskwinkunks commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

Why: I was unclear on how to upload a file and found the instructions oddly worded (the section on creating gists started with 'You can also...', but I wasn't clear on the main idea yet).

I also fixed a missing word in 3rd 'About gists' bullet point.

Closes [issue link]

What's being changed: Added a word, added an intro sentence, and moved a sentence.

Check off the following:

@kwinkunks
Clearer instructions
ea5f298
I was unclear on how to upload a file and found the instructions oddly worded. Also fixed a missing word in 3rd 'About gists' bullet point.
@welcome

welcomeBot commented Mar 9, 2021

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

janiceilene commented Mar 16, 2021

Copy link
Copy Markdown
Contributor

@kwinkunks Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilenejaniceilene added waiting for review Issue/PR is waiting for a writer's review writing on github labels Mar 16, 2021
saritai
saritai reviewed Mar 24, 2021
View reviewed changes
Comment threadcontent/github/writing-on-github/creating-gists.md Outdated
![Gist name description](/assets/images/help/gist/gist_name_description.png)

4. Type the text of your gist into the gist text box.
4. Type the text of your gist into the gist text box. Alternatively, you can drag and drop a text file from your desktop directly into the editor.

@saritaisaritaiMar 24, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the sentence about drag and drop to the note above that contains the CLI information. Let us know when you make the change and we will review again!

@saritaisaritaiApr 1, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and made this change! The rest looks good so we will merge!

@saritaisaritai removed the waiting for review Issue/PR is waiting for a writer's review label Mar 24, 2021
@saritai
saritai dismissed stale reviews from ghost via f098026April 1, 2021 14:59
@saritai
saritai merged commit 075facb into github:mainApr 1, 2021
@github-actions

github-actionsBot commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@Sarrac3873Sarrac3873 mentioned this pull request May 13, 2024
Open
@alisccoaliscco mentioned this pull request May 17, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saritaisaritaisaritai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kwinkunks@janiceilene@saritai