Uh oh!
There was an error while loading. Please reload this page.
Fix use of "structured" vs "unstructured" - #496
Conversation
The guidance and description are inconsistent. This change corrects that inconsistency.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
janiceilene
commented
Oct 14, 2020
Thanks for opening a PR @jimrazmus! Changing the first word from "structured" to "unstructured" changes the meaning of this section of the article, so I'm going to close this PR. |
janiceilene
commented
Oct 14, 2020
If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
jimrazmus
commented
Nov 5, 2020
The title of the section reads "Never use structured data as a secret" but then goes on to talk about unstructured data leading to redaction failures. So what I take away is to never use structured or unstructured data in secrets. It that the intent of the section? The examples call out JSON, XML, and YAML. Are those examples meant to speak to the title of the section in regards to structured data or the preceding sentence regarding unstructured data? |
janiceilene
commented
Nov 6, 2020
You were totally right about this change @jimrazmus and closing this PR was my mistake. I'm sorry about that! It ended up being fixed in another PR with some additional context in this comment #1036 (comment). Thank you for following up with a helpful and kind explanation of why your suggestion was important! |
jimrazmus
commented
Feb 9, 2021
@all-contributors please add @jimrazmus for documentation |
Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
The guidance and description are inconsistent. This change corrects that inconsistency.
Why:
The inconsistency between the guidance and its description is confusing.
What's being changed:
The inconsistency between the guidance and its description.
Check off the following: