Skip to content

Fix link and remove /articles - #5100

Merged
shati-patel merged 4 commits into
github:mainfrom
GrahamSH-LLK:patch-1
Apr 9, 2021
Merged

Fix link and remove /articles#5100
shati-patel merged 4 commits into
github:mainfrom
GrahamSH-LLK:patch-1

Conversation

@GrahamSH-LLK

@GrahamSH-LLKGrahamSH-LLK commented Apr 6, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Why:

Closes#5033

What's being changed:

Fixes links and markdown syntax

Check off the following:

@welcome

welcomeBot commented Apr 6, 2021

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actionsgithub-actionsBot added the triage Do not begin working on this issue until triaged by the team label Apr 6, 2021
@janiceilene

janiceilene commented Apr 8, 2021

Copy link
Copy Markdown
Contributor

@GrahamSH-LLK Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilenejaniceilene added core waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 8, 2021
@shati-patelshati-patel self-assigned this Apr 9, 2021
@shati-patel
shati-patel dismissed a stale review via d9bdebfApril 9, 2021 08:27
shati-patel
shati-patel reviewed Apr 9, 2021
View reviewed changes
Comment threadcontent/github/authenticating-to-github/creating-a-personal-access-token.md

{% endwarning %}
{% if currentVersion == "free-pro-team@latest" %}9. To use your token to authenticate to an organization that uses SAML SSO, [authorize the token for use with a SAML single-sign-on organization](/articles/authorizing-a-personal-access-token-for-use-with-saml-single-sign-on).{% endif %}
{% if currentVersion == "free-pro-team@latest" %}9. To use your token to authenticate to an organization that uses SAML SSO, [authorize the token for use with a SAML single-sign-on organization](/github/authenticating-to-github/authorizing-a-personal-access-token-for-use-with-saml-single-sign-on).{% endif %}

@shati-patelshati-patelApr 9, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, this link still wasn't rendering:

image

Your syntax is correct, so it looks like a bug with the rendering! Slightly adjusting whitespace should help—I've pushed a fix (see d9bdebf)!

shati-patel
shati-patel approved these changes Apr 9, 2021
View reviewed changes

@shati-patelshati-patel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @GrahamSH-LLK! The link now works ✨

I'll get this merged shortly!

@shati-patelshati-patel added the ready to merge This pull request is ready to merge label Apr 9, 2021
@github-actionsgithub-actionsBot removed the waiting for review Issue/PR is waiting for a writer's review label Apr 9, 2021
@shati-patel
shati-patel merged commit 849c34b into github:mainApr 9, 2021
@github-actions

github-actionsBot commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@shati-patelshati-patelshati-patel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@shati-patelshati-patel

Labels

ready to mergeThis pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Creating a personal access token" has a malformed link

4 participants

@GrahamSH-LLK@janiceilene@shati-patel@docubot