Skip to content

Elaborate on how to escape multiple labels in issue templates - #519

Merged
felicitymay merged 4 commits into
github:mainfrom
MortenBoysen:patch-1
Oct 21, 2020
Merged

Elaborate on how to escape multiple labels in issue templates#519
felicitymay merged 4 commits into
github:mainfrom
MortenBoysen:patch-1

Conversation

@MortenBoysen

@MortenBoysenMortenBoysen commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

Why:

Escaping them individually led to bugs in our templates that I had to spend time on tracking down.

What's being changed:

The description on how to change labels in issue templates

Check off the following:

@MortenBoysen
Elaborate on how to escape multiple labels in issue templates
1bbee21
Escaping them individually led to bugs in our templates that I had to spend time on tracking down.
@welcome

welcomeBot commented Oct 14, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

janiceilene commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR @MortenBoysen! I'll get this triaged for review ⚡

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 15, 2020
felicitymay
felicitymay reviewed Oct 17, 2020
View reviewed changes

@felicitymayfelicitymay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to hear that this cost you time debugging your template but many thanks for submitting a fix to stop it affecting others 💖

Comment thread...building-a-strong-community/manually-creating-a-single-issue-template-for-your-repository.md Outdated
@felicitymay

felicitymay commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

👋🏻 Hi @MortenBoysen - before I merge this PR, I'd really like to know your thoughts on my suggested change to introductory text. Would that have been any clearer?

@MortenBoysen@felicitymay
Update content/github/building-a-strong-community/manually-creating-a…
a683168
…-single-issue-template-for-your-repository.md
Co-authored-by: Felicity Chapman <felicitymay@github.com>
felicitymay
felicitymay approved these changes Oct 21, 2020
View reviewed changes

@felicitymayfelicitymay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@felicitymay
felicitymay merged commit 2a80dd1 into github:mainOct 21, 2020
@github-actions

github-actionsBot commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@felicitymayfelicitymay added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 6, 2020
This was referenced May 28, 2021
Merged
Open
@venkatarao-palaparthivenkatarao-palaparthi mentioned this pull request Aug 13, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Sep 10, 2022
Open
@snyk-botsnyk-bot mentioned this pull request Oct 19, 2022
Open
@Anmar1988260Anmar1988260 mentioned this pull request Nov 30, 2023
Open
@montana910318montana910318 mentioned this pull request Nov 30, 2023
Open
@qmutzqmutz mentioned this pull request Nov 30, 2023
Open
@oudomsknoudomskn mentioned this pull request Nov 30, 2023
Open
@Visva92Visva92 mentioned this pull request Nov 30, 2023
Open
@ryan-allyryan-ally mentioned this pull request Nov 30, 2023
Open
@mongoloidkhulmikuki366385mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
@alisccoaliscco mentioned this pull request Dec 1, 2023
Open
@mongoloidkhulmikuki366385mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@felicitymayfelicitymayfelicitymay approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contentThis issue or pull request belongs to the Docs Content teamhacktoberfest-acceptedWe might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MortenBoysen@janiceilene@felicitymay