Skip to content

example to echo out put from previous step fails - #528

Merged
lucascosti merged 4 commits into
github:mainfrom
bcbrian:patch-1
Oct 16, 2020
Merged

example to echo out put from previous step fails#528
lucascosti merged 4 commits into
github:mainfrom
bcbrian:patch-1

Conversation

@bcbrian

@bcbrianbcbrian commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

Why:

I copied and pasted this piece out of the docs and it did not work.
The error is a bash error: bad substitution.

Link to the change

What's being changed:

change - run: echo 'The selected color is' ${steps.random-color-generator.outputs.SELECTED_COLOR}
to - run: echo "The selected color is ${{ steps.random-color-generator.outputs.SELECTED_COLOR }}"

Other parts of the docs have it formatted this way.

Check off the following:

change - run: echo 'The selected color is' ${steps.random-color-generator.outputs.SELECTED_COLOR}
to - run: echo "The selected color is ${{ steps.random-color-generator.outputs.SELECTED_COLOR }}"
Other parts of the docs have it formatted this way. The error is a bash error: bad substitution.
@welcome

welcomeBot commented Oct 14, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR @bcbrian! I'll get this triaged and up for review ⚡

@janiceilenejaniceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 15, 2020
@lucascostilucascosti self-assigned this Oct 16, 2020

@lucascostilucascosti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @bcbrian! 🚀

Thanks for fixing this, I'll get it merged when the tests from the rebase pass 👍

@lucascosti
lucascosti merged commit 70d6d85 into github:mainOct 16, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actionsThis issue or pull request should be reviewed by the docs actions teamcontentThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bcbrian@janiceilene@lucascosti