Uh oh!
There was an error while loading. Please reload this page.
add slack to github integrations list - #542
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
janiceilene
commented
Oct 15, 2020
Thanks so much for opening a PR @ParkourKarthik! I'll get this triaged for review 🎉 |
felicitymay
left a comment
There was a problem hiding this comment.
Hi. Thanks for picking this issue up. It'll be really helpful for users to have a fuller list of integrations created by GitHub. ✨
I've made a couple of suggestions of small changes to improve clarity.
It's not suggested in the issue but, if you have time, it would be great to add links from the Jira and Slack sections to the marketplace docs - using the same format as for the Editor tools. The information there is quite detailed:
- Jira information: https://github.com/marketplace/jira-software-github
- Slack information: https://github.com/marketplace/slack-github
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Felicity Chapman <felicitymay@github.com>
felicitymay
left a comment
There was a problem hiding this comment.
Thanks for the changes. Can you let me know if you plan to add the links I suggested too? I don't want to merge the PR if you're planning further work.
ParkourKarthik
commented
Oct 19, 2020
@felicitymay Sure, will work on updating the links as preferred. |
felicitymay
commented
Oct 19, 2020
Thanks, that sounds good. 🙇🏻♀️ |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
felicitymay
commented
Oct 19, 2020
🎉 🚢 I think that you might need to close the issue that you've fixed manually, since this PR wasn't mentioned as a fix for #432. I should have noticed that before and then I could have added a comment to link the PR to the issue before I merged 🤦🏻 (For reference: https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue.) |
ParkourKarthik
commented
Oct 19, 2020
Sorry that I missed. I can't close the issue as I don't have the option ( probably rights). Tried updating the description here but didn't work 🤷 |
felicitymay
commented
Oct 19, 2020
Ah. No problem - I didn't realize. I'll update the issue shortly (in a meeting right now). |
Why:
closes#432
What's being changed:
Included slack to github integration list
Check off the following: