Skip to content

Fix default GPG key type - #567

Merged
felicitymay merged 4 commits into
github:mainfrom
sturman:patch-1
Oct 21, 2020
Merged

Fix default GPG key type#567
felicitymay merged 4 commits into
github:mainfrom
sturman:patch-1

Conversation

@sturman

@sturmansturman commented Oct 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

2020-10-15_23-25

Why:

What's being changed:

step

  • At the prompt, specify the kind of key you want, or press Enter to accept the default RSA and DSA.

replaced with

  • At the prompt, specify the kind of key you want, or press Enter to accept the default RSA and RSA.

Check off the following:

@welcome

welcomeBot commented Oct 15, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

janiceilene commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

Thanks for opening a PR @sturman! I'll get this triaged for review ⚡

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 15, 2020
felicitymay
felicitymay approved these changes Oct 21, 2020
View reviewed changes

@felicitymayfelicitymay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 @sturman

Thanks for reporting this discrepancy and fixing it ✨
It was particularly helpful that you included a screenshot to show the expected prompt.

@felicitymay
felicitymay merged commit bb8e5e4 into github:mainOct 21, 2020
@github-actions

github-actionsBot commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@felicitymayfelicitymay added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 6, 2020
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity@jacobprall@emizero
Add note about VPC details (github#567)
d405282
* Add note about VPC details
* Apply suggestions from code review
Co-authored-by: emizero <83252792+emizero@users.noreply.github.com>
Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
* Apply suggestions from code review
* Update mst/vpc-peering.md
Co-authored-by: emizero <83252792+emizero@users.noreply.github.com>
Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
Co-authored-by: emizero <83252792+emizero@users.noreply.github.com>
@ariafildaariafilda mentioned this pull request Jun 23, 2023
Open
@khmoozkhmooz mentioned this pull request Jun 23, 2023
Open
@BESTczmBESTczm mentioned this pull request Jun 23, 2023
Open
@dotam99dotam99 mentioned this pull request Jun 23, 2023
Open
@irinazheltishevairinazheltisheva mentioned this pull request Jun 23, 2023
Open
@arroselliarroselli mentioned this pull request Jun 23, 2023
Open
@abood640abood640 mentioned this pull request Jun 23, 2023
Open
@kabat87kabat87 mentioned this pull request Jun 23, 2023
Open
@qmutzqmutz mentioned this pull request Jun 23, 2023
Open
@kevinjm39kevinjm39 mentioned this pull request Jun 23, 2023
Open
@tronghamtrongham mentioned this pull request Jun 23, 2023
Open
@BESTczmBESTczm mentioned this pull request Jun 23, 2023
Open
@B020239B020239 mentioned this pull request Jun 23, 2023
Open
@Janzawada57Janzawada57 mentioned this pull request Jun 23, 2023
Open
@ZRDKZRDK mentioned this pull request Jun 23, 2023
Open
@monzerfodamonzerfoda mentioned this pull request Jun 23, 2023
Open
@Verdinjoshua26Verdinjoshua26 mentioned this pull request Jun 23, 2023
Open
@francissimofrancissimo mentioned this pull request Jun 24, 2023
Open
@kabat87kabat87 mentioned this pull request Jun 25, 2023
Open
@B020239B020239 mentioned this pull request Jun 30, 2023
Open
@tglt-9794tglt-9794 mentioned this pull request Nov 30, 2023
Open
@treeationstreeations mentioned this pull request Nov 30, 2023
Open
@RanaAhmed2020RanaAhmed2020 mentioned this pull request Nov 30, 2023
Open
@vutting4221vutting4221 mentioned this pull request Nov 30, 2023
Open
@chrisjcox79chrisjcox79 mentioned this pull request Nov 30, 2023
Open
@BESTczmBESTczm mentioned this pull request Nov 30, 2023
Open
@zipzip225zipzip225 mentioned this pull request Nov 30, 2023
Open
@amymariaparker2401amymariaparker2401 mentioned this pull request Nov 30, 2023
Open
@rhsayem075rhsayem075 mentioned this pull request Nov 30, 2023
Open
@machatmanmachatman mentioned this pull request Nov 30, 2023
Open
@Anmar1988260Anmar1988260 mentioned this pull request Nov 30, 2023
Open
@montana910318montana910318 mentioned this pull request Nov 30, 2023
Open
@bitokenja3bitokenja3 mentioned this pull request Nov 30, 2023
Open
@kaocher82kaocher82 mentioned this pull request Nov 30, 2023
Open
@Verdinjoshua26Verdinjoshua26 mentioned this pull request Nov 30, 2023
Open
@qmutzqmutz mentioned this pull request Nov 30, 2023
Open
@oudomsknoudomskn mentioned this pull request Nov 30, 2023
Open
@Visva92Visva92 mentioned this pull request Nov 30, 2023
Open
@Oleksandr1201vspOleksandr1201vsp mentioned this pull request Nov 30, 2023
Open
@Verdinjoshua26Verdinjoshua26 mentioned this pull request Dec 1, 2023
Open
@monzerfodamonzerfoda mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
@codywalker77codywalker77 mentioned this pull request Dec 19, 2023
Open
@Anmar1988260Anmar1988260 mentioned this pull request Dec 19, 2023
Open
@dotam99dotam99 mentioned this pull request Dec 19, 2023
Open
@w124578w124578 mentioned this pull request Dec 20, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@felicitymayfelicitymayfelicitymay approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contentThis issue or pull request belongs to the Docs Content teamhacktoberfest-acceptedWe might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sturman@janiceilene@felicitymay