Skip to content

workspaceFolder is not supported yet - #578

Merged
lecoursen merged 5 commits into
github:mainfrom
mtsmfm:patch-1
Nov 5, 2020
Merged

workspaceFolder is not supported yet#578
lecoursen merged 5 commits into
github:mainfrom
mtsmfm:patch-1

Conversation

@mtsmfm

@mtsmfmmtsmfm commented Oct 16, 2020

Copy link
Copy Markdown
Contributor

@welcome

welcomeBot commented Oct 16, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 16, 2020
@janiceilene

Copy link
Copy Markdown
Contributor

@mtsmfm Thank you so much for opening a PR! I'll get this triaged for review ⚡

@jkeech

Copy link
Copy Markdown
Contributor

@matthewisabel, there are several properties in this list that are not supported in Codespaces:

Not yet supported

  • workspaceMount
  • workspaceFolder

Not applicable for Codespaces (no plan to support)

  • devPort
  • updateRemoteUserUID
  • shutdownAction

VS Code's devcontainer documentation is closer to being correct -- there are some comments about which properties are not supported in Codespaces or if they behave slightly differently in Codespaces: https://code.visualstudio.com/docs/remote/devcontainerjson-reference

cc @Chuxel

@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actionsgithub-actionsBot added the stale There is no recent activity on this issue or pull request label Oct 24, 2020
@mtsmfm

Copy link
Copy Markdown
ContributorAuthor

@janiceilene@jkeech I've updated the doc to follow the comment

#578 (comment)

@github-actionsgithub-actionsBot removed the stale There is no recent activity on this issue or pull request label Oct 25, 2020
@janiceilenejaniceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020

@lecoursenlecoursen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for letting us know about these unsupported keys! I added a few suggested changes for the best way to convey that information. After you commit those suggestions, I can approve and merge! 😎 🎉

mtsmfmand others added 2 commits November 5, 2020 06:42
…odespaces-for-your-project.md
Co-authored-by: Laura Coursen <lecoursen@github.com>
…odespaces-for-your-project.md
Co-authored-by: Laura Coursen <lecoursen@github.com>
@mtsmfm

Copy link
Copy Markdown
ContributorAuthor

@lecoursen Applied your suggestions

@lecoursen
lecoursen merged commit b1dc16d into github:mainNov 5, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contentThis issue or pull request belongs to the Docs Content teamhacktoberfest-acceptedWe might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mtsmfm@janiceilene@jkeech@matthewisabel@lecoursen