Skip to content

Registry URLs must include https:// - #584

Merged
rachmari merged 3 commits into
mainfrom
registry-https
Nov 4, 2020
Merged

Registry URLs must include https://#584
rachmari merged 3 commits into
mainfrom
registry-https

Conversation

@jcansdale

Copy link
Copy Markdown
Contributor

Why:

Registry URLs must include https://. Without this, publish will fail with the following warning/error:

npm WARN invalid config registry="npm.pkg.github.com"
npm WARN invalid config Must be a full url with 'http://'
npm ERR! code E404
npm ERR! 404 Not Found - PUT https://registry.npmjs.org/@jcansdale-test%2fnpm-errors - Not found
npm ERR! 404 

https://github.com/jcansdale-test/npm-errors/runs/1263431619?check_suite_focus=true#step:4:1

What's being changed:

Changing the highlighted line to include https://.

image

Check off the following:

@welcome

welcomeBot commented Oct 16, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

Copy link
Copy Markdown
Contributor

Thanks for opening a PR @jcansdale! I'll get this triaged for review ⚡

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team labels Oct 19, 2020
@janiceilenejaniceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020

@rachmarirachmari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcansdale thank you for this update! This looks great. I'll get it merged right away. 🚢

@rachmarirachmari self-assigned this Nov 4, 2020
@madmax25361

This comment has been minimized.

@rachmari
rachmari merged commit 8c64cae into mainNov 4, 2020
@rachmari
rachmari deleted the registry-https branch November 4, 2020 18:38
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contentThis issue or pull request belongs to the Docs Content teamecosystemThis issue or pull request should be reviewed by the Docs Ecosystem teamhacktoberfest-acceptedWe might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!packagesThis issue or pull request should be reviewed by the docs packages team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jcansdale@janiceilene@madmax25361@rachmari