fix: Bad code fence indenting in ordered lists

[nschonni]

Why:

Split out commit from #541 for markdown sections that cause parser issues with markdownlint because of incorrect indenting of start/end code fences

What's being changed:

• Un-started table row. Caused Crowdin to mangle it in the translated copies
• Code fences inside of ordered list that didn't have at lease 3 spaces and some that had different open/closing indents

Check off the following:

• All of the tests are passing.
• I have reviewed my changes in staging.
• For content changes, I have reviewed the localization checklist
• For content changes, I have reviewed the Content style guide for GitHub Docs.

[janiceilene]

Thanks for opening a PR @nschonni! I'll get this triaged for review 🌟

Edit: I'll wait to triage this one until we get a chance to look at the linked PR 💛

[nschonni]

@janiceilene I've removed the content changes from the other PR now, since the original issue requiring them has been fixed in Markdownlint. They are still content issues, so I'll leave the for review here

[github-actions]

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

[nschonni]

This is the only functional change

[nschonni]

Looks like this got Crowdin to parse correctly again from the changes in #1603

[nschonni]

@janiceilene@rachmari looks like the stale bot doesn't want to dismiss the label after pushing/rebasing

[janiceilene]

Looking at this again briefly, this can be reviewed by any writer! I removed @rachmari and I as reviewers and I'll move this to the anyone column for triage.

[martin389]

Thanks for this PR @nschonni! I've added a couple of suggestions as comments.

[janiceilene]

👋 @martin389 It looks like this one's ready for your 👀 again

[martin389]

Hi @nschonni 👋

I had a look at Configuring high availability replication for a cluster, and some of the rendering might need to be checked:

• In step 12 of Adding passive nodes to the cluster configuration file, the contents of the warning admonition seem to have escaped and are rendering underneath the block:
  
  This has also reset the procedure's numbering back to 1, when it should be continuing to step 13 from there.

[martin389]

Thanks for these changes, @nschonni! 🎉

I've finished my review, and added a comment above for one of the sections:

• Configuring high availability replication for a cluster - some small tweaks needed.

The rest looks good to me: 🚀

• Installing GitHub Enterprise Server on Google Cloud Platform
• Creating a pre-receive hook environment
  Creating a pre-receive hook script
• Setting your username in Git

[nschonni]

🤦 sorry about the repeat reviews. I rebased and checked that file on dev side-by-side again with poduction and they're looking the same.
I notice that there appears to be something funny going on with the list numbering with the warning/note blocks resetting the numbering, but it appears in production as well. It looks like the correct <ol start='#'> is being correctly set, but the styling is going back to 1 🤷

[martin389]

@nschonni

🤦 sorry about the repeat reviews. I rebased and checked that file on dev side-by-side again with poduction and they're looking the same.
I notice that there appears to be something funny going on with the list numbering with the warning/note blocks resetting the numbering, but it appears in production as well. It looks like the correct <ol start='#'> is being correctly set, but the styling is going back to 1 🤷

No worries, thanks so much for checking on this 🚀
It does seem like it should all be rendering as expected, so I'll do some digging around here too.

[martin389]

👋 For docs tooling folks:

The procedure numbering resets a few times in this staging article: "Configuring high availability replication for a cluster". Specific examples are listed below:

• "Assigning active nodes to the primary datacenter": (stage)(prod) - Step 5 in prod becomes step 1 in stage."
• "Adding passive nodes to the cluster configuration file": (stage)(prod) - Step 2 in prod becomes step 1 in stage. Numbering also resets again a few more times throughout this section.

[nschonni]

Sounds like it might have been an internal issue that was fixed #1552 (comment)
I'll try rebasing now to see if it fixes it

[nschonni]

@martin389 rebase looks like it fixed it 😄

[martin389]

Re-reviewed after tooling fixes were added in #1552 (comment):

• Configuring high availability replication for a cluster - 👍
• Installing GitHub Enterprise Server on Google Cloud Platform - 👍
• Creating a pre-receive hook environment - 👍
• Creating a pre-receive hook script - 👍
• Setting your username in Git - 👍

[github-actions]

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

[martin389]

Thanks again for these fixes, @nschonni! 🎉