Skip to content

Create re-request-review reusable and use it in appropriate places - #953

Merged
felicitymay merged 6 commits into
github:mainfrom
HonkingGoose:docs/897
Nov 3, 2020
Merged

Create re-request-review reusable and use it in appropriate places#953
felicitymay merged 6 commits into
github:mainfrom
HonkingGoose:docs/897

Conversation

@HonkingGoose

@HonkingGooseHonkingGoose commented Oct 31, 2020

Copy link
Copy Markdown
Contributor

Why:

Closes#897

What's being changed:

  • Create re-request-review reusable and use it in appropriate places

Image of reusable:

re-request-review-reusable

Check off the following:

@welcome

welcomeBot commented Oct 31, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene

Copy link
Copy Markdown
Contributor

Thanks so much for opening a PR @HonkingGoose! I'll get this triaged for review 🎉

@janiceilenejaniceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 2, 2020
@HonkingGoose

Copy link
Copy Markdown
ContributorAuthor

@janiceilene Thanks! I will await the review from one of your teammembers then. 😄

@felicitymayfelicitymay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏻 Hi @HonkingGoose

Thanks for identifying and fixing this oversight in the docs. I hadn't spotted the function of that sync icon, so I learnt something new today thanks to you 🙇🏻‍♀️

Since this is your first pull request in this repository, I was impressed that you chose to add something that required a resuable and got it working perfectly - this isn't one of the easiest changes to make.

I've made a couple of suggestions, but this should be ready to merge once those are addressed.

Comment threaddata/reusables/pull_requests/re-request-review.md Outdated
Comment threaddata/reusables/pull_requests/re-request-review.md Outdated
HonkingGooseand others added 2 commits November 3, 2020 21:09
Co-authored-by: Felicity Chapman <felicitymay@github.com>
@HonkingGoose

Copy link
Copy Markdown
ContributorAuthor

👋 Hi @felicitymay,

It's cool that I taught you something new about GitHub. 👍

Since this is your first pull request in this repository, I was impressed that you chose to add something that required a resuable and got it working perfectly - this isn't one of the easiest changes to make.

Yeah that took a bit of fiddling to get it working properly. The syntax for the reusable was totally new to me, but it was well documented in the contributing docs. 😄

Those suggestions you made were really good, I can see that a competent (and native English language) content writer makes a huge difference in the quality of the text. ❤️

@felicitymayfelicitymay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 😄

Yeah that took a bit of fiddling to get it working properly. The syntax for the reusable was totally new to me, but it was well documented in the contributing docs. 😄

It's really good to hear that the docs were clear. Thanks for letting us know.

Those suggestions you made were really good, I can see that a competent (and native English language) content writer makes a huge difference in the quality of the text.

I'm always surprised to find out just how many of our contributors are non-native English speakers - some many of you have such great English 🥇

I'll get this merged. Thanks for your help improving the docs.

@felicitymay
felicitymay merged commit c4b5cb2 into github:mainNov 3, 2020
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@janiceilenejaniceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 3, 2020
@HonkingGoose
HonkingGoose deleted the docs/897 branch November 4, 2020 08:23
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* added a note about the environment configuration
* added a note about environment configuration
* Update timescaledb/quick-start/ruby.md
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
* Update timescaledb/quick-start/ruby.md
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
* Update timescaledb/quick-start/ruby.md
Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com>
Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Co-authored-by: mirandaauhl <82287545+mirandaauhl@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contentThis issue or pull request belongs to the Docs Content teamhacktoberfest-acceptedWe might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Describe how to re-request a review

3 participants

@HonkingGoose@janiceilene@felicitymay