Skip to content

Remove MCP gateway JSON validation from compile --validate - #11937

Merged
pelikhan merged 10 commits into
mainfrom
copilot/remove-mcp-gateway-json-validation
Jan 26, 2026
Merged

Remove MCP gateway JSON validation from compile --validate#11937
pelikhan merged 10 commits into
mainfrom
copilot/remove-mcp-gateway-json-validation

Conversation

CopilotAI commented Jan 26, 2026•
edited by agentic-workflows-dev Bot
Loading

Copy link
Copy Markdown
Contributor

Plan to Remove MCP Gateway JSON Validation

  • Remove validation logic from pkg/workflow/mcp_renderer.go
    • Remove validation call in RenderJSONMCPConfig function (lines 847-864)
    • Remove SkipValidation field from JSONMCPConfigOptions struct
    • Remove prepareConfigForValidation function
    • Remove unused imports (console, os)
  • Update all engine files that pass SkipValidation to JSONMCPConfigOptions
    • Update pkg/workflow/copilot_mcp.go
    • Update pkg/workflow/claude_mcp.go
    • Update pkg/workflow/codex_mcp.go
    • Update pkg/workflow/custom_engine.go
  • Clean up unused validation infrastructure
    • Remove pkg/workflow/mcp_gateway_schema_validation.go (entire file)
  • Update compiler types
    • Remove CompilerSkipValidation from WorkflowData struct in pkg/workflow/compiler_types.go
    • Remove CompilerWarningCallback from WorkflowData struct
    • Remove code that sets these fields in pkg/workflow/mcp_setup_generator.go
  • Update tests
    • Fix tests in pkg/workflow/engine_helpers_shared_test.go that referenced SkipValidation
  • Build and test changes
    • Run make fmt
    • Run make build
    • Verify compilation works with --validate flag
    • Run targeted MCP tests
  • Merge main and recompile workflows
Original prompt

Remove MCP gateway JSON validation of generated MCP server json in the compile --validate command.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Changeset

  • Type: patch
  • Description: Removed MCP gateway JSON validation from gh aw compile --validate rendering.

Ahoy! This treasure was crafted by 🏴‍☠️ Changeset Generator

CopilotAIand others added 3 commits January 26, 2026 20:29
@pelikhan
Initial plan: Remove MCP gateway JSON validation
f33e56c
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Remove MCP gateway JSON validation from compile --validate command
4db0506
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Fix test failures after removing MCP gateway validation
85f4ef2
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review January 26, 2026 20:46
@pelikhan
Remove MCP gateway JSON validation from compile --validate
2c334e6
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title [WIP] Remove MCP gateway JSON validation in compile validate commandRemove MCP gateway JSON validation from compile --validateJan 26, 2026
CopilotAI requested a review from pelikhanJanuary 26, 2026 20:49
@pelikhan

pelikhan commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

@copilot merge main, recompile

CopilotAIand others added 2 commits January 26, 2026 21:16
Merge remote-tracking branch 'origin/main' into copilot/remove-mcp-ga…
2dc1171
…teway-json-validation
# Conflicts:
#	.github/aw/actions-lock.json
#	.github/workflows/go-pattern-detector.lock.yml
#	.github/workflows/release.lock.yml
#	.github/workflows/super-linter.lock.yml
#	.github/workflows/unbloat-docs.lock.yml
@pelikhan
Merge main and recompile workflows
b3b1036
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI commented Jan 26, 2026

Copy link
Copy Markdown
ContributorAuthor

@copilot merge main, recompile

Merged main and recompiled all workflows successfully (commit b3b1036).

@github-actions

github-actionsBot commented Jan 26, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

🎬 THE END — Smoke ClaudeMISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions

github-actionsBot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions

github-actionsBot commented Jan 26, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions

github-actionsBot commented Jan 26, 2026•
edited by agentic-workflows-dev Bot
Loading

Copy link
Copy Markdown
Contributor

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions

github-actionsBot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Beep boop! The Copilot smoke test agent was here on a mission to validate all systems! 🚀

Just successfully ran through a comprehensive test suite and everything's looking chef's kiss 💯

The smoke test workflow §21374387083 completed all validations - from GitHub MCP queries to Playwright browser automation, from safe-input CLI tools to Serena language services. All systems nominal! ✨

Leaving this comment trail as proof of agent activity 🕵️‍♂️

AI generated by Smoke Copilot

@github-actions

github-actionsBot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Smoke Test Results

PRs Reviewed:

Test Results:

  • ✅ GitHub MCP
  • ✅ Safe Inputs GH CLI
  • ✅ Serena MCP
  • ✅ Playwright
  • ✅ File Writing
  • ✅ Bash Tool
  • ✅ Discussion Interaction

Overall Status: PASS ✅

cc @pelikhan

AI generated by Smoke Copilot

@github-actionsgithub-actionsBot mentioned this pull request Jan 26, 2026
Closed
@github-actions

github-actionsBot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

MCP merged PRs: Update CLI versions: Copilot 0.0.395, GitHub MCP v0.30.1, Playwright 0.0.60, Gateway v0.0.80 | Add diagnostic logging and increase timeout for safe-outputs MCP server startup failures
GH CLI PRs: [WIP] Update devcontainer.json to handle missing image field | Remove MCP gateway JSON validation from compile --validate
GitHub MCP last 2 merged PRs ✅
safeinputs-gh PR list ✅
Serena activate_project ✅
Playwright title check ✅
Tavily search ✅
File write + cat ✅
Discussion query + comment ✅
Overall status: PASS

AI generated by Smoke Codex

@github-actions

github-actionsBot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actionsgithub-actionsBot mentioned this pull request Jan 26, 2026
Closed
@github-actions

github-actionsBot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Smoke Test Results:

PRs reviewed:

✅ GitHub MCP | ✅ Safe Inputs GH CLI | ✅ Serena MCP | ✅ Make Build | ✅ Playwright | ✅ Tavily Search | ✅ File Writing | ✅ Bash Tool | ✅ Discussion Interaction

Overall Status: PASS

AI generated by Smoke Claude

@github-actions

github-actionsBot commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

💥 WHOOSH! 💥

🦸 The Smoke Test Agent just blazed through here at lightspeed! 🚀⚡

KAPOW! All systems GREEN across the board! 🟢✨ GitHub MCP, Serena, Playwright, Tavily, and the whole super-squad of tools are LOCKED AND LOADED! 💪🔥

ZAP! This discussion has been officially tagged by the automated sentinel! 🛡️🤖

BLAMMO! Agent reporting for duty - mission status: COMPLETE! 🎯💯

Smoke Test Agent was here - Run §21374387127

AI generated by Smoke Claude

@pelikhan
pelikhan merged commit 3ce5917 into mainJan 26, 2026
49 checks passed
@pelikhan
pelikhan deleted the copilot/remove-mcp-gateway-json-validation branch January 26, 2026 21:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pelikhanpelikhanAwaiting requested review from pelikhan

Assignees

@pelikhanpelikhan

Copilot code reviewCopilot

Labels

smoke-claudesmoke-codexsmoke-copilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pelikhan