Enable 16 additional Go linters and fix all reported issues by Copilot · Pull Request #17714 · github/gh-aw

Copilot · 2026-02-22T13:29:27Z

Original prompt

Review enabled go linters and enable more

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

✨ PR Review Safe Output Test - Run 22279080836

💥 [THE END] — Illustrated by Smoke Claude

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

This PR expands the repo’s Go static analysis coverage by enabling 16 additional golangci-lint linters and applies broad, mechanical fixes across the codebase so the newly enabled linters pass.

Changes:

Enabled additional golangci-lint linters (error handling correctness, perf, stdlib vars, nolint hygiene).
Updated error handling patterns (errors.Is/errors.As, %w wrapping) and replaced simple fmt.Errorf/fmt.Sprintf usage where faster/std alternatives apply.
Reduced allocation hotspots in string building (e.g., strings.Builder, WriteRune, strconv formatting).

Reviewed changes

Copilot reviewed 246 out of 247 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
.golangci.yml	Enables additional linters that motivated the codebase-wide mechanical changes.
cmd/gh-aw/main.go	Replaces simple formatted errors/strings with `errors.New`/concatenation where appropriate.
pkg/cli/access_log.go	Replaces `fmt.Sprintf` for simple concatenation in verbose output.
pkg/cli/actionlint.go	Avoids `fmt.Sprintf` in constant URL and improves error typing for `*exec.ExitError` via `errors.As`.
pkg/cli/add_interactive_auth.go	Uses `errors.New` and string concatenation for simple messages.
pkg/cli/add_interactive_engine.go	Avoids `fmt.Sprintf` for simple informational output.
pkg/cli/add_interactive_git.go	Uses `errors.As` for exit errors; replaces numeric formatting with `strconv`.
pkg/cli/add_interactive_orchestrator.go	Uses `errors.New` for simple error returns.
pkg/cli/add_workflow_pr.go	Uses concatenation for commit/PR messages and success output.
pkg/cli/add_workflow_resolution.go	Uses `errors.New` for simple validation failures and output concatenation.
pkg/cli/audit.go	Uses concatenation/`strconv` for simple formatting and CLI arg construction.
pkg/cli/audit_report_analysis.go	Avoids `fmt.Sprintf` in simple string building for report text.
pkg/cli/audit_report_render.go	Uses `strconv` for numeric formatting in tables.
pkg/cli/audit_test.go	Switches to `errors.New` in tests for non-wrapping errors.
pkg/cli/codemod_bots.go	Avoids `fmt.Sprintf` when no formatting is needed.
pkg/cli/codemod_mcp_network.go	Avoids `fmt.Sprintf` when no formatting is needed for YAML line construction.
pkg/cli/codemod_roles.go	Avoids `fmt.Sprintf` when no formatting is needed.
pkg/cli/commands.go	Avoids `fmt.Sprintf` in verbose logging and GitHub API path construction.
pkg/cli/compile_batch_operations.go	Uses concatenation for simple status output.
pkg/cli/compile_helpers.go	Uses concatenation for simple progress/status output.
pkg/cli/compile_orchestration.go	Uses `errors.New` for simple “compilation failed” sentinel errors and concatenation for status output.
pkg/cli/compile_post_processing.go	Uses concatenation for simple success output.
pkg/cli/compile_stats.go	Uses `strconv` for numeric formatting in stats tables.
pkg/cli/compile_validation.go	Uses `errors.New` for simple config validation failures.
pkg/cli/compile_watch.go	Uses `errors.New` for watcher channel closure errors.
pkg/cli/compile_workflow_processor.go	Uses `errors.As` for typed shared-workflow error detection.
pkg/cli/copilot_agent.go	Avoids `fmt.Sprintf` for simple informational output.
pkg/cli/copilot_agents.go	Avoids `fmt.Sprintf` for simple informational/success output.
pkg/cli/copilot_setup.go	Uses `errors.New` for simple errors and avoids `fmt.Sprintf` for simple action refs/strings.
pkg/cli/deps_outdated.go	Uses `errors.New` for simple “not in module” errors and avoids `fmt.Sprintf` in verbose output.
pkg/cli/deps_security.go	Uses stdlib constant `http.MethodGet` and avoids `fmt.Sprintf` in verbose output.
pkg/cli/docker_images.go	Uses `errors.New` for simple “docker not available” error.
pkg/cli/download_workflow.go	Uses `%w` for both errors when returning combined API+git failures.
pkg/cli/enable.go	Uses `errors.New` for simple missing-gh error; improves error-with-suggestions formatting.
pkg/cli/error_formatting_test.go	Avoids `fmt.Sprintf` for filepath concatenation; uses `errors.New` in wrapping tests.
pkg/cli/file_tracker.go	Avoids `fmt.Sprintf` for simple verbose messages.
pkg/cli/firewall_log.go	Avoids `fmt.Sprintf` for simple informational output.
pkg/cli/fix_command.go	Avoids `fmt.Sprintf` for simple status markers.
pkg/cli/frontmatter_editor.go	Uses `append([]T(nil), ...)` to copy slices; uses `errors.New` for simple errors.
pkg/cli/gateway_logs.go	Uses `errors.New` for simple “gateway.jsonl not found” errors.
pkg/cli/generate_action_metadata_command.go	Uses `errors.New` for simple “no actions” error and avoids `fmt.Sprintf` for simple output text.
pkg/cli/hash_command.go	Avoids `fmt.Sprintf` for simple error output.
pkg/cli/health_command.go	Uses `strconv` for integer formatting and avoids `fmt.Sprintf` for simple “$” prefix.
pkg/cli/health_metrics.go	Uses `strconv` for token formatting below 1000.
pkg/cli/imports.go	Avoids `fmt.Sprintf` for simple warning output.
pkg/cli/init.go	Uses `errors.New` for simple precondition failures.
pkg/cli/interactive.go	Uses `errors.New` for non-interactive/CI guardrails and avoids `fmt.Sprintf` for simple labels.
pkg/cli/log_aggregation.go	Avoids `fmt.Sprintf` for simple informational output.
pkg/cli/logs_cache.go	Avoids `fmt.Sprintf` for simple “saved” output.
pkg/cli/logs_download.go	Uses `errors.New` for auth-required errors and avoids `fmt.Sprintf` for simple verbose/success messages.
pkg/cli/logs_github_api.go	Uses `errors.As` for exit error inspection; uses `errors.New` for auth-required error; avoids `fmt.Sprintf` in verbose “Executing” output.
pkg/cli/logs_parallel_test.go	Uses `errors.Is` for context cancellation assertion.
pkg/cli/logs_parsing_core.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/cli/logs_parsing_firewall.go	Avoids `fmt.Sprintf` for simple informational output.
pkg/cli/logs_parsing_javascript.go	Avoids `fmt.Sprintf` for simple warning output.
pkg/cli/logs_report.go	Avoids `fmt.Sprintf` for simple success output.
pkg/cli/logs_utils.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/cli/mcp_config_file.go	Avoids `fmt.Sprintf` for simple “Existing file detected” output.
pkg/cli/mcp_inspect.go	Uses `errors.As` for shared workflow errors and uses `errors.New` for flag validation.
pkg/cli/mcp_inspect_inspector.go	Avoids `fmt.Sprintf` for simple “Starting server” output.
pkg/cli/mcp_inspect_list.go	Uses `errors.New` for missing workflows directory error.
pkg/cli/mcp_inspect_mcp.go	Avoids `fmt.Sprintf` in connection strings and output headers; avoids `fmt.Sprintf` for simple verbose info.
pkg/cli/mcp_inspect_safe_inputs_files.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/cli/mcp_inspect_safe_inputs_inspector.go	Uses `errors.New` for simple missing-config/port/timeouts and avoids `fmt.Sprintf` for simple output.
pkg/cli/mcp_inspect_safe_inputs_server.go	Uses `errors.New` for simple port/timeouts and avoids `fmt.Sprintf` for simple verbose output.
pkg/cli/mcp_list.go	Uses `strconv` for counts and avoids `fmt.Sprintf` in table titles.
pkg/cli/mcp_registry.go	Avoids `fmt.Sprintf` for simple URL construction.
pkg/cli/mcp_registry_improvements_test.go	Uses `http.StatusOK` instead of literal `200`.
pkg/cli/mcp_registry_list.go	Avoids `fmt.Sprintf` for simple informational output and table title.
pkg/cli/mcp_secrets.go	Avoids `fmt.Sprintf` for simple command printing.
pkg/cli/mcp_server_command.go	Avoids `fmt.Sprintf` for simple informational output.
pkg/cli/mcp_server_helpers.go	Uses `errors.New` for simple validation failures.
pkg/cli/mcp_server_http.go	Avoids `fmt.Sprintf` for simple “Starting server” output.
pkg/cli/mcp_tools_privileged.go	Uses `errors.As` for exit errors and avoids `fmt.Sprintf` in jsonrpc error messages.
pkg/cli/mcp_tools_readonly.go	Uses `errors.As` for exit errors when extracting stderr.
pkg/cli/mcp_validation.go	Uses `errors.New` for “token not found” / timeouts and avoids `fmt.Sprintf` for simple messages.
pkg/cli/packages.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/cli/poutine.go	Uses `errors.As` for exit errors; avoids `fmt.Sprintf` for docker `-v` arg formatting.
pkg/cli/pr_automerge.go	Uses `strconv` for PR numbers; uses `errors.New` for simple workflow conclusion errors; avoids `fmt.Sprintf` for simple info output.
pkg/cli/preconditions.go	Uses `errors.New` for simple failures; avoids `fmt.Sprintf` for simple output; still uses empty-message errors in a couple branches (see comments).
pkg/cli/redacted_domains.go	Uses `errors.New("found")` as a sentinel to stop walking and avoids `fmt.Sprintf` for simple info output.
pkg/cli/remote_workflow.go	Uses `errors.New` for invalid spec and avoids `fmt.Sprintf` for simple informational output.
pkg/cli/remove_command.go	Avoids `fmt.Sprintf` for simple output lines.
pkg/cli/resolver.go	Avoids `fmt.Sprintf` for simple error-with-suggestions message construction.
pkg/cli/run_interactive.go	Uses `errors.New` for simple guardrails; avoids `fmt.Sprintf` for simple “Equivalent command” output.
pkg/cli/run_workflow_execution_test.go	Uses `errors.Is` for `context.Canceled` assertions.
pkg/cli/run_workflow_tracking.go	Uses `errors.New` for simple “no runs found” retry errors.
pkg/cli/secret_set_command.go	Uses `errors.New` for empty secret value.
pkg/cli/secrets.go	Uses `errors.As` for exit errors; uses `errors.New` for “403 access denied”.
pkg/cli/signal_aware_poll.go	Uses `errors.New` for “interrupted by user”.
pkg/cli/signal_aware_poll_test.go	Uses `errors.Is` for error comparisons.
pkg/cli/spec.go	Uses `errors.New` for simple parse/validation failures.
pkg/cli/status_command.go	Uses `errors.As` for exit errors; uses `errors.New` for empty/invalid JSON output errors; avoids `fmt.Sprintf` for simple info output.
pkg/cli/tokens_bootstrap.go	Uses `errors.New` for simple “no workflow files found” error.
pkg/cli/trial_dry_run_test.go	Uses `strconv.Itoa` for PID formatting.
pkg/cli/trial_support.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/cli/update_merge.go	Uses `errors.As` for exit errors to interpret conflicts.
pkg/cli/validation_output_test.go	Uses `errors.New` and avoids `fmt.Sprintf` in `t.Run` naming.
pkg/cli/workflows.go	Uses `errors.As` for exit errors; uses `errors.New` for empty/invalid JSON output; avoids `fmt.Sprintf` for simple success output.
pkg/cli/zizmor.go	Uses `errors.As` for exit errors and avoids `fmt.Sprintf` for docker args and simple output lines.
pkg/console/console.go	Uses `strconv.Itoa` to compute line-number width without `fmt.Sprintf`.
pkg/console/form.go	Uses `errors.New` for simple validation/TTY errors.
pkg/console/form_test.go	Uses `errors.New` for test validators.
pkg/console/input.go	Uses `errors.New` for simple validation/TTY errors.
pkg/console/input_test.go	Uses `errors.New` for test validators.
pkg/console/list.go	Uses `errors.New` for simple list/selection errors.
pkg/console/render.go	Uses `strconv` for formatting numeric/bool values where `fmt.Sprintf` was previously used.
pkg/console/select.go	Uses `errors.New` for no-options and non-TTY errors.
pkg/fileutil/fileutil.go	Uses `errors.New` for simple “path cannot be empty” error.
pkg/parser/frontmatter_content.go	Uses `errors.New` for “frontmatter not properly closed”.
pkg/parser/frontmatter_hash.go	Uses `errors.New` for “frontmatter not properly closed”.
pkg/parser/frontmatter_helpers_test.go	Uses `errors.New` in test update function.
pkg/parser/frontmatter_syntax_errors_test.go	Avoids `fmt.Sprintf` for simple error message concatenation.
pkg/parser/github.go	Uses `errors.New` for missing token error message.
pkg/parser/import_cache.go	Uses `errors.New` for path validation failures.
pkg/parser/import_error.go	Uses `errors.New` for invalid chain and avoids `fmt.Sprintf` for simple string concatenation.
pkg/parser/import_processor.go	Uses `errors.New` for schema/validation errors and import rejection messages.
pkg/parser/json_path_locator.go	Uses `errors.As` for `*jsonschema.ValidationError` extraction.
pkg/parser/remote_fetch.go	Uses `errors.New` for simple parse errors and uses `%w` for both error values in combined failures.
pkg/parser/schema_compiler.go	Simplifies schema failure message composition while maintaining multi-error formatting.
pkg/parser/schema_errors.go	Avoids `fmt.Sprintf` where simple concatenation suffices.
pkg/parser/schema_suggestions.go	Avoids `fmt.Sprintf` for simple suggestion prefix.
pkg/parser/workflow_update.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/parser/yaml_import.go	Uses `errors.New` for simple validation errors.
pkg/stringutil/pat_validation.go	Uses `errors.New` for simple token format errors.
pkg/workflow/add_comment.go	Uses `errors.New` for missing config error.
pkg/workflow/add_labels.go	Uses `errors.New` for missing config error.
pkg/workflow/agent_validation.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/workflow/agentic_output_test.go	Avoids `fmt.Sprintf` for simple substring checks.
pkg/workflow/artifact_manager.go	Uses `errors.New` for simple validation errors.
pkg/workflow/bundler_file_mode.go	Avoids `fmt.Sprintf` for simple heredoc delimiter prefix.
pkg/workflow/claude_engine.go	Uses `strconv` for env integer formatting and avoids `fmt.Sprintf` for simple YAML lines.
pkg/workflow/claude_engine_tools_test.go	Avoids `fmt.Sprintf` when building tool strings.
pkg/workflow/claude_logs.go	Uses `strings.Builder` to avoid repeated concatenation; avoids `fmt.Sprintf` for unique bash naming.
pkg/workflow/claude_tools.go	Avoids `fmt.Sprintf` when building allowed tool strings.
pkg/workflow/codex_engine.go	Uses `strings.Builder` for args concatenation and `strconv` for env integer formatting; avoids `fmt.Sprintf` for simple YAML lines.
pkg/workflow/codex_logs.go	Avoids `fmt.Sprintf` for unique bash naming.
pkg/workflow/command.go	Uses `errors.New` for empty input and avoids `fmt.Sprintf` for simple string prefix creation.
pkg/workflow/command_test.go	Removes redundant `:= ""` initialization.
pkg/workflow/compiler.go	Avoids `fmt.Sprintf` for simple error message composition and warning output.
pkg/workflow/compiler_activation_jobs.go	Uses `errors.New` for invariant failures; uses `strconv` for env integer formatting; avoids `fmt.Sprintf` for simple YAML lines.
pkg/workflow/compiler_error_formatting_test.go	Uses `errors.New` for non-wrapping test errors.
pkg/workflow/compiler_jobs.go	Avoids `fmt.Sprintf` for simple YAML line creation.
pkg/workflow/compiler_orchestrator_engine.go	Uses `errors.As` for import cycle errors; avoids `fmt.Sprintf` for simple warnings.
pkg/workflow/compiler_orchestrator_frontmatter.go	Fixes wrapping (`%w`) and uses `errors.New` for simple errors.
pkg/workflow/compiler_safe_outputs.go	Uses `append([]T(nil), ...)` for slice copy.
pkg/workflow/compiler_safe_outputs_steps.go	Fixes `//nolint` directive formatting to satisfy `nolintlint`.
pkg/workflow/compiler_string_api.go	Uses `errors.New` for “no frontmatter found”.
pkg/workflow/compiler_unlock_job.go	Uses `errors.New` for missing setup action reference error.
pkg/workflow/compiler_yaml_test.go	Avoids `fmt.Sprintf` for simple file path creation and string concatenation.
pkg/workflow/concurrency_validation.go	Avoids `fmt.Sprintf` for simple error message composition.
pkg/workflow/copilot_engine_execution.go	Uses `strconv` for env integer formatting and avoids `fmt.Sprintf` for simple YAML lines.
pkg/workflow/copilot_engine_installation.go	Avoids `fmt.Sprintf` for simple run command string.
pkg/workflow/copilot_installer.go	Avoids `fmt.Sprintf` for simple YAML line creation and artifact naming.
pkg/workflow/create_agent_session.go	Uses `errors.New` for missing config error.
pkg/workflow/create_code_scanning_alert.go	Uses `errors.New` for missing config error.
pkg/workflow/create_discussion.go	Uses `errors.New` for missing config error.
pkg/workflow/create_issue.go	Uses `errors.New` for missing config error.
pkg/workflow/create_pr_review_comment.go	Uses `errors.New` for missing config error.
pkg/workflow/create_pull_request.go	Uses `errors.New` for missing config error.
pkg/workflow/dependabot.go	Uses `errors.New` for simple “npm not found” / “lockfile not created” errors.
pkg/workflow/dispatch_workflow_validation.go	Uses `errors.New` for a multi-line static error message.
pkg/workflow/engine.go	Uses `strconv` to format numeric engine config values.
pkg/workflow/engine_firewall_support.go	Uses `errors.New` for strict-mode config errors.
pkg/workflow/engine_helpers.go	Avoids `fmt.Sprintf` for simple default step naming.
pkg/workflow/engine_helpers_shared_test.go	Uses `errors.New` in simulated-error test branch.
pkg/workflow/engine_validation.go	Avoids `fmt.Sprintf` for simple message prefixing.
pkg/workflow/error_wrapping_test.go	Uses `errors.New` where wrapping is not desired.
pkg/workflow/expression_extraction.go	Avoids `fmt.Sprintf` for expression string construction and env var name prefixes.
pkg/workflow/expression_nodes.go	Avoids `fmt.Sprintf` for simple `!` prefix.
pkg/workflow/expression_parser.go	Uses `errors.New` for empty expression; uses `strings.Builder` in a quoted-string loop (see comment for remaining allocation opportunity).
pkg/workflow/expression_validation.go	Avoids `fmt.Sprintf` for simple message concatenation.
pkg/workflow/expressions_test.go	Uses `errors.New` and `errors.Is` for better wrapped-error compatibility in tests.
pkg/workflow/frontmatter_extraction_yaml.go	Uses `strconv` for integer formatting.
pkg/workflow/frontmatter_types.go	Uses `strconv` for numeric-to-string conversions and `errors.New` for static error messages.
pkg/workflow/github_toolset_validation_error.go	Avoids `fmt.Sprintf` for simple list item prefixes.
pkg/workflow/inputs.go	Uses `strconv` for numeric defaults formatting.
pkg/workflow/jobs.go	Uses `errors.New` for simple validation errors.
pkg/workflow/known_needs_expressions.go	Uses `strings.Cut` and uses `WriteRune` to avoid allocations when uppercasing.
pkg/workflow/label_trigger_parser.go	Uses `errors.New` for static parse errors.
pkg/workflow/maintenance_workflow.go	Uses `strconv.Itoa` inside generated YAML template string.
pkg/workflow/markdown_security_scanner.go	Avoids `fmt.Sprintf` for simple finding descriptions.
pkg/workflow/mcp_gateway_mounts_test.go	Uses `strings.Builder` to avoid loop concatenation in test setup.
pkg/workflow/mcp_github_config.go	Uses `strconv` for numeric version extraction.
pkg/workflow/missing_data.go	Uses `errors.New` for missing config error.
pkg/workflow/missing_tool.go	Uses `errors.New` for missing config error.
pkg/workflow/nodejs.go	Avoids `fmt.Sprintf` for simple YAML lines.
pkg/workflow/notify_comment.go	Uses `WriteRune` to avoid allocations when converting to upper case.
pkg/workflow/npm_validation.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/workflow/permissions_operations.go	Avoids `fmt.Sprintf` for simple YAML line creation.
pkg/workflow/permissions_validation.go	Avoids `fmt.Sprintf` for simple list item prefixes.
pkg/workflow/pip_validation.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/workflow/plugin_installation.go	Avoids `fmt.Sprintf` for simple YAML and command strings.
pkg/workflow/plugin_installation_test.go	Uses `strings.Builder` for efficient step text building and avoids `fmt.Sprintf` for simple contains checks.
pkg/workflow/publish_assets.go	Uses `errors.New` for missing config error.
pkg/workflow/publish_assets_test.go	Uses `strings.Builder` for efficient step text building.
pkg/workflow/repository_features_validation.go	Avoids `fmt.Sprintf` for gh/api args and REST path construction.
pkg/workflow/runtime_overrides.go	Uses `strconv` for numeric version formatting.
pkg/workflow/runtime_setup_test.go	Uses `errors.New` in tests and uses `strings.Builder` in nested loops.
pkg/workflow/runtime_step_generator.go	Uses `strconv` for numeric YAML rendering and avoids `fmt.Sprintf` for simple YAML lines.
pkg/workflow/runtime_validation.go	Avoids `fmt.Sprintf` for simple verbose output.
pkg/workflow/safe_jobs.go	Avoids `fmt.Sprintf` for simple YAML lines and path construction.
pkg/workflow/safe_outputs_config_helpers.go	Avoids `fmt.Sprintf` for simple `runs-on` line creation.
pkg/workflow/safe_outputs_default_create_issue_test.go	Avoids `fmt.Sprintf` in `t.Run` naming.
pkg/workflow/safe_outputs_env.go	Uses `strconv` for numeric env var value formatting.
pkg/workflow/safe_outputs_runs_on_test.go	Avoids `fmt.Sprintf` for simple YAML substring expectations.
pkg/workflow/schedule_preprocessing.go	Avoids `fmt.Sprintf` for simple string suffix and error message; uses `errors.New` for static validation error.
pkg/workflow/schema_validation.go	Uses `errors.As` for `*jsonschema.ValidationError`.
pkg/workflow/secrets_validation.go	Uses `errors.New` for static validation error.
pkg/workflow/shared_workflow_test.go	Uses `errors.As` for wrapped error compatibility.
pkg/workflow/slash_command_parser.go	Uses `errors.New` for static parse error.
pkg/workflow/step_order_validation.go	Uses `errors.New` for static validation error cause.
pkg/workflow/step_types.go	Uses `errors.New` for nil map error.
pkg/workflow/strings.go	Uses `WriteRune` to avoid allocations.
pkg/workflow/threat_detection.go	Uses `errors.New` for static “not enabled” error.
pkg/workflow/threat_detection_test.go	Uses `strings.Builder` for efficient step concatenation in tests.
pkg/workflow/time_delta.go	Uses `errors.New` for static parse errors.
pkg/workflow/tools_parser.go	Uses `strconv` for numeric-to-string conversions.
pkg/workflow/tools_validation.go	Uses `errors.New` for static validation errors.
pkg/workflow/validation_helpers.go	Uses `strconv.Itoa` for integer-to-string conversions in validation errors.

Comments suppressed due to low confidence (1)

pkg/cli/preconditions.go:229

Returning errors.New("") here produces an error with no message, which is difficult to debug and cannot be distinguished from other failures. Consider returning a descriptive error (or a named sentinel) and avoid relying on side-effect printing for error context.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-22T14:18:53Z

 fmt.Fprintln(os.Stderr, "Contact an organization owner if you cannot change this setting.")
 fmt.Fprintln(os.Stderr, "")
- return fmt.Errorf("") // Error already displayed above
+ return errors.New("") // Error already displayed above


Returning an error with an empty message makes it hard for callers/tests to diagnose or handle failures, even if you already printed a human-friendly message to stderr. Prefer returning a non-empty sentinel error (e.g., a package-level var) or a descriptive errors.New message (and let the caller decide whether to print).
This issue also appears on line 229 of the same file.

Fixed in 7451344. Replaced both errors.New("") occurrences with descriptive messages: "repository action permissions prevent agentic workflows from running" and "GitHub-owned actions are not allowed in this repository". Also restored the accidentally-consumed case "selected": label that was removed in the original edit.

Copilot · 2026-02-22T14:18:53Z

+ var sb strings.Builder
 for i < len(expression) {
-current += string(expression[i])
+sb.WriteString(string(expression[i]))
 if expression[i] == quote {
 i++
 break
 }
 if expression[i] == '\\' && i+1 < len(expression) {
 i++ // Skip escaped character
 if i < len(expression) {
-current += string(expression[i])
+sb.WriteString(string(expression[i]))
 }


The new strings.Builder avoids repeated concatenations, but writing each byte via sb.WriteString(string(expression[i])) still allocates a new 1-byte string per iteration. Use sb.WriteByte(expression[i]) (and similarly for the escaped byte) to avoid per-iteration allocations and fully realize the intended performance improvement.

Fixed in 7451344. Replaced sb.WriteString(string(expression[i])) with sb.WriteByte(expression[i]) to avoid per-iteration allocations.

pelikhan · 2026-02-22T14:20:12Z

@copilot review test failures https://github.com/github/gh-aw/actions/runs/22278705885/job/64445504338

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-02-22T14:28:45Z

@copilot review test failures https://github.com/github/gh-aw/actions/runs/22278705885/job/64445504338

Fixed in 7451344. The CI failure was caused by a change in compiler_orchestrator_frontmatter.go where I changed %v to %w for a file read error - that change exposed os.PathError in the error chain, which TestStandardLibraryErrorsNotExposed explicitly checks should not happen. The file had a comment saying "Intentionally not wrapping to avoid exposing internal path details" which I missed. Reverted to %v with a //nolint:errorlint suppression explaining the intent.

github-actions · 2026-02-22T14:33:36Z

🎬 THE END — Smoke ClaudeMISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-22T14:33:37Z

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

github-actions · 2026-02-22T14:33:40Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

github-actions · 2026-02-22T14:37:40Z

PR titles:

fix: use strings.Cut to resolve stringscut lint violation in known_needs_expressions
Normalize report formatting in org-health-report and daily-safe-outputs-conformance workflows
GitHub MCP: ✅
Serena MCP: ✅
Playwright: ✅
File write+cat: ✅
Bash build: ✅
Overall: PASS

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-02-22T14:39:01Z

🤖 Smoke test complete for run §22279080812

Test
GitHub MCP	✅
Safe Inputs GH CLI	✅
Serena MCP	❌
Playwright	✅
File Writing	✅
Bash Tool	✅
Discussion Query	✅
Build gh-aw	✅
Discussion Creation	✅
Workflow Dispatch	✅
PR Review	✅

Overall: PASS — @pelikhan, @Copilot

📰 BREAKING: Report filed by Smoke Copilot

github-actions

This PR enables 16 new Go linters and addresses all reported issues. The changes are clean and well-organized: using errors.New for static strings, strings.Cut for simplification, and proper errors.As/errors.Is patterns. The linter additions will improve long-term code quality. LGTM!

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-02-22T14:39:02Z

+ - durationcheck # Check for two durations multiplied together
+ - fatcontext # Detect nested contexts in loops and function literals
+ - nosprintfhostport # Check for misuse of Sprintf to construct host:port URLs
+ - reassign # Check that package variables are not reassigned


Great addition of 16 new linters! The reassign linter is especially valuable for catching accidental package-level variable reassignments. Consider adding a brief comment block grouping these into categories (e.g., "performance", "correctness", "style") to make future maintenance easier.

github-actions · 2026-02-22T14:39:02Z

 // Check if running in CI environment
 if cli.IsRunningInCI() {
- return fmt.Errorf("interactive mode cannot be used in CI environments. Please provide a workflow name")
+ return errors.New("interactive mode cannot be used in CI environments. Please provide a workflow name")


Good use of errors.New instead of fmt.Errorf for static error strings — this is exactly what the perfsprint linter enforces and avoids unnecessary allocations. 👍

github-actions · 2026-02-22T14:39:18Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-02-22T14:44:54Z

✅ Commit pushed: 9126b45

github-actions · 2026-02-22T14:44:59Z

Smoke test results for run §22279080836:

Core tests (#1-10): ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅
PR review tests (#11-17): ✅ ✅ ✅ ⚠️ ✅ ✅ ⚠️

Overall: PARTIAL (2 skipped: no review threads to resolve, no test PR to close)

💥 [THE END] — Illustrated by Smoke Claude

github-actions

💥 Automated smoke test review - all systems nominal!

💥 [THE END] — Illustrated by Smoke Claude

Initial plan
09e3a4e

CopilotAI assigned Copilot and pelikhan Feb 22, 2026

Copilotstarted work on behalf of pelikhan February 22, 2026 13:29 View session

github-actionsBot mentioned this pull request Feb 22, 2026
Smoke Test: Copilot ARM64 - 22278047040 #17722
Closed

Enable more Go linters and fix all reported issues
a6be3e4
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Review and enable additional Go linters~~Enable 16 additional Go linters and fix all reported issuesFeb 22, 2026

Copilotfinished work on behalf of pelikhan February 22, 2026 14:12

pelikhan marked this pull request as ready for review February 22, 2026 14:14

CopilotAI review requested due to automatic review settings February 22, 2026 14:14

Copilotstarted reviewing on behalf of pelikhan February 22, 2026 14:15 View session

CopilotAI reviewed Feb 22, 2026
View reviewed changes

Copilotstarted work on behalf of pelikhan February 22, 2026 14:20 View session

Fix CI failure and address review comments
7451344
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilotfinished work on behalf of pelikhan February 22, 2026 14:29

pelikhan added the smoke label Feb 22, 2026

github-actionsBot added smoke-codex and removed smoke labels Feb 22, 2026

github-actionsBot mentioned this pull request Feb 22, 2026
Smoke Test: Copilot - 22279080812 #17733
Closed

github-actionsBot added the smoke-copilot label Feb 22, 2026

github-actionsBot reviewed Feb 22, 2026
View reviewed changes

test: Add smoke test file for run 22279080836
9126b45

github-actionsBot mentioned this pull request Feb 22, 2026
Smoke Test: Claude - 22279080836 #17734
Closed

github-actionsBot added the smoke-claude label Feb 22, 2026

github-actionsBot reviewed Feb 22, 2026
View reviewed changes

pelikhan merged commit dce6f84 into mainFeb 22, 2026

pelikhan deleted the copilot/enable-more-go-linters branch February 22, 2026 14:45

github-actionsBot mentioned this pull request Feb 22, 2026
[docs] Update documentation for features from 2026-02-22 #17741
Merged

Uh oh!

Conversation

CopilotAI commented Feb 22, 2026• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

CopilotAIFeb 22, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIFeb 22, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIFeb 22, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIFeb 22, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Feb 22, 2026

Uh oh!

CopilotAI commented Feb 22, 2026

Uh oh!

github-actionsBot commented Feb 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Feb 22, 2026

Uh oh!

github-actionsBot commented Feb 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Feb 22, 2026

Uh oh!

github-actionsBot commented Feb 22, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotFeb 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBotFeb 22, 2026

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Feb 22, 2026

Uh oh!

github-actionsBot commented Feb 22, 2026

Uh oh!

github-actionsBot commented Feb 22, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CopilotAI commented Feb 22, 2026•
edited by github-actions Bot
Loading

github-actionsBot commented Feb 22, 2026•
edited
Loading

github-actionsBot commented Feb 22, 2026•
edited
Loading