Uh oh!
There was an error while loading. Please reload this page.
[jsweep] Clean add_labels.cjs - #18439
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
- Remove unused HANDLER_TYPE constant (dead code) - Split long itemNumber ternary for readability - Add 2 new tests: staged mode preview and blocked label patterns (24 total) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleaned
actions/setup/js/add_labels.cjsas part of the jsweep unbloat initiative.Context type: github-script (uses
core,github,contextglobals)Changes
add_labels.cjsHANDLER_TYPEconstant that was defined but never referenced anywhere in the fileitemNumberternary assignment across multiple lines for better readabilityadd_labels.test.cjsGH_AW_SAFE_OUTPUTS_STAGED=true), labels are previewed but not submitted to the GitHub APIinternal-*) correctly filter out matching labels while allowing others throughValidation ✅
All four checks passed:
npm run format:cjsnpm run lint:cjsnpm run typechecknpm run test:js— 24 tests passWarning
The following domain was blocked by the firewall during workflow execution:
proxy.golang.org