Skip to content

Beginnings of multi repo PR support - #18599

Merged
dsyme merged 20 commits into
mainfrom
mrp
Mar 1, 2026
Merged

Beginnings of multi repo PR support#18599
dsyme merged 20 commits into
mainfrom
mrp

Conversation

@dsyme

@dsymedsyme commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator
  • Investigate CI failure in safe_outputs_handlers.test.cjs
  • Fix failing test: update assertion from "not found" to "not in the allowed-repos list" since the allowed-repos validation now runs before workspace checkout validation
  • Remove stale details field assertions that no longer apply to the allowed-repos error path
  • Verify test passes locally
  • Fix checkoutRepo() slug validation to reject slugs with more than one slash (e.g., owner/repo/extra) by enforcing parts.length === 2
  • Add test case for extra-slash slug rejection in dynamic_checkout.test.cjs
  • Use repoResult.repo (validated/qualified slug) instead of entry.repo.trim() for findRepoCheckout and patchOptions.repoSlug in safe_outputs_handlers.cjs
  • Rename test from "non-existent checkout" to "not in the allowed-repos list" to accurately describe what is tested

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Changeset

  • Type: patch
  • Description: Strengthened multi-repo checkout validation by normalizing repo slugs in the safe-output handlers, ensuring the allowed-repos error path is covered, and rejecting slugs with extra slashes.

Generated by Changeset Generator for issue #18599

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "github.com"

See Network Configuration for more information.



✨ PR Review Safe Output Test - Run 22551448932

💥 [THE END] — Illustrated by Smoke Claude

@githubgithub deleted a comment from github-actionsBotFeb 27, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@kdehl16-web

Copy link
Copy Markdown

Please work it

@kdehl16-web

Copy link
Copy Markdown

Fix the failed workflows (maybe in next commit)

@kdehl16-webkdehl16-web left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why...

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@kdehl16-web

Copy link
Copy Markdown

Pls fix conflicts

Comment threadactions/setup/js/dynamic_checkout.cjs
@githubgithub deleted a comment from kdehl16-webMar 1, 2026
@github-actions

github-actionsBot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

🎬 THE ENDSmoke ClaudeMISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions

github-actionsBot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...

@github-actions

Copy link
Copy Markdown
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions

Copy link
Copy Markdown
Contributor

Agent Container Tool Check

ToolStatusVersion
bash5.2.21
shavailable
git2.53.0
jq1.7
yq4.52.4
curl8.5.0
gh2.87.3
node20.20.0
python33.12.3
go1.24.13
java21.0.10
dotnet10.0.102

Result: 12/12 tools available ✅

Overall Status: PASS

🔧 Tool validation by Agent Container Smoke Test

@github-actions

Copy link
Copy Markdown
Contributor

Commit pushed: 194e851

Generated by Changeset Generator

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Smoke test results for @dsyme's PR:

TestStatus
GitHub MCP
Safe Inputs GH CLI
Serena MCP❌ (not available)
Playwright
Web Fetch
File Writing
Bash
Discussion Interaction
Build gh-aw
Discussion Creation
Workflow Dispatch
PR Review

Overall: ⚠️ PARTIAL PASS (Serena MCP unavailable)

📰 BREAKING: Report filed by Smoke Copilot

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a repo parameter to create_pull_request and other safe-output tools across lock files. The changes are consistent and well-described. Tests correctly reflect the updated behavior where create_pull_request always includes the repo field (from the base schema). LGTM.

📰 BREAKING: Report filed by Smoke Copilot

Comment thread.github/workflows/ci-coach.lock.yml
toolName: "create_pull_request",
expectRepo: false,
expectRepo: true,
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases correctly cover the updated behavior: create_pull_request always has a repo parameter (since it's in the base schema), and the description text is now more precise. The table-driven test structure is clean and easy to follow.

@github-actions

Copy link
Copy Markdown
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test Results — Run §22551448932

Core tests #1–10: ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅
PR review tests #11–17: ✅ ✅ ✅ ✅ ✅ ✅ ⚠️

Overall: PARTIAL (16 passed, 1 skipped — no safe PR to close for #17)

💥 [THE END] — Illustrated by Smoke Claude

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 Automated smoke test review - all systems nominal!

💥 [THE END] — Illustrated by Smoke Claude

@dsyme
dsyme merged commit 0d40e9c into mainMar 1, 2026
49 checks passed
@dsyme
dsyme deleted the mrp branch March 1, 2026 20:24
@kdehl16-web

Copy link
Copy Markdown

Stop deleting my comments

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dsyme@kdehl16-web