Uh oh!
There was an error while loading. Please reload this page.
[code-simplifier] refactor: fix orphaned comments in schema_validation.go - #19100
Merged
pelikhan merged 2 commits intoMar 1, 2026
Merged
Conversation
Remove stale comments referencing old function names (ValidateMainWorkflowFrontmatterWithSchema and ValidateIncludedFileFrontmatterWithSchema) that were disconnected from their renamed counterparts. Merge the detailed description block into the proper doc comment for ValidateMainWorkflowFrontmatterWithSchemaAndLocation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 1, 2026
pelikhan
approved these changes
Mar 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
pelikhan
deleted the
code-simplifier/fix-orphaned-comments-68ac4555d893cb9b
branch
March 1, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes orphaned comments in
pkg/parser/schema_validation.gointroduced via the PR #18906 (which added debug logging to the file).Files Simplified
pkg/parser/schema_validation.go— Removed two stale orphaned comments that referenced old function names; merged the detailed description block into the proper Go doc commentImprovements Made
Removed orphaned/stale comments:
Before the fix, there were two disconnected comment blocks:
A 9-line block labeled
// ValidateMainWorkflowFrontmatterWithSchema validates...(old function name) was separated from the actual function by a blank line, making it a floating orphan rather than a Go doc comment. Immediately below it was a single-line doc comment for the renamed functionValidateMainWorkflowFrontmatterWithSchemaAndLocation.A stale single-line comment
// ValidateIncludedFileFrontmatterWithSchema validates...(old function name) was followed by a blank line, disconnecting it from the actual functionValidateIncludedFileFrontmatterWithSchemaAndLocation.These orphaned comments referenced function names that no longer exist, which is misleading when navigating or using
go doc.After the fix:
ValidateMainWorkflowFrontmatterWithSchemaAndLocationValidateIncludedFileFrontmatterWithSchemareference is removedChanges Based On
Recent changes from:
[log] Add debug logging to 5 pkg/ filesTesting
go test -run "TestValidate.*" ./pkg/parser/)make fmt)Review Focus
Please verify:
ValidateMainWorkflowFrontmatterWithSchemaAndLocationAutomated by Code Simplifier Agent — analyzing code from the last 24 hours