[dead-code] chore: remove dead functions — 10 functions removed

[github-actions]

Dead Code Removal

This PR removes unreachable Go functions identified by the deadcode static analyzer.

Functions Removed

Function	File
ExtractMCPServer	pkg/workflow/metrics.go
SecurityFinding.String	pkg/workflow/markdown_security_scanner.go
EnhanceError	pkg/workflow/error_helpers.go
WrapErrorWithContext	pkg/workflow/error_helpers.go
extractGroupExpression	pkg/workflow/concurrency_validation.go
isGitToolAllowed	pkg/workflow/tools_validation.go
HasSafeJobsEnabled	pkg/workflow/safe_jobs.go
GetToolsetsData	pkg/workflow/permissions_validation.go
ParseIntFromConfig	pkg/workflow/config_helpers.go
parseParticipantsFromConfig	pkg/workflow/config_helpers.go

Tests Removed

Test Function	File
TestSecurityFinding_String	pkg/workflow/markdown_security_scanner_test.go
TestEnhanceError	pkg/workflow/error_helpers_test.go
TestWrapErrorWithContext	pkg/workflow/error_helpers_test.go
TestExtractGroupExpression	pkg/workflow/concurrency_validation_test.go
TestIsGitToolAllowed	pkg/workflow/tools_validation_test.go
TestHasSafeJobsEnabled	pkg/workflow/safe_jobs_test.go
TestGetToolsetsData	pkg/workflow/permissions_validator_json_test.go
TestParseIntFromConfig	pkg/workflow/config_parsing_helpers_test.go
TestParseParticipantsFromConfig	pkg/workflow/config_parsing_helpers_test.go
TestParseParticipantsFromConfigConsistency	pkg/workflow/config_parsing_helpers_test.go

Verification

• ✅ go build ./... — passes
• ✅ go vet ./... — passes
• ✅ go vet -tags=integration ./... — passes
• ✅ make fmt — applied (reformatted files match standard)
• ✅ go test ./pkg/workflow/... — passes

Dead Function Count

• Before this batch: ~71 functions (total from deadcode output)
• Removed in this PR: 10 functions
• Previously removed: 6 functions (batch 1)
• Remaining: ~55 functions

---

Automated by Dead Code Removal workflow — https://github.com/github/gh-aw/actions/runs/22682431931

Generated by Dead Code Removal Agent · ◷

• expires on Mar 7, 2026, 6:17 PM UTC

[Copilot]

Pull request overview

This PR removes 10 dead (unreferenced) Go functions and their associated tests, as identified by the deadcode static analyzer. This is the second batch in an ongoing dead code cleanup effort.

Changes:

• Removed 10 unreferenced functions across 7 source files (metrics.go, markdown_security_scanner.go, error_helpers.go, concurrency_validation.go, tools_validation.go, safe_jobs.go, permissions_validation.go, config_helpers.go)
• Removed 10 corresponding test functions across 6 test files
• Updated file-level documentation comments to remove references to deleted functions

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/workflow/metrics.go	Removed ExtractMCPServer function
pkg/workflow/markdown_security_scanner.go	Removed SecurityFinding.String method
pkg/workflow/markdown_security_scanner_test.go	Removed TestSecurityFinding_String test
pkg/workflow/error_helpers.go	Removed EnhanceError and WrapErrorWithContext functions
pkg/workflow/error_helpers_test.go	Removed TestEnhanceError and TestWrapErrorWithContext tests
pkg/workflow/concurrency_validation.go	Removed extractGroupExpression function and its doc reference
pkg/workflow/concurrency_validation_test.go	Removed TestExtractGroupExpression test
pkg/workflow/tools_validation.go	Removed isGitToolAllowed function
pkg/workflow/tools_validation_test.go	Removed TestIsGitToolAllowed test
pkg/workflow/safe_jobs.go	Removed HasSafeJobsEnabled function
pkg/workflow/safe_jobs_test.go	Removed TestHasSafeJobsEnabled test
pkg/workflow/permissions_validation.go	Removed GetToolsetsData function
pkg/workflow/permissions_validator_json_test.go	Removed TestGetToolsetsData test
pkg/workflow/config_helpers.go	Removed parseParticipantsFromConfig and ParseIntFromConfig functions, updated doc comment
pkg/workflow/config_parsing_helpers_test.go	Removed TestParseParticipantsFromConfig, TestParseParticipantsFromConfigConsistency, and TestParseIntFromConfig tests

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.