Skip to content

refactor: rename runActionlintOnFile to runActionlintOnFiles - #20941

Merged
pelikhan merged 3 commits into
mainfrom
copilot/function-namer-rename-functions
Mar 14, 2026
Merged

refactor: rename runActionlintOnFile to runActionlintOnFiles#20941
pelikhan merged 3 commits into
mainfrom
copilot/function-namer-rename-functions

Conversation

CopilotAI commented Mar 14, 2026

Copy link
Copy Markdown
Contributor

The unexported runActionlintOnFile accepted []string but its name implied a single file, inconsistent with the exported RunActionlintOnFiles wrapper it backs.

Changes

  • pkg/cli/actionlint.go: Renamed runActionlintOnFilerunActionlintOnFiles (function + comment)
  • pkg/cli/compile_validation.go: Updated all three call sites
// BeforefuncrunActionlintOnFile(lockFiles []string, verbosebool, strictbool) error {
// AfterfuncrunActionlintOnFiles(lockFiles []string, verbosebool, strictbool) error {

Pure rename — no behavior changes.

CopilotAIand others added 2 commits March 14, 2026 03:39
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI review requested due to automatic review settings March 14, 2026 14:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames an unexported helper to accurately reflect that it operates on a slice of lock files, aligning it with the exported RunActionlintOnFiles wrapper.

Changes:

  • Renamed runActionlintOnFilerunActionlintOnFiles in pkg/cli/actionlint.go (function + comment).
  • Updated RunActionlintOnFiles and two per-file validation call sites to use the new helper name.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
pkg/cli/actionlint.goRenames the internal actionlint helper and its comment to reflect multi-file behavior.
pkg/cli/compile_validation.goUpdates the wrapper and validation call sites to call the renamed helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@pelikhan
pelikhan merged commit 4e41f2f into mainMar 14, 2026
55 of 56 checks passed
@pelikhan
pelikhan deleted the copilot/function-namer-rename-functions branch March 14, 2026 14:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[function-namer] Go function rename plan: access_log.go, actionlint.go, actions.go

3 participants

@pelikhan