Uh oh!
There was an error while loading. Please reload this page.
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the GitHub Actions artifact name by renaming agent-artifacts to agent across workflows, test fixtures, scripts, and user-facing guidance, while also removing legacy artifact reference documentation.
Changes:
- Renamed the unified artifact from
agent-artifactstoagentin templates, golden fixtures, and JS/Go tooling. - Updated
gh run downloadinstructions and patch application paths to use the new artifact name. - Removed an auto-generated artifact location reference document.
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scratchpad/safe-output-messages.md | Updates user-facing patch download/apply instructions to reference agent. |
| scratchpad/artifacts.md | Removes auto-generated artifact location reference (previously documented agent-artifacts). |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-test-tools.golden | Updates golden workflow fixture to upload agent artifact. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/claude-with-network.golden | Updates golden workflow fixture to upload agent artifact. |
| pkg/workflow/test-yaml-import.lock.yml | Updates lock fixture to upload agent artifact. |
| pkg/workflow/artifact_manager.go | Updates inline documentation example to agent. |
| pkg/parser/remote_fetch.go | Changes HTTP error-path handling for raw URL downloads. |
| pkg/cli/logs_flatten_test.go | Updates tests to expect unified artifact directory named agent. |
| pkg/cli/logs_download.go | Updates comment to reflect unified agent artifact flattening. |
| pkg/cli/logs_awinfo_resolution_test.go | Updates tests to expect unified artifact directory named agent. |
| docs/src/content/docs/reference/frontmatter.md | Trims checkout docs and updates timeout-minutes reference text. |
| actions/setup/md/manifest_protection_push_to_pr_fallback.md | Updates fallback instructions to download/apply from agent. |
| actions/setup/md/manifest_protection_push_failed_fallback.md | Updates fallback instructions to download/apply from agent. |
| actions/setup/js/setup_threat_detection.cjs | Updates internal comments to reference agent artifact. |
| actions/setup/js/handle_agent_failure.test.cjs | Updates test expectation for new artifact name. |
| actions/setup/js/handle_agent_failure.cjs | Updates failure guidance to download/use agent artifact paths. |
| actions/setup/js/create_pull_request.cjs | Updates PR-creation guidance to download/use agent artifact paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+271
to
272
| agentArtifactsDir := filepath.Join(tmpDir, "agent") | ||
| if _, err := os.Stat(agentArtifactsDir); err == nil { |
There was a problem hiding this comment.
The variable name agentArtifactsDir no longer matches the directory it points to (agent). Renaming it to something like agentDir (or unifiedArtifactDir) would reduce confusion, especially since this code was updated as part of the artifact rename.
Suggested change
| agentArtifactsDir:=filepath.Join(tmpDir, "agent") | |
| if_, err:=os.Stat(agentArtifactsDir); err==nil { | |
| agentDir:=filepath.Join(tmpDir, "agent") | |
| if_, err:=os.Stat(agentDir); err==nil { |
Uh oh!
There was an error while loading. Please reload this page.
agent-artifacts to agentCo-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-artifactstoagentgh run downloadCLI instructions in PR comments, fallback markdown templates, and error-handling scripts to reference the newagentartifact name and local download path/tmp/agent-{run_id}scratchpad/artifacts.md,specs/artifacts.md) and trimmed verbosecheckout:documentation in favor of cross-reference links