Uh oh!
There was an error while loading. Please reload this page.
feat: support uses/with import syntax, import-schema validation, deprecate tools.serena, migrate workflows to serena-go.md, and enforce single-import constraint - #23192
Merged
Conversation
This was referenced Mar 27, 2026
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/fb37a409-f510-46bc-92af-4af5823c2c42 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/fb37a409-f510-46bc-92af-4af5823c2c42 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Add support for import schemas in compilerfeat: support Mar 27, 2026
uses/with import syntax and import-schema validationpelikhan
commented
Mar 27, 2026
Collaborator
@copilot allow one level deep object definitions in import-schema It should be enough to recreate the qmd configuration data |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/32fe5daa-b76d-433b-8bac-6b8318f7d59a Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
ContributorAuthor
Done in 8714dad. import-schema:
config:
type: objectproperties:
apiKey:
type: stringrequired: truetimeout:
type: numberdefault: 30Sub-fields are validated (unknown keys, required checks, scalar type matching) and accessible via Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
CopilotAI
changed the title
feat: support feat: support Mar 27, 2026
uses/with import syntax and import-schema validationuses/with import syntax and import-schema validation with object typespelikhan
commented
Mar 27, 2026
Collaborator
@copilot create a shared agentic workflow that uses import-schema and inputs to reimplement the "serena" tool support.
|
…-schema
- Add `type: array` with optional `items` validation to import-schema
- Apply expression substitution to imported workflow frontmatter before processing,
enabling `tools.serena: ${{ github.aw.import-inputs.languages }}` patterns
- Serialize arrays as JSON when substituting into raw content (valid YAML inline)
- Add `import-schema` to allowed fields list for shared workflow frontmatter
- Suppress schema validation warnings for shared files with unsubstituted expressions
- Create `.github/workflows/shared/mcp/serena.md` using import-schema with languages array
- Add TestImportSchemaArrayType with 4 sub-tests covering valid/invalid array inputs
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/bc90492b-01ba-40ad-a7e2-d311ab30a41c
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>ContributorAuthor
Done in 242029a. Here's what was added:
import-schema:
languages:
type: arrayitems:
type: stringrequired: trueArray items are validated element-by-element. Arrays serialize as JSON ( Frontmatter expression substitution: New # Importing workflowimports:
- uses: shared/mcp/serena.mdwith:
languages: ["go", "typescript"]The shared workflow declares Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
CopilotAI
changed the title
feat: support feat: support Mar 27, 2026
uses/with import syntax and import-schema validation with object typesuses/with import syntax and import-schema validation with object and array typespelikhan
commented
Mar 27, 2026
Collaborator
@copilot reimplement the Serena tool functionality in the Serena.md workflows WITHOUT using tools.serena |
- Replace `tools: serena:` with `mcp-servers: serena:` in shared/mcp/serena.md
- Also suppress mcp-servers schema validation warnings for shared files
containing unsubstituted ${{ }} expressions (same as tools)
- Update TestImportSchemaArrayType to match the new mcp-servers.serena pattern
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/d50d23b1-dff6-4543-a803-70560a92d071
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>ContributorAuthor
Done in 788997c. mcp-servers:
serena: ${{ github.aw.import-inputs.languages }}After expression substitution (e.g., I also fixed the schema validation to suppress Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
pelikhan
commented
Mar 27, 2026
Collaborator
@copilot mark tools.serena as deprecated |
Contributor
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
Contributor
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
Contributor
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
🎬 THE END — Smoke ClaudeMISSION: ACCOMPLISHED! The hero saves the day! ✨ |
Contributor
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
Contributor
Smoke test results for run §23684090942:
Overall: ✅ PASS
|
Contributor
There was a problem hiding this comment.
Smoke test review for PR #23192. Changeset and expression extraction changes look correct. The import-schema feature with uses/with syntax is well-implemented.
📰 BREAKING: Report filed by Smoke Copilot
| // awImportInputsExprRegex matches ${{ github.aw.import-inputs.<key> }} and | ||
| // ${{ github.aw.import-inputs.<key>.<subkey> }} expressions (import-schema form). | ||
| // Captures the full dotted path (e.g. "count" or "config.apiKey"). | ||
| var awImportInputsExprRegex = regexp.MustCompile(`\$\{\{\s*github\.aw\.import-inputs\.([a-zA-Z0-9_-]+(?:\.[a-zA-Z0-9_-]+)?)\s*\}\}`) |
Contributor
There was a problem hiding this comment.
🔍 Smoke test review: New awImportInputsExprRegex looks good. The pattern correctly handles github.aw.import-inputs.<key> expressions for typed input validation in imported workflows.
| "gh-aw": patch | ||
| --- | ||
| Add support for workflow imports using `uses`/`with` syntax with `import-schema` validation, including typed input validation and `github.aw.import-inputs.*` expression support in imported content. |
Contributor
There was a problem hiding this comment.
🔍 Smoke test review: Changeset correctly describes the uses/with import syntax addition and the deprecation of tools.serena. Clear and informative.
Contributor
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
Smoke Test Results — Run §23684090954Core tests: ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅ ✅
Overall: PARTIAL (2 skipped, 0 failed)
|
Contributor
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude
| "gh-aw": patch | ||
| --- | ||
| Add support for workflow imports using `uses`/`with` syntax with `import-schema` validation, including typed input validation and `github.aw.import-inputs.*` expression support in imported content. |
Contributor
There was a problem hiding this comment.
Good changeset description — clearly summarizes the import schema additions and the tools.serena deprecation in one concise entry.
| # Resolved workflow manifest: | ||
| # Imports: | ||
| # - shared/mcp/serena-go.md | ||
| # - shared/mcp/serena.md |
Contributor
There was a problem hiding this comment.
Adding shared/mcp/serena.md to the resolved imports list looks correct — this aligns with the migration from tools.serena to the new shared MCP server workflow.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the workflow import system to support GitHub Actions–style uses/with syntax, introduces import-schema for validating imported inputs, adds github.aw.import-inputs.* expressions, and migrates Serena usage away from tools.serena toward shared workflows with explicit mcp-servers.serena configuration.
Changes:
- Add
uses/withimport spec parsing, nested import propagation, and enforce single-import consistency (conflictingwithvalues error). - Add
import-schemasupport: schema declaration,withvalidation, and expression substitution viagithub.aw.import-inputs.*. - Deprecate
tools.serena, add shared Serena workflows, update renderers/docker image collection, and migrate existing workflows/locks.
Reviewed changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/tools_parser.go | Updates tool documentation to mark Serena as deprecated in the tools section. |
| pkg/workflow/strict_mode_serena_test.go | Adjusts strict-mode tests to clarify deprecated-but-allowed Serena behavior. |
| pkg/workflow/serena_go_import_test.go | Adds end-to-end tests for serena-go.md → serena.md import chains and MCP config rendering. |
| pkg/workflow/mcp_renderer.go | Routes serena to the custom MCP renderer when explicit container config is present. |
| pkg/workflow/frontmatter_types.go | Adds import-schema to typed frontmatter config. |
| pkg/workflow/expression_safety_validation.go | Allows github.aw.import-inputs.* (including dotted object access) through safety validation. |
| pkg/workflow/expression_patterns.go | Adds regex patterns for github.aw.import-inputs.* extraction/substitution. |
| pkg/workflow/expression_extraction.go | Implements substitution for github.aw.import-inputs.* values, including dotted lookup and JSON serialization for arrays/maps. |
| pkg/workflow/docker.go | Collects Serena Docker images from explicit container: config first, with legacy fallback. |
| pkg/workflow/compiler_orchestrator_tools.go | Emits tools.serena deprecation warnings only for explicit tools.serena usage in top-level frontmatter. |
| pkg/workflow/codex_mcp.go | Mirrors serena custom-rendering behavior for Codex MCP output. |
| pkg/parser/schemas/main_workflow_schema.json | Extends schema with import-schema, uses/with import item form, and marks tools.serena deprecated. |
| pkg/parser/include_processor.go | Permits import-schema in shared frontmatter and defers validation when unsubstituted expressions exist. |
| pkg/parser/import_field_extractor.go | Substitutes import inputs into raw content, validates with against import-schema, and extracts fields from substituted content. |
| pkg/parser/import_conflict_test.go | Adds unit tests for conflicting/duplicate imports and transitive conflict detection. |
| pkg/parser/import_bfs.go | Parses uses/with in nested imports and enforces single-import input consistency via visitedInputs. |
| .github/workflows/shared/mcp/serena.md | Adds parameterized Serena shared workflow with explicit MCP server config and import-schema. |
| .github/workflows/shared/mcp/serena-go.md | Adds Go wrapper workflow importing serena.md via uses/with. |
| .github/workflows/smoke-copilot.md | Migrates Serena configuration to shared Serena imports. |
| .github/workflows/smoke-copilot-arm.md | Migrates Serena configuration to shared Serena imports. |
| .github/workflows/smoke-codex.md | Migrates Serena configuration to shared Serena imports. |
| .github/workflows/smoke-claude.md | Migrates Serena configuration to shared Serena imports. |
| .github/workflows/jsweep.md | Migrates Serena configuration to imports: uses: shared/mcp/serena.md with languages input. |
| .github/workflows/daily-mcp-concurrency-analysis.md | Migrates Serena configuration to shared Serena import with multi-language input. |
| .github/workflows/terminal-stylist.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/smoke-codex.lock.yml | Updates resolved manifest and MCP config rendering after Serena import chain changes. |
| .github/workflows/sergo.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/repository-quality-improver.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/q.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/mcp-inspector.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/jsweep.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/glossary-maintainer.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/duplicate-code-detector.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/daily-testify-uber-super-expert.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/daily-mcp-concurrency-analysis.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/daily-function-namer.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/daily-file-diet.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/daily-compiler-quality.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .github/workflows/archie.lock.yml | Updates resolved manifest and rendered prompt/config output after Serena import chain changes. |
| .changeset/patch-add-import-schema-uses-with.md | Adds changeset entry describing new import syntax/schema and Serena deprecation/migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pelikhan
commented
Mar 28, 2026
Collaborator
@copilot use technical doc writer
|
…te Serena guide with deprecation notice Agent-Logs-Url: https://github.com/github/gh-aw/sessions/bf26247c-4cc3-45c1-9048-fa1dbc11dd30 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
ContributorAuthor
Done in 723519e.
|
pelikhan
commented
Mar 28, 2026
Collaborator
…estifylint) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ae9513a1-b9f8-4242-814d-110a956fa40d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
ContributorAuthor
Fixed in 17f3092. Replaced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports currently only accept a string path or
{path, inputs}object. This adds auses/withform (mirroring GitHub Actions reusable workflow syntax), a top-levelimport-schemafield for declaring and validating those inputs, and new expressions for accessing them.New syntax
New: Parameterized Serena shared workflows
shared/mcp/serena.mdusesimport-schemato accept alanguagesarray and configures a complete explicit Serena MCP server (container, args, entrypoint, entrypointArgs, and workspace mount) — without relying on anytools.serenashorthand:shared/mcp/serena-go.mdis a Go-specific convenience wrapper that importsserena.mdpre-configured for Go:Deprecation:
tools.serenatools.serenais now deprecated in favour ofmcp-servers.serenavia theshared/mcp/serena.mdshared workflow. Compiling any workflow that usestools.serenaemits a deprecation warning:Existing workflows continue to compile without errors (backward compatible). The deprecation warning only fires when
tools.serenais explicitly set in the workflow frontmatter — it no longer fires incorrectly whenmcp-servers.serenais used via the recommended import path.Single-import constraint with
withconflict detectionA workflow file can now only be imported once per import graph. If the same file appears more than once, the
withvalues must be identical — conflicting values produce a compile-time error:Identical
withvalues (including both empty) continue to be silently deduplicated. The check applies to both direct imports and transitively discovered nested imports.Migrated workflows
All agentic workflows that previously used
tools.serenadirectly have been migrated:smoke-copilot.md,smoke-copilot-arm.md,smoke-claude.md,smoke-codex.md— now importshared/mcp/serena-go.mdjsweep.md— now usesimports: - uses: shared/mcp/serena.md with: languages: ["typescript"]daily-mcp-concurrency-analysis.md— now usesimports: - uses: shared/mcp/serena.md with: languages: ["go", "typescript"]Changes
pkg/parser/import_bfs.go—parseImportSpecsFromArraynow acceptsusesas alias forpathandwithas alias forinputs; BFS nested import discovery now handlesuses/withmap syntax (previously only plain strings), enabling chains likeserena-go.md → serena.mdto correctly propagatemcp-serversand tools to the parent workflow; addsvisitedInputsmap andcheckImportInputsConsistency/importInputsEqual/formatImportInputshelpers to enforce the single-import constraintpkg/parser/import_conflict_test.go— four tests covering: conflictingwithvalues (error), identicalwithvalues (ok), no-withdeduplication (ok), and transitive nested conflict (error)pkg/parser/import_field_extractor.go— validateswithvalues against the imported workflow'simport-schema: required fields, unknown keys, type matching (string,number,boolean,choice,object,array), choice membership, object sub-property validation, and per-element array item type validation; addssubstituteImportInputsInContentto apply expression substitution to raw imported file content (including YAML frontmatter) before parsingpkg/parser/include_processor.go— addsimport-schemato the allowed fields list for shared workflow frontmatter; suppresses schema validation warnings for shared files containing unsubstituted${{ }}expressions in bothtoolsandmcp-serversfields (resolved at import time)pkg/parser/schemas/main_workflow_schema.json— addsimport-schematop-level property supporting scalar, object, and array types; extends import itemoneOfwithuses/withobject form; allows object and array values inwith; markstools.serenaasdeprecated: truewithx-deprecation-messagepkg/workflow/frontmatter_types.go— addsImportSchema map[string]anyfield toFrontmatterConfigpkg/workflow/expression_patterns.go— addsAWImportInputsPattern/AWImportInputsExpressionPatternforgithub.aw.import-inputs.*and dotted paths (github.aw.import-inputs.<key>.<subkey>)pkg/workflow/expression_extraction.go—SubstituteImportInputshandlesgithub.aw.inputs.*(legacy),github.aw.import-inputs.<key>(scalar/array), andgithub.aw.import-inputs.<key>.<subkey>(object sub-field); addsresolveImportInputPathfor dotted-path lookup; arrays and maps serialize as JSON (valid YAML inline syntax) viamarshalImportInputValuepkg/workflow/expression_safety_validation.go— permitsgithub.aw.import-inputs.*and dotted forms through expression safety checkspkg/workflow/tools_parser.go— removes thetools.serenadeprecation warning fromNewTools(was firing incorrectly formcp-servers.serenausage)pkg/workflow/compiler_orchestrator_tools.go— emits thetools.serenadeprecation warning only whentools.serenais explicitly set in the frontmattertools:section, before any mcp-servers mergingpkg/workflow/mcp_renderer.goandpkg/workflow/codex_mcp.go—case "serena":now routes to the generic custom MCP renderer when an explicitcontainer:config is present, instead of always using the hardcoded serena-specific rendererpkg/workflow/docker.go— Docker image collection reads the explicitcontainer:value from the serena config map first, falling back to language-based selection for legacytools.serenausagepkg/workflow/serena_go_import_test.go— addsTestImportSerenaGoMD(end-to-endmain.md → serena-go.md → serena.mdchain verifying Serena MCP container config, entrypoint args, and docker download step) andTestImportSerenaWithLanguagesMD(directserena.mdimport with multiple languages).github/workflows/shared/mcp/serena.md— parameterized shared workflow usingimport-schemawithlanguages: {type: array}that configures a complete explicit Serena MCP server (container, args, entrypoint, entrypointArgs, mounts) viamcp-servers.github/workflows/shared/mcp/serena-go.md— Go-specific convenience wrapper that importsserena.mdwithlanguages: ["go"]Backward compatibility is preserved: imports without
import-schemaaccept anywith/inputsvalues unchanged; workflows usingtools.serenacontinue to compile with a deprecation warning.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.
✨ PR Review Safe Output Test - Run 23673763387
Changeset
uses/withimport syntax withimport-schemainput validation andgithub.aw.import-inputs.*expressions, and deprecatestools.serenain favor of shared Serena workflows backed bymcp-servers.serena.✨ PR Review Safe Output Test - Run 23684090954