Standardize repository access with cached implementation

[Copilot]

Plan: Standardize Repository Access with Cached Implementation

• Review current implementations and their usage patterns
• Create shared cached implementation in pkg/cli/repo.go
  • Add sync.Once pattern for caching
  • Export cached version for cross-package use
  • Add fallback to git remote if gh CLI is not available
• Update pkg/cli/trial_command.go to use shared function
• Update pkg/cli/spec.go to use shared function (via getCurrentRepositoryInfo)
• Create pkg/workflow/workflow_name.go per comment request
  • Extract SanitizeWorkflowName function
  • Extract ConvertToIdentifier function → renamed to SanitizeIdentifier
  • Update copilot_engine.go to use exported functions
  • Update codex_engine.go to use exported functions
• Add tests for cached behavior
• Run make test-unit to verify all tests pass
• Run make agent-finish before final commit
• Move repository slug logic to pkg/cli/repo.go (per PR comment)
• Rename functions for clarity (per PR comments)
  • GetCurrentRepoSlug() → getCurrentRepoSlugUncached() (unexported)
  • GetCurrentRepoSlugCached() → GetCurrentRepoSlug() (cached is now default)
  • ConvertToIdentifier() → SanitizeIdentifier() (clearer purpose)
• Fix test failures after merge from main
  • Removed duplicate SanitizeWorkflowName from workflow_name.go (now in strings.go)
• Improve function naming and documentation
  • Clarified function purpose and behavior in doc comments
  • Improved inline comments for better readability
  • Renamed to better reflect actual usage

Changes Made

1. Repository Slug Logic Refactoring (pkg/cli/repo.go)

• Created: pkg/cli/repo.go with all repository slug functions
  • GetCurrentRepoSlug() - cached version (default) using sync.Once
  • getCurrentRepoSlugUncached() - unexported uncached function with gh CLI → git remote fallback
  • ClearCurrentRepoSlugCache() - cache clearing for tests
• Created: pkg/cli/repo_test.go with all repository slug tests
• Updated: pkg/cli/shared_utils.go - removed repository slug logic
• Deleted: pkg/cli/shared_utils_test.go - tests moved to repo_test.go

2. Function Naming Convention

• Default is cached: GetCurrentRepoSlug() is now the cached version (recommended for all usage)
• Uncached is internal: getCurrentRepoSlugUncached() is unexported and only used internally
• Clear naming: Function names clearly indicate their behavior without redundant "Cached" suffix

3. Enhanced pkg/cli/repo.go

• Added caching infrastructure with sync.Once pattern
• GetCurrentRepoSlug() is the canonical cached function (default)
• getCurrentRepoSlugUncached() has fallback to git remote parsing
• ClearCurrentRepoSlugCache() for testing

4. Updated Callers

• pkg/cli/trial_command.go: Uses GetCurrentRepoSlug() (cached by default)
• pkg/cli/run_command.go: Already uses GetCurrentRepoSlug() (now cached)
• pkg/cli/spec.go: Uses shared cached function transitively

5. Enhanced pkg/workflow/workflow_name.go

• Renamed: ConvertToIdentifier() → SanitizeIdentifier() for clarity
• Made function exported for cross-package use
• Improved documentation: Clarified it sanitizes names for safe identifier use (user agents, etc.)
• Better function name: "SanitizeIdentifier" clearly indicates it's cleaning/sanitizing input
• Note: SanitizeWorkflowName() was removed after merge as it's now in strings.go

6. Updated Engine Files

• pkg/workflow/copilot_engine.go: Uses SanitizeWorkflowName() from strings.go
• pkg/workflow/codex_engine.go: Uses SanitizeIdentifier() from workflow_name.go

7. Tests

• pkg/cli/repo_test.go: Tests for cached behavior and format validation
• pkg/cli/local_workflow_trial_test.go: Added cache clearing
• pkg/cli/spec_test.go: Added cache clearing
• pkg/cli/trial_command_test.go: Removed redundant test
• pkg/workflow/codex_engine_test.go: Updated test name to TestSanitizeIdentifier
• All tests passing after merge conflict resolution and renaming

Usage

// Before: Multiple implementations, confusing namesrepoSlug, err:=getCurrentRepositoryInfo() // trial_command.go (git remote)repoSlug, err:=GetCurrentRepoSlug() // shared_utils.go (gh CLI, uncached)repoSlug, err:=GetCurrentRepoSlugCached() // confusing - why not default?repo, err:=getCurrentRepository() // validation.go (gh CLI, cached)// After: Single clear APIrepoSlug, err:=GetCurrentRepoSlug() // pkg/cli/repo.go - Cached by default, tries gh CLI → git remote// Workflow name sanitizationidentifier:=SanitizeIdentifier(workflowName) // Clear purpose: creates safe identifier

Key Benefits

• Organized Code: Repository logic now in dedicated repo.go file
• Clear API: Cached version is the default - no confusing "Cached" suffix needed
• Single Source of Truth: One canonical function for repository access
• Performance: Caching reduces repeated gh CLI/git remote calls via sync.Once
• Reliability: Fallback mechanism ensures compatibility (gh CLI → git remote)
• Maintainability: Consolidated logic easier to update
• Backward Compatibility: All existing functionality preserved
• Test Isolation: Cache clearing ensures clean test state
• Merge Compatible: Resolved conflicts with main branch changes
• Clear Documentation: Improved function documentation and naming for better understanding
• Descriptive Names: Function names now clearly indicate their purpose (e.g., SanitizeIdentifier vs ConvertToIdentifier)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[task] Standardize repository access with cached implementation</issue_title>
<issue_description>## Objective
Consolidate three different repository access implementations into a single, cached, canonical approach.

Context

Three different functions exist to get current repository information:

1. pkg/cli/shared_utils.go:163 - GetCurrentRepoSlug() (uses gh repo view)
2. pkg/cli/trial_command.go:443 - getCurrentRepositoryInfo() (parses git remote)
3. pkg/workflow/validation.go:431 - getCurrentRepository() (cached with sync.Once)

Each has different trade-offs (reliability, portability, performance), but standardization would improve maintainability.

Approach

1. Enhance GetCurrentRepoSlug() from shared_utils.go as the canonical implementation (most reliable using official gh CLI)
2. Add caching using sync.Once pattern from validation.go
3. Export a cached version for cross-package use
4. Update trial_command.go to use the shared cached function
5. Consider updating validation.go to use the shared implementation
6. Ensure backward compatibility for all existing call sites

Files to Modify

• Update: pkg/cli/shared_utils.go (add caching with sync.Once)
• Update: pkg/cli/trial_command.go (replace getCurrentRepositoryInfo() with shared function)
• Update: pkg/workflow/validation.go (consider using shared cached version)
• Update: pkg/cli/shared_utils_test.go (add tests for cached behavior)

Acceptance Criteria

• Single cached implementation exists in shared_utils.go
• sync.Once pattern ensures single execution
• trial_command.go uses the shared function
• All existing repository access functionality works correctly
• Tests verify caching behavior (single execution on multiple calls)
• No performance regressions
• make test-unit passes
  Related to [refactor] 🔧 Semantic Function Clustering Analysis: Code Duplication and Organization Findings #2511

AI generated by Plan Command for #2511</issue_description>

Comments on the Issue (you are @copilot in this section)

@pelikhan create 'workflow_name.go' file I workflow pkg.

• Fixes[task] Standardize repository access with cached implementation #2513

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[pelikhan]

@copilot move reposlug logic to repo.go file

[Copilot]

Done. Moved repository slug logic to pkg/cli/repo.go in commit 40cc026. All repository-related functions (GetCurrentRepoSlug, GetCurrentRepoSlugCached, ClearCurrentRepoSlugCache) and their tests are now in dedicated files (repo.go and repo_test.go).

[pelikhan]

@copilot not export, change name to ...Uncached

[Copilot]

Done in commit ac43adf. Renamed GetCurrentRepoSlug to getCurrentRepoSlugUncached and made it unexported.

[pelikhan]

@copilot remove "Cached" from name so it is the default option.

[Copilot]

Done in commit ac43adf. Renamed GetCurrentRepoSlugCached to GetCurrentRepoSlug so the cached version is now the default.

[Copilot]

Pull Request Overview

This PR consolidates three different repository access implementations into a single cached function, improving performance and maintainability. The standardization creates a dedicated repo.go file for repository logic with a fallback mechanism (gh CLI → git remote), while also extracting workflow name sanitization utilities into a separate workflow_name.go file for better code organization.

Key Changes:

• Created pkg/cli/repo.go with cached repository access using sync.Once pattern
• Migrated trial_command.go from git-based to cached gh CLI-based repository access
• Extracted workflow name utilities (SanitizeWorkflowName, ConvertToIdentifier) into dedicated pkg/workflow/workflow_name.go file

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/cli/repo.go	New centralized repository access with caching and fallback logic
pkg/cli/repo_test.go	Comprehensive tests for cached repository access behavior
pkg/cli/trial_command.go	Simplified to use cached repository function
pkg/cli/shared_utils.go	Removed duplicate repository logic
pkg/workflow/workflow_name.go	New file with extracted workflow name utilities
pkg/workflow/copilot_engine.go	Updated to use exported SanitizeWorkflowName
pkg/workflow/codex_engine.go	Removed duplicate code, uses exported ConvertToIdentifier
pkg/cli/spec_test.go	Added cache clearing for clean test state
pkg/cli/local_workflow_trial_test.go	Added cache clearing for clean test state
docs/src/content/docs/reference/frontmatter-full.md	Added documentation for log-level configuration

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pelikhan]

/mergefest

[github-actions]

Agentic Mergefest triggered by this issue comment.

[pelikhan]

@copilot merge

[pelikhan]

@copilot merge main

[Copilot]

@copilot merge main

I cannot perform git merge operations directly. To merge the main branch into this PR branch, you'll need to run:

git fetch origin
git merge origin/main

Or use the GitHub UI to update the branch if there are conflicts that need resolution.

[github-actions]

Agentic Mergefest triggered by this issue comment.

[pelikhan]

/mergefest

[github-actions]

Agentic Mergefest triggered by this issue comment.

[pelikhan]

/mergefest

[github-actions]

Agentic Mergefest triggered by this issue comment.

[pelikhan]

/mergefest

[github-actions]

Agentic Mergefest triggered by this issue comment.

[pelikhan]

@copilot fix tests

[Copilot]

@copilot fix tests

Fixed in commit bae55f8. Removed duplicate SanitizeWorkflowName function from workflow_name.go that was conflicting with the version in strings.go (added during merge from main). All tests now pass.

[pelikhan]

/mergefest

[github-actions]

✅ Agentic Mergefest completed successfully.

[pelikhan]

@copilot this is misleading, review name escaping function and look for simplifications

[Copilot]

Improved in commit 4f81e53. Enhanced the function documentation to clearly explain:

• Purpose: converts workflow names to valid identifiers (for user agent strings, etc.)
• Behavior: lowercase, replaces spaces/underscores with hyphens, removes non-alphanumeric chars (except hyphens)
• Default: returns "github-agentic-workflow" if result would be empty
• Improved inline comments for better clarity

The function is now well-documented and the default value behavior is clear.

[pelikhan]

@copilot the name of the function is misleading, fix this

[Copilot]

Fixed in commit 4e98909. Renamed ConvertToIdentifier to SanitizeIdentifier which better describes the function's purpose - it sanitizes workflow names to create safe identifiers for use in contexts like user agent strings.