Generate update_reaction job for command workflows with reactions

[Copilot]

Command workflows automatically enable the "eyes" reaction and create an activation comment, but update_reaction job was only generated when add-comment was configured in safe-outputs, leaving the activation comment unupdated on workflow completion.

Changes

Modified buildUpdateReactionJob() to generate job when:

• add-comment is configured with a reaction (existing), OR
• command is configured with a reaction (new)

Updated buildSafeOutputsJobs() to:

• Always attempt job creation, delegating decision to buildUpdateReactionJob()
• Remove conditional guard that required add-comment configuration

Impact

Command workflows (mergefest, plan, tidy) now update activation comments with completion status (✅ success, ❌ failure, 🚫 cancelled, etc.) regardless of add-comment configuration.

# This now generates update_reaction jobon:
command:
name: mergefestsafe-outputs:
push-to-pull-request-branch: # No add-comment needed

Original prompt

Analyze mergefest.md . Since it is using command, the lock file should have the update_reaction job added but it does not seem to have it. Review the logic the enable the update_reaction job such that if (1) command is a trigger and reaction is enabled, it is generated.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull Request Overview

This PR fixes a bug where command workflows (mergefest, plan, tidy) were not updating their activation comments upon completion, despite reactions being enabled. The issue stemmed from the update_reaction job only being generated when add-comment was configured, whereas command workflows create activation comments automatically but may not have add-comment configured.

Key changes:

• Modified job generation logic to create update_reaction job when either add-comment OR command is configured with reactions
• Removed restrictive conditional guard in buildSafeOutputsJobs() that prevented job creation for command-only workflows
• Added comprehensive test coverage for command workflow scenarios

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/workflow/notify_comment.go	Updated logic to generate update_reaction job for both add-comment and command triggers with reactions
pkg/workflow/compiler_jobs.go	Removed conditional guard preventing update_reaction job creation for command workflows
pkg/workflow/notify_comment_test.go	Added test cases for command workflow scenarios with and without reactions
.github/workflows/tidy.lock.yml	Generated update_reaction job for tidy command workflow
.github/workflows/plan.lock.yml	Generated update_reaction job for plan command workflow
.github/workflows/mergefest.lock.yml	Generated update_reaction job for mergefest command workflow

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Agentic Changeset Generator triggered by this pull request.