[jsweep] Clean remove_trigger_label.cjs by github-actions[bot] · Pull Request #29251 · github/gh-aw

github-actions · 2026-04-30T04:55:11Z

Summary

Cleans remove_trigger_label.cjs and adds a comprehensive test suite.

Context

Execution context: github-script (uses core, github, context globals)

Changes

Code cleanup:

Moved require('./error_helpers.cjs') from inside main() to top-level imports — consistent with all other files in the codebase

Tests added (14 tests):
New file remove_trigger_label.test.cjs covers:

Missing / invalid GH_AW_LABEL_NAMES env var (3 cases)
workflow_dispatch event → skip with empty output
No label in payload → skip
Label not in configured list → skip, preserve label output
issues event: happy path + missing issue number
pull_request event: happy path + missing PR number
discussion event: happy path via GraphQL + missing node IDs
404 error is non-fatal (label already removed by another run)
Non-404 API errors produce a warning (not a failure)

Validation ✅

Formatting: npm run format:cjs ✓
Linting: npm run lint:cjs ✓
Type checking: npm run typecheck ✓
Tests: 14/14 passed ✓

Generated by jsweep - JavaScript Unbloater · ● 1.7M · ◷
expires on May 2, 2026, 4:55 AM UTC

- Move require('./error_helpers.cjs') from inside main() to top-level imports - Add comprehensive test suite (14 tests) covering all code paths: - Missing/invalid GH_AW_LABEL_NAMES config - workflow_dispatch skip - No label in payload - Label not in configured list - issues, pull_request, discussion label removal - 404 non-fatal error handling - Non-404 API error warnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Cleans up the remove_trigger_label.cjs GitHub Action script and adds a comprehensive Vitest suite to validate behavior across supported events and error conditions.

Changes:

Moved getErrorMessage import to top-level in remove_trigger_label.cjs for consistency.
Added remove_trigger_label.test.cjs with coverage for config parsing, event-specific behavior, skip paths, and API error handling.

Show a summary per file

File	Description
actions/setup/js/remove_trigger_label.cjs	Hoists `error_helpers.cjs` import to module scope to align with codebase patterns.
actions/setup/js/remove_trigger_label.test.cjs	Adds a full test suite exercising label removal behavior across events and error cases.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 1

Copilot · 2026-04-30T05:07:01Z

@@ -0,0 +1,220 @@
+// @ts-check
+import { describe, it, expect, beforeEach, vi } from "vitest";


afterEach is used later in this test file but isn’t imported from vitest. The rest of the test suite consistently imports the hooks it uses (e.g. actions/setup/js/action_conclusion_otlp.test.cjs:2). Please add afterEach to the Vitest import list for consistency and to avoid relying on global hook injection.
Suggested change
import{describe,it,expect,beforeEach,vi}from"vitest";
import{describe,it,expect,beforeEach,afterEach,vi}from"vitest";

pelikhan · 2026-04-30T05:08:07Z

@copilot review all comments

github-actions · 2026-04-30T05:08:11Z

🧪 Test Quality Sentinel Report

Test Quality Score: 80/100

✅ Excellent test quality

Metric	Value
New/modified tests analyzed	14
✅ Design tests (behavioral contracts)	14 (100%)
⚠️ Implementation tests (low value)	0 (0%)
Tests with error/edge cases	14 (100%)
Duplicate test clusters	0
Test inflation detected	⚠️ Yes (220 test lines vs 1 production line — new test for existing code)
🚨 Coding-guideline violations	None

Test Classification Details

View all 14 test classifications

Test	File	Classification	Notes
`should fail when GH_AW_LABEL_NAMES is not set`	`remove_trigger_label.test.cjs:68`	✅ Design	Error path — config validation
`should fail when GH_AW_LABEL_NAMES is invalid JSON`	`remove_trigger_label.test.cjs:74`	✅ Design	Error path — malformed config
`should fail when GH_AW_LABEL_NAMES is not an array`	`remove_trigger_label.test.cjs:80`	✅ Design	Error path — wrong config type
`should skip label removal for workflow_dispatch`	`remove_trigger_label.test.cjs:88`	✅ Design	Behavioral contract — event gating
`should skip removal when payload has no label`	`remove_trigger_label.test.cjs:97`	✅ Design	Edge case — missing payload
`should skip removal when label is not configured`	`remove_trigger_label.test.cjs:106`	✅ Design	Behavioral contract — allow-list check
`should remove label from issue`	`remove_trigger_label.test.cjs:118`	✅ Design	Happy path with parameter assertions
`should skip when issue number is missing`	`remove_trigger_label.test.cjs:129`	✅ Design	Edge case — defensive guard
`should remove label from pull request`	`remove_trigger_label.test.cjs:141`	✅ Design	Behavioral contract — PR event path
`should skip when PR number is missing`	`remove_trigger_label.test.cjs:160`	✅ Design	Edge case — defensive guard
`should remove label from discussion via graphql`	`remove_trigger_label.test.cjs:172`	✅ Design	Behavioral contract — GraphQL mutation
`should skip when discussion node_id is missing`	`remove_trigger_label.test.cjs:192`	✅ Design	Edge case — defensive guard
`should treat 404 error as already-removed (non-fatal)`	`remove_trigger_label.test.cjs:204`	✅ Design	Error path — idempotency invariant
`should warn on non-404 API errors`	`remove_trigger_label.test.cjs:212`	✅ Design	Error path — non-fatal API failure

Mocking Strategy Assessment

All mocked targets are GitHub Actions runtime globals (global.core, global.github, global.context). These are legitimate external I/O mocks — no internal business-logic functions are mocked. The approach is consistent with the pattern used by other test files in actions/setup/js/.

Test Inflation Note

The raw inflation ratio (220 test lines : 1 production line added) exceeds the 2:1 threshold, triggering the standard 10-point penalty. However, this is context-appropriate: the test file is newly added to cover an already-existing production file (remove_trigger_label.cjs, 138 lines). The single production-file change was a cleanup (-2 lines, +1 line). The test coverage itself is proportional to the production code being tested, not inflated.

Language Support

Tests analyzed:

🟨 JavaScript (*.test.cjs): 14 tests (vitest)

Verdict

✅ Check passed. 0% of new tests are implementation tests (threshold: 30%). All 14 tests verify observable behavioral contracts. The test suite covers all three event types (issues, pull_request, discussion), all configuration error cases, all defensive guards, and the critical 404-idempotency invariant.

📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

Assert on observable outputs, return values, or state changes
Cover error paths and boundary conditions
Would catch a behavioral regression if deleted
Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

Assert on internal function calls (mocking internals)
Only test the happy path with typical inputs
Break during legitimate refactoring even when behavior is correct
Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References:

§25148333415

🧪 Test quality analysis by Test Quality Sentinel · ● 450.9K · ◷

github-actions

✅ Test Quality Sentinel: 80/100. Test quality is excellent — 0% of new tests are implementation tests (threshold: 30%). All 14 tests verify observable behavioral contracts across all event types and error paths.

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b453b824-12cd-44a5-a0de-5a6946b25d66 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-04-30T05:13:25Z

@copilot review all comments

Added afterEach to the Vitest import list in remove_trigger_label.test.cjs (11cff5b). All 14 tests still pass.

github-actionsBot added automation unbloat labels Apr 30, 2026

pelikhan marked this pull request as ready for review April 30, 2026 05:02

CopilotAI review requested due to automatic review settings April 30, 2026 05:02

Copilotstarted reviewing on behalf of pelikhan April 30, 2026 05:03 View session

github-actionsBot mentioned this pull request Apr 30, 2026
[aw] No-Op Runs #29134
Closed

CopilotAI reviewed Apr 30, 2026
View reviewed changes

github-actionsBot commented Apr 30, 2026
View reviewed changes

Copilotstarted work on behalf of pelikhan April 30, 2026 05:08 View session

fix: add afterEach to vitest imports in remove_trigger_label.test.cjs
11cff5b
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b453b824-12cd-44a5-a0de-5a6946b25d66 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilotfinished work on behalf of pelikhan April 30, 2026 05:14

CopilotAI requested a review from pelikhan April 30, 2026 05:14

pelikhan merged commit a5a0353 into mainApr 30, 2026

pelikhan deleted the jsweep/remove-trigger-label-68596c098464d9d3 branch April 30, 2026 05:15

This was referenced Apr 30, 2026
Smoke Test: Codex - 25148772806 #29258
Closed
feat: compiler emits AWF JSON config file instead of CLI flag soup #29222
Merged
Smoke Test: Codex - 25149789889 #29266
Closed
fix(gemini): add --gemini-api-target routing fix and accept ADR-26060 #29254
Closed

Navigation Menu

Uh oh!

[jsweep] Clean remove_trigger_label.cjs - #29251

[jsweep] Clean remove_trigger_label.cjs#29251
pelikhan merged 2 commits into
mainfrom
jsweep/remove-trigger-label-68596c098464d9d3

github-actionsBot commented Apr 30, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

CopilotAIApr 30, 2026

Uh oh!

pelikhan commented Apr 30, 2026

Uh oh!

github-actionsBot commented Apr 30, 2026

Uh oh!

github-actionsBot left a comment

Uh oh!

CopilotAI commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,220 @@
		// @ts-check
		import { describe, it, expect, beforeEach, vi } from "vitest";

	import{describe,it,expect,beforeEach,vi}from"vitest";
	import{describe,it,expect,beforeEach,afterEach,vi}from"vitest";

Uh oh!

Conversation

github-actionsBot commented Apr 30, 2026

Summary

Context

Changes

Validation ✅

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

CopilotAIApr 30, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Apr 30, 2026

Uh oh!

github-actionsBot commented Apr 30, 2026

🧪 Test Quality Sentinel Report

Test Quality Score: 80/100

Test Classification Details

Mocking Strategy Assessment

Test Inflation Note

Language Support

Verdict

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants