Uh oh!
There was an error while loading. Please reload this page.
[jsweep] Clean add_reaction_and_edit_comment.cjs - #29439
Merged
pelikhan merged 1 commit intoMay 1, 2026
Merged
Conversation
- Replace string concatenation with template literals for POST endpoint calls - Simplify addReaction output: collapse if/else into single-line optional chaining - Use template literal for warning message Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up add_reaction_and_edit_comment.cjs as part of the jsweep initiative by modernizing string construction and simplifying reaction output handling without changing behavior.
Changes:
- Switched REST
github.requestcalls from string concatenation to template literals. - Simplified
addReactionlogging/output logic using optional chaining and nullish coalescing. - Converted a
core.warningmessage to a template literal.
Show a summary per file
| File | Description |
|---|---|
| actions/setup/js/add_reaction_and_edit_comment.cjs | Refactors request strings and reaction output/log formatting for readability/consistency. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Closed
Uh oh!
There was an error while loading. Please reload this page.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleaned
add_reaction_and_edit_comment.cjsas part of the jsweep initiative.Context type: github-script
Changes
"POST " + endpoint) with template literals (````POST ${endpoint}`````) in two placesaddReactionoutput: collapsed verbose if/else block into a single-line using optional chaining (reactionId?.toString() ?? "") and a ternary for the log messagecore.warningmessage at the end ofaddCommentWithWorkflowLinkTest Coverage
The existing test file (
add_reaction_and_edit_comment.test.cjs) has comprehensive coverage with 33 tests covering all event types and edge cases. All 33 tests pass with these changes.Validation
npm run format:cjspassednpm run lint:cjspassednpm run typecheckpassed (no errors)