Uh oh!
There was an error while loading. Please reload this page.
Add emoji field support to aw.yml package manifests - #32648
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
emoji field support to aw.yml package manifestsThere was a problem hiding this comment.
Pull request overview
Adds optional emoji support to aw.yml package manifests.
Changes:
- Allows
emojias a top-level string field in the manifest schema. - Parses and carries
emojithrough repository package resolution. - Updates tests and two manifest reference docs with emoji examples.
Show a summary per file
| File | Description |
|---|---|
pkg/parser/schemas/aw_manifest_schema.json | Adds emoji to allowed manifest properties. |
pkg/cli/add_package_manifest.go | Parses emoji into manifest and resolved package structs. |
pkg/cli/add_package_manifest_test.go | Adds coverage for accepted and rejected emoji values. |
docs/src/content/docs/reference/repository-package-manifest-specification.md | Documents emoji in the normative manifest spec. |
docs/src/content/docs/reference/aw-yml-package-manifest.md | Documents emoji in the user-facing manifest reference. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 1
| | `manifest-version` | string | No | Current supported value: `"1"`. Defaults to `"1"` when omitted. | | ||
| | `min-version` | string | No | Minimum compatible `gh aw` version in `vMAJOR.minor.patch` form, such as `v0.38.0`. | | ||
| | `name` | string | Yes | Human-readable package name. Must be non-empty after trimming whitespace. | | ||
| | `emoji` | string | No | Optional package emoji for display in package metadata. | |
Please address the unresolved review feedback on this PR, then re-request review. If helpful, refresh the branch and rerun checks after the fix. Run: https://github.com/github/gh-aw/actions/runs/25965903247
|
pelikhan
commented
May 16, 2026
@copilot review all comments |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed the outstanding review feedback by updating |
aw.ymlpackage manifests can now declare an optionalemojifield as part of package metadata. This extends the manifest contract without changing existing required fields or install-resolution behavior.Manifest schema
emojias an allowed top-level string field inpkg/parser/schemas/aw_manifest_schema.json.Manifest parsing/model updates
repositoryPackageManifestandresolvedRepositoryPackageto carryEmoji.emojifrom manifest content inparseRepositoryPackageManifestwhen present.Behavioral coverage
emojivalues are rejected by schema validation.Spec and reference docs
emojiin the field tables and YAML examples:docs/src/content/docs/reference/aw-yml-package-manifest.mddocs/src/content/docs/reference/repository-package-manifest-specification.md