Uh oh!
There was an error while loading. Please reload this page.
[architecture] Update architecture diagram - 2026-05-18 - #33006
Merged
Conversation
…errorutil Add three packages that were missing from the previous diagram: - cmd/linters: custom linter binary entry point - pkg/linters: namespace for custom Go analysis linters - pkg/errorutil: GitHub API error classification utilities Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 18, 2026
pelikhan
approved these changes
May 18, 2026
pelikhan
marked this pull request as ready for review
May 18, 2026 12:44
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the generated architecture diagram to reflect recently added/recognized packages and refreshes the “last updated” metadata.
Changes:
- Add
cmd/lintersas a third entry point in the diagram and package reference table. - Add
pkg/linters(namespace + subpackages) andpkg/errorutilto the diagram and package reference table. - Update the “Last updated” date and workflow run source link.
Show a summary per file
| File | Description |
|---|---|
scratchpad/architecture.md | Updates the architecture diagram and package reference table to include missing entry points/utilities and refreshes metadata. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
scratchpad/architecture.md:98
- In the package reference table,
pkg/errorutilis described as "GitHub API error classification helpers", but the package docs cover both GitHub API andghCLI errors. Consider reflecting both sources here for consistency withpkg/errorutil’s README and package comment.
| `pkg/errorutil` | Utility | GitHub API error classification helpers |
- Files reviewed: 1/1 changed files
- Comments generated: 2
Comment on lines
+14
to
+18
| │ │ cmd/gh-aw │ │cmd/gh-aw-wasm │ │ cmd/linters│ │ | ||
| │ │ Main CLI binary │ │ WebAssembly build target │ │ Custom linter binary│ │ | ||
| │ └──────────┬────────────┘ └────────────┬───────────────┘ └────────────┬─────────────────┘ │ | ||
| │ │ cli,workflow, │ │ pkg/linters/* │ | ||
| │ │ parser,console,constants ││ │ |
Comment on lines
+67
to
+68
| │ │ pkg/errorutil │ │ pkg/testutil (test builds only)│ │ | ||
| │ │ GitHub API error classification │ │ Test helper utilities│ │ |
Closed
ContributorAuthor
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — this is a documentation update adding three previously-missing packages to the architecture diagram.
What was reviewed
Verified each new entry against the actual codebase:
- ✅
cmd/linters— exists atcmd/linters/ - ✅
pkg/linters— exists atpkg/linters/with all five subpackages (ctxbackground,excessivefuncparams,largefunc,osexitinlibrary,rawloginlib) correctly listed - ✅
pkg/errorutil— exists atpkg/errorutil/
Positive Highlights
- ✅ Diagram layout correctly places
cmd/lintersalongside the other entry points - ✅ Package reference table uses consistent terminology and column format
- ✅
pkg/linterssubpackages are named accurately - ✅
pkg/errorutilis correctly categorised as Utility (not Core)
Verdict
All additions are accurate and consistent with the existing domain vocabulary. No issues found.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 3.7M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three packages that were missing from the previous architecture diagram (2026-05-11):
cmd/linters— custom linter binary entry pointpkg/linters— namespace for custom Go analysis linters (ctxbackground, excessivefuncparams, largefunc, osexitinlibrary, rawloginlib)pkg/errorutil— GitHub API/gh CLI error classification utilitiesUpdates
scratchpad/architecture.mdwith the corrected diagram and package reference table.Source: §26026605299