Harden PR Sous Chef and Contribution Check prompts to require explicit add_comment targets

[Copilot]

safe_outputs was deterministically failing in scheduled runs because agents emitted add_comment items without a numeric target while both workflows use add-comment.target: "*". That caused post-step validation to fail even when agent execution otherwise succeeded.

• Prompt contract: PR Sous Chef

  • Updated .github/workflows/pr-sous-chef.md to require pr_number on every add_comment.
  • Added an explicit prohibition against emitting targetless add_comment items when target: "*" is configured.
  • Added a concrete JSON example using the loop PR number.

• Prompt contract: Contribution Check

  • Updated .github/workflows/contribution-check.md to require copying issue_number verbatim from comment-dispatcher payloads into add_comment.
  • Added an explicit “never emit without numeric target” rule and concrete example.

• Regression guardrails

  • Extended pkg/cli/contribution_check_workflow_contract_test.go to assert numeric-target requirements remain in the workflow prompt.
  • Added pkg/cli/pr_sous_chef_workflow_contract_test.go to enforce the same contract for PR Sous Chef.

{"type":"add_comment","pr_number":12345,"body":"<!-- gh-aw-pr-sous-chef-nudge -->\n@copilot review all comments and address unresolved review feedback."}
{"type":"add_comment","issue_number":35304,"body":"Thanks for the PR — here are the next changes to make..."}

[Copilot]

Pull request overview

Hardens two workflow prompts to require explicit numeric targets on add_comment safe outputs, preventing validation failures under add-comment.target: "*". Adds regression tests asserting the new prompt contract is preserved.

Changes:

• Update pr-sous-chef.md to require pr_number on every add_comment and add a concrete example.
• Update contribution-check.md to require copying issue_number verbatim and add a concrete example.
• Add/extend Go contract tests to enforce the new prompt language stays in place.

Show a summary per file

File	Description
.github/workflows/pr-sous-chef.md	Adds explicit pr_number requirement, prohibition, and JSON example.
.github/workflows/contribution-check.md	Adds verbatim issue_number requirement and JSON example.
pkg/cli/contribution_check_workflow_contract_test.go	Asserts new prompt strings are present.
pkg/cli/pr_sous_chef_workflow_contract_test.go	New contract test for PR Sous Chef prompt.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 4/4 changed files
• Comments generated: 0