Uh oh!
There was an error while loading. Please reload this page.
Closed
fix(safeoutputs): generalize submit_pull_request_review identifier prohibition#36544
Conversation
6 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…o all identifier fields Lead with the prohibition and list all forbidden targeting parameters (pull_request_number, item_number, pr_number, issue_number). Explicitly contrast with sibling tools that DO accept pull_request_number. Retain all existing REQUIRED-body and inline-comment guidance. Propagate identical description to actions/setup/js/safe_outputs_tools.json so TestSafeOutputsToolsJSONInSync continues to pass. Fixes #36001 (or whatever the issue number is) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix insufficient warning for pull request reviewfix(safeoutputs): generalize submit_pull_request_review identifier prohibitionJun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents continued passing stray PR-targeting fields to
submit_pull_request_reviewafter the previous fix (#35579) because the warning named onlypull_request_number— agents routed around it toitem_numberand other aliases instead.Changes
pkg/workflow/js/safe_outputs_tools.json+actions/setup/js/safe_outputs_tools.json: Rewrites thesubmit_pull_request_reviewdescription to:pull_request_number,item_number,pr_number,issue_numbercreate_pull_request_review_commentandreply_to_pull_request_review_commentdo acceptpull_request_number— directly addressing the parity assumption that drives the mistakebody/eventrequirements and inline-comment guidanceBefore:
After:
Both copies are updated in the same commit so
TestSafeOutputsToolsJSONInSynccontinues to pass.