Remove legacy effective-token limits and ET surfacing; keep migration codemods

[Copilot]

This change removes max-effective-tokens / max-daily-effective-tokens from the Go compiler and CLI behavior, including legacy ET budget propagation and ET display paths. The only retained legacy behavior is codemod migration from effective-token fields to AI-credit fields.

• Compiler budget handling

  • Drops EngineConfig.MaxEffectiveTokens and all parse/merge/default wiring for max-effective-tokens.
  • Removes AWF config emission of apiProxy.maxEffectiveTokens; max-ai-credits remains the budget control.
  • Simplifies token-steering disable logic to max-ai-credits semantics.

• Schema + import processing

  • Removes top-level schema properties for max-effective-tokens and max-daily-effective-tokens.
  • Removes import accumulator/result fields and first-wins extraction for imported max-effective-tokens.

• CLI surface cleanup

  • Removes effective-token computation/display from token-usage aggregation paths (keeps AI credits aggregation).
  • Removes default_max_effective_tokens from env defaults file bindings and validation.

• Tests updated to new contract

  • Removes/rewrites tests that asserted acceptance/propagation of legacy effective-token limit fields.
  • Aligns token-usage expectations to ET-disabled behavior while preserving AIC-focused assertions.

• Exception explicitly preserved (codemods)

  • Keeps codemods that rewrite legacy frontmatter keys to AI-credit equivalents.

# beforemax-effective-tokens: 5Mmax-daily-effective-tokens: 10k# after (via codemod)max-ai-credits: 500max-daily-ai-credits: 1

[Copilot]

Pull request overview

This PR removes legacy effective-token (ET) budget limits and ET-related budget propagation/surfacing across the compiler, schema/import processing, and CLI token-usage reporting—while keeping codemods that migrate legacy frontmatter keys to AI-credits equivalents.

Changes:

• Removes max-effective-tokens / max-daily-effective-tokens support from engine config extraction, import merging, schema validation, and AWF config emission.
• Simplifies token-steering enable/disable behavior to max-ai-credits semantics only, and updates tests accordingly.
• Updates CLI token usage aggregation/tests to stop computing ET-derived metrics and deltas, focusing on AIC.

Show a summary per file

File	Description
pkg/workflow/threat_detection.go	Removes ET budget propagation from detection engine execution step construction.
pkg/workflow/importable_tools_test.go	Updates import tests to stop asserting ET limit import/lock emission.
pkg/workflow/engine.go	Drops EngineConfig.MaxEffectiveTokens and stops extracting it from frontmatter.
pkg/workflow/engine_config_test.go	Removes ET-focused engine config extraction test cases/assertions.
pkg/workflow/engine_config_parser.go	Removes ET parsing helper; leaves AIC parsing as the remaining budget parser.
pkg/workflow/compilerenv/manager.go	Removes enterprise default env var and resolver for ET budgets.
pkg/workflow/compilerenv/manager_test.go	Removes tests for ET enterprise default resolver.
pkg/workflow/compiler_orchestrator_engine.go	Removes preserved/import-default handling for ET budgets during engine/import setup.
pkg/workflow/compiler_orchestrator_engine_test.go	Removes tests ensuring negative ET preservation through import expansion.
pkg/workflow/awf_config.go	Removes AWF apiProxy.maxEffectiveTokens emission and ET-based steering disable logic.
pkg/workflow/awf_config_test.go	Removes tests that assert AWF config ET emission and ET-negative steering behavior.
pkg/parser/schemas/main_workflow_schema.json	Removes max-effective-tokens and max-daily-effective-tokens from the main schema.
pkg/parser/schema_test.go	Removes schema validation tests for ET fields and updates max-limits validation messages.
pkg/parser/schema_deprecated_test.go	Stops expecting ET fields in deprecated-field discovery output.
pkg/parser/import_processor.go	Removes ET merged-field output from ImportsResult.
pkg/parser/import_field_extractor.go	Removes ET first-wins extraction/accumulation during import traversal.
pkg/parser/import_field_extractor_test.go	Updates extractor tests to stop asserting merged ET values.
pkg/constants/constants.go	Removes default ET budget constant.
pkg/cli/token_usage.go	Disables ET computation/deltas and shifts JSON/console surfacing toward AIC-only reporting.
pkg/cli/token_usage_test.go	Updates token-usage tests to expect ET fields to remain unset/zeroed.
pkg/cli/env_command.go	Removes defaults-file binding/validation for ET enterprise default.
pkg/cli/env_command_test.go	Updates env defaults tests to exclude ET default key and reworks update-change assertions.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

pkg/workflow/engine_config_parser.go:25

• parseMaxAICreditsValue currently delegates to parseMaxEffectiveTokenLimitValue, which carries max-effective-tokens naming/logging semantics. Now that effective-token limits are removed, this coupling is confusing and can produce misleading log lines (e.g. "Parsed max-effective-tokens sentinel"). Consider parsing max-ai-credits directly here.

// parseMaxAICreditsValue parses max-ai-credits from either integer
// or numeric-string frontmatter values.
//
// A return value of 0 is a sentinel that means "not configured" (missing or
// invalid); explicit zero is not a valid user value. Negative values (-1) are
// passed through as-is and signal that budget enforcement and token steering
// should be disabled.
func parseMaxAICreditsValue(raw any) int64 {
if parsed, ok := parseMaxEffectiveTokenLimitValue(raw); ok {
return parsed
}
if raw != nil {
engineLog.Printf("Ignoring invalid max-ai-credits value of type %T: %v", raw, raw)
}
return 0

• Files reviewed: 22/22 changed files
• Comments generated: 4

[pelikhan]

@copilot review all comments and review comments