Skip to content

Replace effective_tokens_rate_limit_error with ai_credits_rate_limit_error across workflow outputs - #37691

Merged
pelikhan merged 2 commits into
mainfrom
copilot/remove-effective-tokens-rate-limit-error
Jun 8, 2026
Merged

Replace effective_tokens_rate_limit_error with ai_credits_rate_limit_error across workflow outputs#37691
pelikhan merged 2 commits into
mainfrom
copilot/remove-effective-tokens-rate-limit-error

Conversation

CopilotAI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This change removes the legacy effective_tokens_rate_limit_error signal and standardizes rate-limit reporting on ai_credits_rate_limit_error. The update aligns parser output, compiled workflow outputs, and failure-context rendering to a single AI-credits-based field.

  • Output contract update

    • actions/setup/js/parse_mcp_gateway_log.cjs now emits only ai_credits_rate_limit_error for rate-limit detection.
    • Legacy alias emission for effective_tokens_rate_limit_error is removed.
  • Compiler and runtime wiring

    • pkg/workflow/compiler_main_job.go exports ai_credits_rate_limit_error from parse-mcp-gateway step outputs.
    • pkg/workflow/notify_comment.go passes GH_AW_AI_CREDITS_RATE_LIMIT_ERROR (instead of the effective-tokens variant) to failure handling.
  • Failure message context cleanup

    • Removed effective_tokens_rate_limit_error_context placeholder usage from:
      • actions/setup/md/agent_failure_comment.md
      • actions/setup/md/agent_failure_issue.md
    • Kept ai_credits_rate_limit_error_context as the single rate-limit context source.
    • Updated related template test fixtures accordingly.
  • Generated artifacts alignment

    • Recompiled lock workflows and updated golden fixtures so generated YAML references ai_credits_rate_limit_error consistently.
# beforeeffective_tokens_rate_limit_error: ${{ steps.parse-mcp-gateway.outputs.effective_tokens_rate_limit_error || 'false' }}# afterai_credits_rate_limit_error: ${{ steps.parse-mcp-gateway.outputs.ai_credits_rate_limit_error || 'false' }}

CopilotAIand others added 2 commits June 8, 2026 00:49
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title Replace effective_tokens_rate_limit_error with ai_credits_rate_limit_errorReplace effective_tokens_rate_limit_error with ai_credits_rate_limit_error across workflow outputsJun 8, 2026
CopilotAI requested a review from pelikhanJune 8, 2026 00:56
@pelikhan
pelikhan marked this pull request as ready for review June 8, 2026 00:56
CopilotAI review requested due to automatic review settings June 8, 2026 00:56
@pelikhan
pelikhan merged commit ef380bf into mainJun 8, 2026
@pelikhan
pelikhan deleted the copilot/remove-effective-tokens-rate-limit-error branch June 8, 2026 00:56

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the legacy effective_tokens_rate_limit_error signal and standardizes rate-limit reporting on the single ai_credits_rate_limit_error field across parser output, compiled workflow outputs, and failure-context rendering.

Changes:

  • Updated parse_mcp_gateway_log.cjs to emit only ai_credits_rate_limit_error (removed legacy alias output).
  • Rewired workflow compilation/runtime to export and pass through ai_credits_rate_limit_error (including GH_AW_AI_CREDITS_RATE_LIMIT_ERROR in failure handling).
  • Updated failure message templates and golden/lock fixtures so generated YAML consistently references ai_credits_rate_limit_error.
Show a summary per file
FileDescription
actions/setup/js/parse_mcp_gateway_log.cjsStops emitting the legacy effective_tokens_rate_limit_error output; emits only ai_credits_rate_limit_error.
pkg/workflow/compiler_main_job.goUpdates compiled main-job outputs to export ai_credits_rate_limit_error instead of the legacy field.
pkg/workflow/notify_comment.goSwitches failure-handling env wiring to GH_AW_AI_CREDITS_RATE_LIMIT_ERROR.
actions/setup/md/agent_failure_comment.mdRemoves effective_tokens_rate_limit_error_context placeholder usage; relies on AI-credits context only.
actions/setup/md/agent_failure_issue.mdRemoves effective_tokens_rate_limit_error_context placeholder usage; relies on AI-credits context only.
actions/setup/js/handle_agent_failure.test.cjsUpdates fixture/template data expectations by removing the legacy rate-limit context field.
pkg/workflow/testdata/wasm_golden/WasmBinary/basic-copilot.goldenUpdates golden workflow output name to ai_credits_rate_limit_error.
pkg/workflow/testdata/wasm_golden/WasmBinary/playwright-cli-mode.goldenUpdates golden workflow output name to ai_credits_rate_limit_error.
pkg/workflow/testdata/wasm_golden/WasmBinary/smoke-copilot.goldenUpdates golden workflow output name to ai_credits_rate_limit_error.
pkg/workflow/testdata/wasm_golden/WasmBinary/with-imports.goldenUpdates golden workflow output name to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.goldenUpdates compile-fixture golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/playwright-cli-mode.goldenUpdates compile-fixture golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.goldenUpdates compile-fixture golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.goldenUpdates compile-fixture golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_AllEngines/claude.goldenUpdates all-engines golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_AllEngines/codex.goldenUpdates all-engines golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_AllEngines/copilot.goldenUpdates all-engines golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_AllEngines/gemini.goldenUpdates all-engines golden outputs to ai_credits_rate_limit_error.
pkg/workflow/testdata/TestWasmGolden_AllEngines/pi.goldenUpdates all-engines golden outputs to ai_credits_rate_limit_error.
.github/workflows/*.lock.ymlRecompiled generated lock workflows to reference ai_credits_rate_limit_error consistently (including passing GH_AW_AI_CREDITS_RATE_LIMIT_ERROR).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 264/264 changed files
  • Comments generated: 0

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pelikhan