Uh oh!
There was an error while loading. Please reload this page.
Fix CI: add missing v0.3.24 MCPG pin and Windows test compatibility - #37887
Conversation
- Add ghcr.io/github/gh-aw-mcpg:v0.3.24 to embedded container pins to fix TestGetContainerPin_DefaultMCPImagesArePinned after the constant bump in #37708. - Make Windows integration tests pass: - Use 'failed to read file' (engine-agnostic) instead of POSIX-specific 'no such file' substring in compilation_with_nonexistent_file. - Use an OS-appropriate absolute path (C:\absolute\path on Windows) in TestCompileWorkflows_WorkflowDirValidation/absolute_path_not_allowed. - Skip TestCompileWithIncludeWithEmptyFrontmatterUnderPty on Windows where the underlying PTY library is unsupported. - Build the throwaway version-test binary inside t.TempDir() with the correct .exe suffix on Windows so it can actually be exec'd.
pelikhan
commented
Jun 8, 2026
Landon is bringing #37885 |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Fixes CI failures by completing the embedded MCP gateway (MCPG) container pin set and making several integration tests OS-aware so they behave consistently on Windows runners.
Changes:
- Add the missing
ghcr.io/github/gh-aw-mcpg:v0.3.24container pin (digest + pinned reference) to the embedded action pins dataset. - Adjust Windows integration tests for platform-specific behavior (PTY unsupported, absolute path detection, error substring differences).
- Build and execute the version-test binary using
t.TempDir()and a.exesuffix on Windows.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/compile_integration_test.go | Skip PTY-based compile integration test on Windows where PTY isn’t supported. |
| pkg/cli/compile_command_test.go | Use an OS-appropriate absolute path to keep filepath.IsAbs-based validation test portable. |
| pkg/cli/commands_compile_workflow_test.go | Expect a platform-neutral error substring for missing workflow files. |
| pkg/actionpins/data/action_pins.json | Add the missing MCPG v0.3.24 container pin entry (tag → digest). |
| cmd/gh-aw/version_test.go | Build the test binary into t.TempDir() and use .exe on Windows. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
✅ smoke-ci: safeoutputs CLI comment + comment-memory run (27158217617)
|
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
Splits out the generic CI fixes from #37863 so they can land independently of that PR's behavior change.
What's fixed
testjob —TestGetContainerPin_DefaultMCPImagesArePinnedAdds the
ghcr.io/github/gh-aw-mcpg:v0.3.24entry (with verified digest from GHCR) topkg/actionpins/data/action_pins.json. The constantDefaultMCPGatewayVersionwas bumped tov0.3.24in #37708 but the embedded pin entry was missed, so the default-image-is-pinned test has been failing onmainsince.Windows Integration: compilejob (CWI workflow)compilation_with_nonexistent_file: relax the expected substring fromno such file(POSIX-only) tofailed to read file, which is what the engine itself emits on all platforms.absolute_path_not_allowed: pick an OS-appropriate absolute path sofilepath.IsAbsreturns true on Windows (C:\\absolute\\path).TestCompileWithIncludeWithEmptyFrontmatterUnderPty: skip on Windows wherecreack/ptyreturns 'unsupported'.Windows Integration: versionjob (CWI workflow)TestVersionIsSetDuringBuild: build the throwaway test binary insidet.TempDir()with the correct.exesuffix on Windows, instead of hardcoding/tmp/gh-aw-test-versionwhich doesn't exist as an executable path on Windows runners.Verification
These same fixes are also present in #37863 and will continue to land there if this PR merges first.