Remove imports.if and migrate experiment-driven import usage to runtime imports

[Copilot]

Conditional frontmatter imports were allowing experiment state to change imported setup and prompt material at runtime. This removes imports.if so imports remain security-stable, and moves the active experiment usage to body-level runtime imports instead.

• Parser and schema

  • Remove if from imports / imports.aw schema variants.
  • Reject imports.if during parsing with a migration-oriented error pointing to {{#runtime-import? ...}}.
  • Drop import-processing paths that propagated import conditions into nested imports, step guards, and prompt assembly.

• Prompt assembly

  • Simplify PromptImportEntry to ordered runtime/inlined import content only.
  • Remove prompt-time wrapping of imported content with generated {{#if ...}} blocks.

• Workflow migration

  • Update daily-safe-output-optimizer to keep setup imports unconditional.
  • Split the old shared import into:
    • shared/aw-logs-24h-fetch-setup.md for setup-time behavior
    • shared/aw-logs-24h-fetch-prompt.md for prompt text
  • Gate only the prompt content with {{#if experiments...}} + {{#runtime-import? ...}} (optional form, not promoted to unconditional lock-file macros).

• Docs and compatibility guidance

  • Document that conditional frontmatter imports are unsupported.
  • Point experiment-driven prompt variation to {{#runtime-import? ...}} (optional form) instead of the required form, so gated content is only injected when the condition is true at runtime.
  • Add a major changeset for the breaking frontmatter change.

# beforeimports:
- if: experiments.log_fetch_strategy == 'eager'uses: shared/aw-logs-24h-fetch.md# afterimports:
- uses: shared/aw-logs-24h-fetch-setup.md

{{#if experiments.log_fetch_strategy == "eager"}}
{{#runtime-import? shared/aw-logs-24h-fetch-prompt.md}}
{{else}}
Use the MCP tools directly for log collection.
{{/if}}

[pelikhan]

@copilot run pr-finisher skill

[Copilot]

Pull request overview

This PR removes support for conditional frontmatter imports (imports.if) to keep workflow setup/import graphs security-stable, and migrates experiment-driven prompt variation to runtime-import usage in the workflow body. It updates the parser/schema/compiler paths to drop condition propagation into prompt assembly and step injection, and adds documentation + a major changeset for the breaking change.

Changes:

• Remove imports.if from schema/types and delete compiler/parser logic that wrapped imported prompt content or injected step-level if guards from import specs.
• Add a migration-oriented parse error when imports.if is encountered and update docs to direct users toward runtime-import-based prompt variation.
• Migrate daily-safe-output-optimizer by splitting the prior shared import into setup-only vs prompt-only files and gating prompt text via template conditionals.

Show a summary per file

File	Description
pkg/workflow/compiler_yaml.go	Removes prompt-time {{#if ...}} wrapping for import entries and drops condition normalization used only for imports.if.
pkg/workflow/compiler_yaml_test.go	Removes unit test for the deleted condition-normalization helper.
pkg/parser/schemas/main_workflow_schema.json	Removes if from the imports/imports.aw object forms in the JSON schema.
pkg/parser/import_remote.go	Removes ifCondition from the import queue item struct.
pkg/parser/import_processor.go	Removes If from PromptImportEntry and ImportSpec to simplify ordered prompt import contributions.
pkg/parser/import_field_extractor.go	Removes conditional step-guard injection plumbing and simplifies prompt import tracking to runtime/inlined content only.
pkg/parser/import_field_extractor_test.go	Removes tests for step-level if injection behavior.
pkg/parser/import_bfs.go	Rejects import 'if' in import specs and removes if-condition conflict/propagation logic in BFS traversal.
pkg/parser/import_bfs_test.go	Updates tests to expect imports.if rejection and removes tests that depended on inherited/imported if behavior.
docs/src/content/docs/reference/imports.md	Documents that conditional frontmatter imports are unsupported and suggests runtime-import gating.
.github/workflows/shared/aw-logs-24h-fetch-setup.md	New shared workflow fragment containing only setup-time steps/tools for log prefetch.
.github/workflows/shared/aw-logs-24h-fetch-prompt.md	New shared prompt-only markdown fragment for the log bundle instructions.
.github/workflows/daily-safe-output-optimizer.md	Updates imports to keep setup unconditional and gates prompt text via {{#if experiments...}} + runtime import.
.github/workflows/daily-safe-output-optimizer.lock.yml	Regenerated compiled workflow reflecting the new import behavior.
.github/aw/syntax-tools-imports.md	Updates internal syntax docs to state conditional frontmatter imports are unsupported.
.github/aw/experiments.md	Adds an experiments anti-pattern note discouraging conditional frontmatter imports.
.changeset/major-remove-imports-if.md	Adds a major changeset documenting the breaking change and migration guidance.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 17/17 changed files
• Comments generated: 6

[Copilot]

Fixed in commit d99a6e9 — updated the migration error message to recommend {{#if ...}}{{#runtime-import? ...}}{{/if}} (optional form, not promoted to unconditional lock-file macros) for experiment-specific prompt imports.

[Copilot]

Fixed in commit d99a6e9 — the source now uses {{#runtime-import?}} (optional form), so the lock file no longer contains an unconditional {{#runtime-import .github/workflows/shared/aw-logs-24h-fetch-prompt.md}} macro. The lock file has been regenerated.

[Copilot]

Fixed in commit d99a6e9 — updated the guidance to recommend {{#runtime-import? ...}} (optional form) for experiment-gated prompt imports, with a note that the optional form is not promoted to unconditional lock-file macros.

[Copilot]

Fixed in commit d99a6e9 — updated the guidance to use {{#runtime-import? ...}} (optional form, not promoted to unconditional lock-file macros) for experiment-gated prompt imports.

[pelikhan]

@copilot run pr-finisher skill

[Copilot]

@copilot run pr-finisher skill

Done. Fixed the CI test failure in TestCompileWorkflowWithConditionalImport — updated it to expect rejection of imports.if rather than successful compilation of the removed feature (commit 6dc1c1f). The test now verifies either the schema validation error ("Unknown property: if") or the migration guard message ("import 'if' is no longer supported").

The TestHashConsistencyAcrossLockFiles parser failure in CI was transient — it passes locally with all 245 workflows verified.

All review threads from the prior session have replies; local validation (make agent-report-progress) passes.