fix: restore MCP CLI concept explanation and fix safeoutputs framing

[dsyme]

Summary

Two related fixes to the safeoutputs integration:

1. Path fix (e00e9395b, 71bdb4eca, cec086741): The safe_outputs_mcp_server.cjs entrypoint was hardcoded to ${GITHUB_WORKSPACE}/actions/setup/js/. This is corrected to ${RUNNER_TEMP}/gh-aw/safeoutputs/, where the script is actually deployed at runtime. All MCP config renderers (JSON Copilot, JSON Claude, TOML) and their corresponding unit and integration tests are updated.

2. Framing fix (b57fdf2f1): Agent prompts and internal comments incorrectly described safeoutputs as an MCP tool interface. The MCP CLI tools prompt is rewritten to clarify that the listed servers are CLI executables invoked with --name value flags or JSON via stdin, not MCP tool endpoints. The safe outputs prompt is updated to instruct agents to use the safeoutputs CLI command. A write-intent warning is also added to the MCP CLI tools prompt.

Breaking change in pkg/workflow/mcp_renderer_builtin.go: any previously generated gateway configs pointing to the old ${GITHUB_WORKSPACE}/actions/setup/js/ path will no longer match the rendered output.

---

Changed files

File	Kind	Impact	Notes
pkg/workflow/mcp_renderer_builtin.go	modified	high / breaking	Core path change: ${GITHUB_WORKSPACE}/actions/setup/js/ → ${RUNNER_TEMP}/gh-aw/safeoutputs/ for both JSON and TOML renderers
actions/setup/md/mcp_cli_tools_prompt.md	modified	medium	Rewritten to clarify CLI-executable semantics, added --name value and JSON-stdin examples, added write-intent warning
actions/setup/md/safe_outputs_prompt.md	modified	medium	Agents now instructed to use safeoutputs CLI command, not the MCP server tool interface
pkg/workflow/mcp_config_refactor_test.go	modified	medium	Test assertions updated for new ${RUNNER_TEMP}/gh-aw/safeoutputs/ path
pkg/workflow/mcp_renderer_test.go	modified	medium	Test assertions for all three config formats (JSON Copilot, JSON Claude, TOML) updated for new path
pkg/workflow/safe_outputs_mcp_integration_test.go	modified	medium	Integration test assertion updated for new generated workflow YAML path
pkg/workflow/prompts.go	modified	low	Comment updated: "safeoutputs MCP server" → "safeoutputs CLI tool"

---

Motivation

The safeoutputs script is not present in ${GITHUB_WORKSPACE}/actions/setup/js/ at agent runtime — it is installed under ${RUNNER_TEMP}/gh-aw/safeoutputs/ by the setup action. The mismatch meant the gateway config pointed to a non-existent path, silently breaking safeoutputs for any workflow using the built-in MCP renderer. The framing fix prevents agents from attempting to call safeoutputs as an MCP tool (which would also fail) instead of as a CLI command.

---

Test coverage

• Unit tests in mcp_config_refactor_test.go and mcp_renderer_test.go cover all rendered config formats.
• Integration test in safe_outputs_mcp_integration_test.go validates the path appears correctly in the generated workflow YAML end-to-end.

---

Checklist

• Breaking change documented (path change in mcp_renderer_builtin.go)
• All affected tests updated
• Prompt/comment language aligned with implementation reality
• Verify ${RUNNER_TEMP}/gh-aw/safeoutputs/safe_outputs_mcp_server.cjs is reliably present after setup action runs

Generated by PR Description Updater for issue #39689 · ◷

[Copilot]

Pull request overview

Restores missing agent-facing guidance about MCP CLI “servers” being invoked as shell executables (not via MCP tool interfaces), and fixes contradictory safeoutputs framing in the generated prompts/comments so agents are less likely to misuse the interface.

Changes:

• Expands mcp_cli_tools_prompt.md to reintroduce a concise CLI mental model, with concrete CLI/JSON-stdin examples and safeoutputs write-intent warnings.
• Updates safe_outputs_prompt.md wording to consistently describe safeoutputs as a CLI tool rather than an “MCP server”.
• Adjusts a high-level comment in pkg/workflow/prompts.go to match the updated framing.

Show a summary per file

File	Description
pkg/workflow/prompts.go	Updates prompt-area comment wording for safe outputs framing.
actions/setup/md/safe_outputs_prompt.md	Reframes safeoutputs guidance to explicitly reference the CLI tool.
actions/setup/md/mcp_cli_tools_prompt.md	Restores abbreviated concept explanation + usage examples for MCP CLI executables.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 3

[github-actions]

✅ smoke-ci: safeoutputs CLI comment + comment-memory run (27652140271)

Generated by 🧪 Smoke CI for issue #39689 · ◷