Uh oh!
There was an error while loading. Please reload this page.
Moving ESLint factory to new location - #41975
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…actory-to-top-level # Conflicts: # eslint-factory/src/rules/require-parseInt-radix.ts Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR relocates the custom ESLint rule “factory” into a new top-level eslint-factory/ directory and updates local tooling + automation workflows to reference the new path.
Changes:
- Updated Makefile JS dependency install, impacted-test selection, and formatting targets to include
eslint-factory/. - Added/updated
eslint-factory/project scaffolding (TypeScript build, Vitest config, ESLint flat config) and introduced a new ESLint rule (require-parseInt-radix). - Updated ESLint-related gh-aw workflows and regenerated their compiled
.lock.ymloutputs to point at the new location.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Extend JS deps/tests/formatting to include eslint-factory/ in addition to actions/setup/js. |
| eslint-factory/vitest.config.ts | Adds Vitest configuration for rule tests in the new package location. |
| eslint-factory/tsconfig.json | Adds TS build config for compiling rules to dist/. |
| eslint-factory/src/rules/require-parseInt-radix.ts | Introduces a new rule requiring explicit radix for parseInt. |
| eslint-factory/src/rules/require-json-parse-try-catch.ts | Updates rule metadata URL to reflect the new package path. |
| eslint-factory/src/rules/require-json-parse-try-catch.test.ts | Minor formatting change within existing rule tests. |
| eslint-factory/src/index.ts | Defines and exports the ESLint plugin entrypoint with registered rules. |
| eslint-factory/README.md | Updates command docs to target ../actions/setup/js/** more explicitly. |
| eslint-factory/package.json | Updates scripts to run ESLint against actions/setup/js from the new package location. |
| eslint-factory/package-lock.json | Adds lockfile for the new package location. |
| eslint-factory/eslint.config.cjs | Adds ESLint flat config enabling the custom plugin rules. |
| .github/workflows/eslint-refiner.md | Updates workflow paths/tools to reference eslint-factory/. |
| .github/workflows/eslint-refiner.lock.yml | Regenerated compiled workflow reflecting updated paths. |
| .github/workflows/eslint-monster.md | Updates workflow to cd eslint-factory for linting runs. |
| .github/workflows/eslint-monster.lock.yml | Regenerated compiled workflow reflecting updated paths. |
| .github/workflows/eslint-miner.md | Updates safe-outputs scope and docs to use eslint-factory/. |
| .github/workflows/eslint-miner.lock.yml | Regenerated compiled workflow reflecting updated paths. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 11/17 changed files
- Comments generated: 0
- Review effort level: Low
🤖 PR Triage — Run §28307424127
Summary: Clean directory reorganization — moves
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hey One thing to fix before this is ready for review:
If you'd like a hand, you can assign this prompt to your coding agent:
|
🎉 This pull request is included in a new release. Release: |
Pull request created by AI Agent