Skip to content

Moving ESLint factory to new location - #41975

Merged
pelikhan merged 2 commits into
mainfrom
copilot/move-eslint-factory-to-top-level
Jun 28, 2026
Merged

Moving ESLint factory to new location#41975
pelikhan merged 2 commits into
mainfrom
copilot/move-eslint-factory-to-top-level

Conversation

CopilotAI commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Pull request created by AI Agent

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…actory-to-top-level
# Conflicts:
#	eslint-factory/src/rules/require-parseInt-radix.ts
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review June 28, 2026 00:13
CopilotAI review requested due to automatic review settings June 28, 2026 00:13

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates the custom ESLint rule “factory” into a new top-level eslint-factory/ directory and updates local tooling + automation workflows to reference the new path.

Changes:

  • Updated Makefile JS dependency install, impacted-test selection, and formatting targets to include eslint-factory/.
  • Added/updated eslint-factory/ project scaffolding (TypeScript build, Vitest config, ESLint flat config) and introduced a new ESLint rule (require-parseInt-radix).
  • Updated ESLint-related gh-aw workflows and regenerated their compiled .lock.yml outputs to point at the new location.
Show a summary per file
FileDescription
MakefileExtend JS deps/tests/formatting to include eslint-factory/ in addition to actions/setup/js.
eslint-factory/vitest.config.tsAdds Vitest configuration for rule tests in the new package location.
eslint-factory/tsconfig.jsonAdds TS build config for compiling rules to dist/.
eslint-factory/src/rules/require-parseInt-radix.tsIntroduces a new rule requiring explicit radix for parseInt.
eslint-factory/src/rules/require-json-parse-try-catch.tsUpdates rule metadata URL to reflect the new package path.
eslint-factory/src/rules/require-json-parse-try-catch.test.tsMinor formatting change within existing rule tests.
eslint-factory/src/index.tsDefines and exports the ESLint plugin entrypoint with registered rules.
eslint-factory/README.mdUpdates command docs to target ../actions/setup/js/** more explicitly.
eslint-factory/package.jsonUpdates scripts to run ESLint against actions/setup/js from the new package location.
eslint-factory/package-lock.jsonAdds lockfile for the new package location.
eslint-factory/eslint.config.cjsAdds ESLint flat config enabling the custom plugin rules.
.github/workflows/eslint-refiner.mdUpdates workflow paths/tools to reference eslint-factory/.
.github/workflows/eslint-refiner.lock.ymlRegenerated compiled workflow reflecting updated paths.
.github/workflows/eslint-monster.mdUpdates workflow to cd eslint-factory for linting runs.
.github/workflows/eslint-monster.lock.ymlRegenerated compiled workflow reflecting updated paths.
.github/workflows/eslint-miner.mdUpdates safe-outputs scope and docs to use eslint-factory/.
.github/workflows/eslint-miner.lock.ymlRegenerated compiled workflow reflecting updated paths.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 11/17 changed files
  • Comments generated: 0
  • Review effort level: Low

@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage — Run §28307424127

FieldValue
Categoryrefactor
Risk🟢 Low
Score50/100
Score breakdownImpact 20 + Urgency 15 + Quality 15
Action✅ fast_track

Summary: Clean directory reorganization — moves eslint-factory to top-level, updates workflow MD/YAML references and Makefile. Pure renames/reference updates with no behavior change. CI green (1/1 pass). Ready for expedited human review.

Generated by 🔧 PR Triage Agent · 64.9 AIC · ⌖ 9.76 AIC · ⊞ 5.4K ·

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — thanks for this refactor moving eslint-factory to the top-level! The change is well-scoped: all 17 files are either renames of the eslint-factory/ tree or path-reference updates in workflows and the Makefile, and the existing test file (require-json-parse-try-catch.test.ts) is carried along.

One thing to fix before this is ready for review:

  • Add a PR description — the body currently reads "Pull request created by AI Agent", which gives reviewers nothing to go on. Please replace it with a short summary explaining why the directory is moving (e.g., was it nested too deeply? consolidating tooling at the root?) and call out any behavioural changes (e.g., updated Makefile targets, workflow path changes).

If you'd like a hand, you can assign this prompt to your coding agent:

Update the pull request body for PR #41975 in github/gh-aw.
Replace the generic placeholder with a concise description that covers:
1. Why eslint-factory is being moved to the top-level directory (motivation/context).
2. What changed — renamed directory tree, updated workflow references in .github/workflows/eslint-*.yml, and Makefile path adjustments.
3. Any impact on how contributors run ESLint locally or in CI.
Keep it under 150 words and use plain Markdown.

Generated by ✅ Contribution Check · 533.5 AIC · ⌖ 22.8 AIC · ⊞ 6K ·

@pelikhan
pelikhan merged commit 2d16c28 into mainJun 28, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/move-eslint-factory-to-top-level branch June 28, 2026 02:30
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.82.0

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pelikhan