Uh oh!
There was an error while loading. Please reload this page.
docs(parser): document missing internal dependencies in README - #44308
Merged
Conversation
3 tasks
…npututil, setutil Closes#44307 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Audit package specifications for coverage completenessdocs(parser): document missing internal dependencies in READMEJul 8, 2026
pelikhan
marked this pull request as ready for review
July 8, 2026 14:08
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pkg/parser package specification to accurately list internal dependencies used by the parser implementation, addressing missing items flagged by the spec-librarian audit.
Changes:
- Documented
pkg/envutilas an internal dependency used for consistent token env var access (GITHUB_TOKEN/GH_TOKEN). - Documented
pkg/importinpututilas an internal dependency used for import-input value resolution/formatting during import substitution. - Documented
pkg/setutilas an internal dependency used for import traversal and cycle-detection helpers.
Show a summary per file
| File | Description |
|---|---|
| pkg/parser/README.md | Adds three previously-undocumented internal dependencies to the ## Dependencies section to match actual parser imports/usage. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This was referenced Jul 8, 2026
Merged
Closed
Contributor
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/parser/README.mdwas missing three internal dependencies from its## Dependenciessection, flagged by the spec-librarian audit.Changes
pkg/parser/README.md: Added the three undocumented internal dependencies to the Internal section:envutil— env var reads forGITHUB_TOKEN/GH_TOKEN(github.go,github_wasm.go)importinpututil— input-value resolution for@importsubstitution (import_input_substitution.go)setutil— set membership used in BFS traversal and cycle detection (import_bfs.go,import_cycle.go,import_observability.go,import_topological.go)