fix: remove double-normalization in overridePersistedExtraheader

[Copilot]

The Matt Pocock Skills Reviewer flagged several issues in the git auth helper code introduced with the CI trigger push feature. Issues 1–4 (the overrideApplied guard, push-failure test, getErrorMessage usage, and missing silent flag on the write) were already resolved before this PR.

Changes

• Double-normalization fix (git_auth_helpers.cjs): overridePersistedExtraheader was calling normalizeServerUrl() on the input and then passing the result to getExtraheaderValues(), which normalizes again internally. Each function now normalizes its own input, making the contract unambiguous.

// Before: pre-normalized URL passed to a function that re-normalizesconstnormalizedUrl=normalizeServerUrl(serverUrl);previousValues=awaitgetExtraheaderValues(normalizedUrl);// double-normalize// After: each function owns its own normalizationpreviousValues=awaitgetExtraheaderValues(serverUrl);

• New test (git_auth_helpers.test.cjs): added a overridePersistedExtraheader test with a trailing-slash URL to explicitly assert that both the read (--get-all) and write (--replace-all) git config calls use the normalized key — documenting the normalization contract at the right layer.

[Copilot]

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Updates git auth helper behavior and tests to ensure URL normalization happens at the correct layer, avoiding passing pre-normalized values into helpers that also normalize.

Changes:

• Update overridePersistedExtraheader to pass the raw serverUrl into getExtraheaderValues() (which normalizes internally).
• Add a test asserting that a trailing-slash server URL results in normalized git config keys for both read and write operations.

Show a summary per file

File	Description
actions/setup/js/git_auth_helpers.cjs	Removes pre-normalization before calling getExtraheaderValues() to clarify normalization responsibility.
actions/setup/js/git_auth_helpers.test.cjs	Adds regression test for trailing-slash URLs to ensure normalized git config keys are used consistently.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Low

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.82.8