refactor: introduce options structs to eliminate excessivefuncparams linter violations by Copilot · Pull Request #46065 · github/gh-aw

Copilot · 2026-07-16T18:42:22Z

Two production functions carried //nolint:excessivefuncparams suppressions (9 params each), and four sibling functions in logs_download.go repeated an identical 8-param signature. This introduces options structs to collapse all of them.

Changes

downloadArtifactsOptions (logs_download.go) — bundles (runID, outputDir, verbose, owner, repo, hostname, artifactFilter) shared by downloadArtifactsByName, retryCriticalArtifacts, downloadRunArtifacts, and ensureUsageAwInfoFallback
runArtifactsConcurrentOptions (logs_run_processor.go) — collapses 7 positional params after ctx/runs in downloadRunArtifactsConcurrent; removes //nolint:excessivefuncparams
updateActionsOptions (update_actions.go) — collapses 7 positional params after ctx/deps in updateActionsInWorkflowFiles; removes //nolint:excessivefuncparams

Call sites updated across all callers and tests. Public API (UpdateActionsInWorkflowFiles) is unchanged.

Before / After

// BeforedownloadRunArtifactsConcurrent(ctx, runs, outputDir, verbose, maxRuns, repoOverride, artifactFilter, evalsOnly, artifactSets) //nolint:excessivefuncparams// AfterdownloadRunArtifactsConcurrent(ctx, runs, runArtifactsConcurrentOptions{
outputDir: outputDir,
verbose: verbose,
maxRuns: maxRuns,
repoOverride: repoOverride,
// ...
})

Zero behavioral change.

…violations - Add `downloadArtifactsOptions` struct in logs_download.go to collapse the common (runID, outputDir, verbose, owner, repo, hostname, artifactFilter) parameters shared by 4 sibling functions - Refactor `downloadArtifactsByName`, `retryCriticalArtifacts`, `downloadRunArtifacts`, and `ensureUsageAwInfoFallback` to use the struct - Add `runArtifactsConcurrentOptions` struct in logs_run_processor.go and refactor `downloadRunArtifactsConcurrent` (was 9 params → 3 params) - Add `updateActionsOptions` struct in update_actions.go and refactor `updateActionsInWorkflowFiles` (was 9 params → 3 params) - Update all call sites across audit.go, audit_comparison.go, audit_diff.go, forecast_compute.go, logs_orchestrator.go, logs_orchestrator_stdin.go, logs_run_processor.go, outcomes_command.go, view_command.go and test files - Removes 2 excessivefuncparams linter violations with zero behavioral change Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Per code review feedback: - In downloadRunArtifacts: remove unpack of runID/outputDir/verbose/owner/repo/hostname locals; access opts fields directly. Keep artifactFilter as a local since it is narrowed to `missing` in the filtered download path. - In updateActionsInWorkflowFiles: remove unpack of engineOverride/verbose/ disableReleaseBump/noCompile/coolDown/approve locals; access opts fields directly. Keep workflowsDir as a local since it falls back to getWorkflowsDir() when empty. - Simplify downloadArtifactsByName calls to pass opts directly instead of reconstructing a struct literal with individual opts.X fields. - Fix mangled comment and log format string where regex replaced variable names inside string literals. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Per second round of code review feedback: - In downloadRunArtifacts: remove the `artifactFilter` local that shadowed opts.artifactFilter. Access opts.artifactFilter directly throughout the function; where narrowing is needed, assign opts.artifactFilter = missing directly (opts is a value copy, so this only affects the local scope). - In updateActionsInWorkflowFiles: remove the `workflowsDir` local that shadowed opts.workflowsDir. Assign opts.workflowsDir = getWorkflowsDir() when empty and use opts.workflowsDir everywhere. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Since opts.artifactFilter is now used directly (narrowed via assignment), retryCriticalArtifacts and ensureUsageAwInfoFallback can receive opts directly rather than a reconstructed struct literal with the same fields. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Update doc comments on runArtifactsConcurrentOptions and updateActionsOptions to accurately state '8-parameter positional list' instead of '7-parameter'. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…ounts Replace "N-parameter positional list" wording with "long positional parameter list" to avoid ambiguity over whether ctx/deps/runs are counted. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…ral in forecast_compute - Move `opts` before `names` in downloadArtifactsByName signature (opts is the common parameter, names is the function-specific one) - Update all call sites accordingly - In forecast_compute.go, extract the inline downloadArtifactsOptions struct literal to a named local variable for readability Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…ts-options-str

Copilot

Pull request overview

This PR refactors several internal pkg/cli helpers to replace long positional parameter lists (and associated //nolint:excessivefuncparams suppressions) with small, per-call options structs, while keeping the exported API UpdateActionsInWorkflowFiles unchanged.

Changes:

Introduces downloadArtifactsOptions and updates artifact-download helpers/call sites to use it instead of repeating an 8-parameter signature.
Introduces runArtifactsConcurrentOptions to simplify downloadRunArtifactsConcurrent invocation and remove excessive-parameter lint suppression.
Introduces updateActionsOptions to simplify updateActionsInWorkflowFiles (internal) invocation and remove excessive-parameter lint suppression.

Show a summary per file

File	Description
pkg/cli/view_command.go	Updates artifact download call to pass `downloadArtifactsOptions`.
pkg/cli/update_actions.go	Adds `updateActionsOptions` and refactors internal workflow update function signature.
pkg/cli/update_actions_test.go	Updates tests to call `updateActionsInWorkflowFiles` with `updateActionsOptions`.
pkg/cli/outcomes_command.go	Updates artifact download call to pass `downloadArtifactsOptions`.
pkg/cli/logs_run_processor.go	Adds `runArtifactsConcurrentOptions` and refactors concurrent artifact download entrypoint and its internal calls.
pkg/cli/logs_parallel_test.go	Updates parallel download tests to use `runArtifactsConcurrentOptions`.
pkg/cli/logs_orchestrator.go	Updates orchestrator call site to pass `runArtifactsConcurrentOptions`.
pkg/cli/logs_orchestrator_test.go	Updates orchestrator tests to use `runArtifactsConcurrentOptions`.
pkg/cli/logs_orchestrator_stdin.go	Updates stdin orchestrator call site to pass `runArtifactsConcurrentOptions`.
pkg/cli/logs_download.go	Introduces `downloadArtifactsOptions` and refactors artifact download helpers to consume it.
pkg/cli/logs_download_test.go	Updates download-related tests to use `downloadArtifactsOptions`.
pkg/cli/forecast_compute.go	Updates usage-artifact download helper to call `downloadArtifactsByName` via `downloadArtifactsOptions`.
pkg/cli/audit.go	Updates audit artifact download calls to pass `downloadArtifactsOptions`.
pkg/cli/audit_test.go	Updates audit tests to call `downloadRunArtifacts` via `downloadArtifactsOptions`.
pkg/cli/audit_diff.go	Updates audit diff artifact download call to pass `downloadArtifactsOptions`.
pkg/cli/audit_comparison.go	Updates baseline artifact download call to pass `downloadArtifactsOptions`.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 16/16 changed files
Comments generated: 1
Review effort level: Low

Copilot · 2026-07-16T21:41:59Z

 	} else {
 logsDownloadLog.Printf("Could not list artifacts (will use bulk download): %v", listErr)
 	}


Fixed in 45a5164. When artifact listing fails and a filter is set, downloadRunArtifacts now falls back to trying the requested filter names directly instead of returning ErrNoArtifacts. Added a unit test (TestDownloadRunArtifacts_FilterFallsBackToRequestedNamesWhenListFails) to cover this path.

pelikhan · 2026-07-16T21:11:31Z

@copilot run pr-finisher skill

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-16T21:42:06Z

@copilot run pr-finisher skill

Ran pr-finisher workflow and applied the in-scope reviewer fix in commit 45a5164. I also triaged checks/mergeability and verified local validation; CI on the new head will require a maintainer re-trigger.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-17T07:25:08Z

🎉 This pull request is included in a new release.

Release: v0.82.12

Initial plan
047620d

CopilotAI assigned Copilot and pelikhan Jul 16, 2026

Copilotstarted work on behalf of pelikhan July 16, 2026 18:42 View session

CopilotAI linked an issue Jul 16, 2026 that may be closed by this pull request
[deep-report] [Code Quality] Extract downloadArtifactsOptions struct + remove 2 nolint:excessivefuncparams suppressions in logs_download #46021
Closed

CopilotAIand others added 8 commits July 16, 2026 19:16

refactor: fix parameter count in struct doc comments
ac8fc3f
Update doc comments on runArtifactsConcurrentOptions and updateActionsOptions to accurately state '8-parameter positional list' instead of '7-parameter'. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

refactor: add field-level doc comments to all three new options structs
4acd33d
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Extract downloadArtifactsOptions struct and remove linter suppressions~~refactor: introduce options structs to eliminate excessivefuncparams linter violationsJul 16, 2026

Copilotfinished work on behalf of pelikhan July 16, 2026 19:33

CopilotAI requested a review from pelikhan July 16, 2026 19:33

pelikhan marked this pull request as ready for review July 16, 2026 19:37

CopilotAI review requested due to automatic review settings July 16, 2026 19:37

Merge branch 'main' into copilot/deep-report-extract-download-artifac…
e08602a
…ts-options-str

Copilotstarted reviewing on behalf of pelikhan July 16, 2026 19:38 View session

CopilotAI reviewed Jul 16, 2026
View reviewed changes

Copilotstarted work on behalf of pelikhan July 16, 2026 21:12 View session

fix: fallback to requested artifact names when listing fails
45a5164
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAIand others added 4 commits July 16, 2026 21:47

test: shorten fallback test name
d8ea637
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

test: use camelCase fallback test name
d8f3137
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

test: clarify artifact list failure fallback test
d893ca6
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

test: shorten fallback test name and temp dir
25941e4
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilotfinished work on behalf of pelikhan July 16, 2026 22:04

pelikhan merged commit 8867a24 into mainJul 16, 2026
29 checks passed

pelikhan deleted the copilot/deep-report-extract-download-artifacts-options-str branch July 16, 2026 22:10

github-actionsBot mentioned this pull request Jul 16, 2026
Smoke Test: MAI-Code-1-Flash - 29538613340 #46092
Closed

This was referenced Jul 17, 2026
Smoke Test: MAI-Code-1-Flash - 29562782974 #46167
Closed
Smoke Test: MAI-Code-1-Flash - 29576465286 #46209
Closed
Smoke Test: MAI-Code-1-Flash - 29576602132 #46212
Closed
Smoke Test: MAI-Code-1-Flash - 29576796953 #46219
Closed

Navigation Menu

Uh oh!

refactor: introduce options structs to eliminate excessivefuncparams linter violations - #46065

refactor: introduce options structs to eliminate excessivefuncparams linter violations#46065
pelikhan merged 15 commits into
mainfrom
copilot/deep-report-extract-download-artifacts-options-str

CopilotAI commented Jul 16, 2026•
edited
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

CopilotAIJul 16, 2026

Uh oh!

pelikhan commented Jul 16, 2026

Uh oh!

CopilotAI commented Jul 16, 2026

Uh oh!

Uh oh!

github-actionsBot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

CopilotAI commented Jul 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Before / After

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

CopilotAIJul 16, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Jul 16, 2026

Uh oh!

CopilotAI commented Jul 16, 2026

Uh oh!

Uh oh!

github-actionsBot commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CopilotAI commented Jul 16, 2026•
edited
Loading