Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation by Copilot · Pull Request #48223 · github/gh-aw

Copilot · 2026-07-26T20:19:33Z

pkg/cli/compile_schedule_calendar.go still had direct, inline Lipgloss style construction for heatmap cells, diverging from the shared pkg/styles path and bypassing standard color degradation behavior. This PR aligns the calendar renderer with centralized schedule style tokens and ensures rendered output respects environment-driven color suppression.

Style source consolidation
- Removed inline fallback style construction from intensityStyle.
- intensityStyle now only maps intensity buckets to centralized styles.ScheduleCalendar* variables.
TTY + color-profile rendering path
- Added a small renderer helper that:
  - returns plain text for non-TTY output
  - otherwise renders with centralized style and passes through colorwriter.Degrade(...) using process environment
- This routes calendar cell/legend coloring through the same NO_COLOR/COLORTERM-aware degradation path used elsewhere.
Call-site simplification
- Removed isTerminal from intensityStyle API.
- Updated calendar grid and legend rendering to use the new centralized render helper.

Behavioral illustration

funcrenderScheduleCalendarCell(countint, textstring, isTerminalbool, environ []string) string {
if!isTerminal {
returntext
}
returncolorwriter.Degrade(intensityStyle(count).Render(text), environ)
}

Fixes[Code Quality] Replace inline lipgloss.NewStyle() in compile_schedule_calendar.go with centralized pkg/styles vars #48217

Run: https://github.com/github/gh-aw/actions/runs/30221620246

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.7 AIC · ⌖ 7.23 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/30223671533

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 12.5 AIC · ⌖ 7.96 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/30224763533

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.68 AIC · ⌖ 9.81 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/30228781602

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.4 AIC · ⌖ 8.55 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/30230557448

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.62 AIC · ⌖ 7.86 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/30233154470

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13 AIC · ⌖ 7.3 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Run: https://github.com/github/gh-aw/actions/runs/30240308794

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 23.9 AIC · ⌖ 8.09 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

…gradation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-26T20:49:44Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-07-26T20:49:57Z

✅ Test Quality Sentinel completed test quality analysis.

github-actions · 2026-07-26T20:50:15Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #48223 does not have the 'implementation' label and has only 27 new lines of code in business logic directories (threshold: 100).

github-actions · 2026-07-26T20:50:46Z

✅ PR Code Quality Reviewer completed the code quality review.

Copilot

Pull request overview

Centralizes schedule heatmap styling and adds environment-aware color degradation.

Changes:

Reuses shared schedule calendar styles.
Suppresses ANSI output for non-TTY and NO_COLOR environments.
Adds rendering-path tests.

Show a summary per file

File	Description
`pkg/cli/compile_schedule_calendar.go`	Centralizes and degrades cell styling.
`pkg/cli/compile_schedule_calendar_test.go`	Tests plain-text rendering paths.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 2
Review effort level: Medium

github-actions

The refactor looks correct and well-structured.

intensityStyle now cleanly maps buckets to centralized style tokens with no inline fallbacks.
TTY-gating and NO_COLOR/COLORTERM degradation are handled in the new renderScheduleCalendarCell helper, consistent with the rest of the codebase.
os.Environ() is captured once per displayScheduleCalendar call, not per cell.
Tests cover both non-TTY and NO_COLOR suppression paths.

No actionable issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 18.4 AIC · ⌖ 7.99 AIC · ⊞ 5K

github-actions

Skills-Based Review 🧠

Applied /codebase-design — approving with one minor observation on redundant test assertions.

📋 Key Themes & Highlights

Key Themes

Style consolidation is clean: intensityStyle now delegates entirely to centralized styles.Schedule* tokens — good deep module behavior.
renderScheduleCalendarCell is a well-named, single-responsibility helper. Moving the TTY gate and colorwriter.Degrade call here is the right seam.
Test coverage is solid — both the non-TTY path and the NO_COLOR degradation path are explicitly exercised.

Minor Observation (inline comment)

The NotContains(t, got, "\x1b[") assertion after an Equal(t, got, text) assertion is redundant — if they're equal, the ANSI check can't independently fail. Keeping only the Equal assertion produces a cleaner failure message.

Positive Highlights

✅ Clean removal of the isTerminal parameter from intensityStyle — simpler API
✅ os.Environ() captured once and threaded through, avoiding repeated syscalls
✅ Both call sites (grid and legend) updated consistently

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 20.6 AIC · ⌖ 4.65 AIC · ⊞ 6.7K
_{Comment /matt to run again}

github-actions · 2026-07-26T20:55:00Z

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 100/100 — Excellent

Analyzed 2 test(s): 2 design, 0 implementation, 0 violation(s).

📊 Metrics (2 tests)

Metric	Value
Analyzed	2 (Go: 2, JS: 0)
✅ Design	2 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	2 (100%)
Duplicate clusters	0
Inflation	No (0.93:1)
🚨 Violations	0

Test Classification:

Test	File	Design Invariant	Classification
`TestRenderScheduleCalendarCell_NoANSIWhenNotTerminal`	`compile_schedule_calendar_test.go:208`	Non-TTY outputs must strip ANSI escape codes	`design_test` / `high_value`
`TestRenderScheduleCalendarCell_NoANSIWhenNoColor`	`compile_schedule_calendar_test.go:217`	NO_COLOR environment variable must be honored, stripping ANSI	`design_test` / `high_value`

Quality Signals

✅ Clean design refactoring — Both tests verify the new renderScheduleCalendarCell function's core contract: degrading styled output to plain text under non-TTY or NO_COLOR conditions. Each test exercises 5 intensity levels, ensuring the behavior is consistent across the supported range.

✅ Edge-case coverage — Tests explicitly verify the behavioral boundary: that ANSI escapes are absent in constrained environments, not just that plain text is returned.

✅ No test inflation — Test file adds 13 lines against 14 lines in production (0.93:1 ratio), indicating focused, non-redundant test additions.

Verdict

✅ passed. 0% implementation tests (threshold: 30%), 100% design tests, no violations.

🧪 Test quality analysis by Test Quality Sentinel · haiku45 · 12.4 AIC · ⌖ 7.64 AIC · ⊞ 8.1K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 100/100. 0% implementation tests (threshold: 30%), 100% design tests, no violations.

github-actions

One non-blocking issue

The refactor cleanly centralizes style tokens and adds NO_COLOR-aware degradation. One concern worth addressing: intensityStyle().Render() now always executes on a TTY, even when colorwriter.Degrade will immediately discard the ANSI output (e.g. NO_COLOR=1). The previous design short-circuited before Render in that case. See the inline comment for a suggested fix.

🔎 Code quality review by PR Code Quality Reviewer · sonnet46 · 27.9 AIC · ⌖ 4.68 AIC · ⊞ 5.7K
_{Comment /review to run again}

gh-aw-bot · 2026-07-26T21:19:03Z

@copilot please run the pr-finisher skill, bring this branch to closure on the remaining review feedback below, and reply with whether it is ready for maintainer review.

Unresolved review feedback (newest first):

github-actions: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)
github-actions: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)
copilot-pull-request-reviewer: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)
copilot-pull-request-reviewer: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)

Run: https://github.com/github/gh-aw/actions/runs/30220597059

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 16.5 AIC · ⌖ 6.1 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

github-actions · 2026-07-27T01:06:09Z

🤖 PR Triage

Field	Value
Category	refactor
Risk	🟢 low
Priority Score	38 / 100
Score Breakdown	Impact: 18 · Urgency: 10 · Quality: 10
Recommended Action	⚡ fast_track

Summary: Aligns schedule heatmap calendar renderer to use centralized pkg/styles theme tokens instead of inline Lipgloss — improves NO_COLOR-awareness and style consistency. Multiple AI APPROVALs (github-actions[bot] ✅). No pending CHANGES_REQUESTED. CI status unknown (no check-runs data).

Next action: Fast-track — verify CI passes then merge.

Generated by 🔧 PR Triage Agent · sonnet46 · 49 AIC · ⌖ 8.25 AIC · ⊞ 5.7K · ◷

gh-aw-bot · 2026-07-27T01:08:58Z

@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks once the branch is up to date.

Unresolved review threads:

copilot-pull-request-reviewer: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)
copilot-pull-request-reviewer: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)
github-actions: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)
github-actions: Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradation #48223 (comment)

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 11.4 AIC · ⌖ 8.55 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-27T01:21:18Z

@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks once the branch is up to date.
Unresolved review threads:...

Completed this pr-finisher pass.

The listed review threads are now resolved in GitHub (all four links).
Branch is up to date with main (d4872c2 on origin/main, already included).
Re-ran checks:
- make fmt ✅
- make lint ✅
- make test-unit ✅ (impacted package run)
- make test ❌ due pre-existing unrelated failure: TestFallbackAWFilesMatchesLocalAWDirectory in pkg/cli/copilot_agents_test.go (fallback AW file list still expects linter-workflows.md).
Reviewed workflow run 30228781602: completed success; get_job_logs(failed_only=true) shows no failed jobs.

No additional PR-file changes were made in this pass. CI on the current agent head remains unverified until a maintainer re-triggers workflows.

gh-aw-bot · 2026-07-27T01:52:03Z

@copilot please run the pr-finisher skill, address unresolved review feedback and any failing checks, then rerun the relevant checks once the branch is ready for maintainer review.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 4.62 AIC · ⌖ 7.86 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-27T02:06:47Z

@copilot please run the pr-finisher skill, address unresolved review feedback and any failing checks, then rerun the relevant checks once the branch is ready for maintainer review.
...

Completed a fresh pr-finisher pass.

Unresolved in-scope review threads: none (all current Copilot/GitHub Actions threads on this PR are resolved).
Branch status: up to date with main (current branch HEAD contains origin/main at d4872c2).
CI run check: reviewed run 30230557448; get_job_logs(failed_only=true) reports no failed jobs.
Local checks rerun:
- make fmt ✅
- make lint ✅
- make test-unit ✅ (after fetching origin/main for merge-base)
- go test ./pkg/cli -run ScheduleCalendar -count=1 ✅
- make test ❌ with pre-existing unrelated failure: TestFallbackAWFilesMatchesLocalAWDirectory in pkg/cli/copilot_agents_test.go (fallback AW file list expects linter-workflows.md).

No additional PR-file changes were required in this pass. From the scope of this PR, it is ready for maintainer review; CI on the latest agent head still requires maintainer re-trigger for fresh required-check status.

gh-aw-bot · 2026-07-27T02:58:28Z

@copilot please run the pr-finisher skill, update the branch if GitHub allows it, and move this PR toward merge readiness.

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 13 AIC · ⌖ 7.3 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

gh-aw-bot · 2026-07-27T05:46:36Z

@copilot please run the pr-finisher skill, address the failed checks and confirm whether any unresolved review feedback remains on the current head.

Failed checks:

Please summarize whether this PR needs code changes, only a re-run on current head, or is blocked by an unrelated baseline issue.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 23.9 AIC · ⌖ 8.09 AIC · ⊞ 7.1K · ◷
_{Comment /souschef to run again}

pelikhan · 2026-07-27T05:55:11Z

+// presence of NO_COLOR disables color regardless of its value.
+func hasNoColorEnviron(environ []string) bool {
+	for _, envVar := range environ {
+ if strings.HasPrefix(envVar, "NO_COLOR=") {


@copilot there are helpers to detect no color envs, reuse

Updated in 4eb3843: removed the local hasNoColorEnviron helper and now reuse console.IsAccessibleMode() in renderScheduleCalendarCell for no-color/accessibility suppression.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-27T06:16:40Z

@copilot please run the pr-finisher skill, address the failed checks and confirm whether any unresolved review feedback remains on the current head.
Failed checks:...

Ran a fresh pr-finisher pass on current head.

Code changes needed: yes, one minimal fix for unresolved review feedback from @pelikhan (4eb3843) to reuse existing no-color/accessibility helper logic.
Failed checks in run 30229323446: both test and impacted-go-tests fail on TestFallbackAWFilesMatchesLocalAWDirectory (pkg/cli/copilot_agents_test.go), which is unrelated baseline/test-data drift, not caused by this schedule-calendar PR.
Local validation on current head: make fmt, make lint, make test-unit, make test, and make recompile all pass.
Unresolved review feedback on current head: none in scope beyond the @pelikhan thread now addressed by 4eb3843.

Conclusion: this PR has the required code fix and is ready for maintainer review; CI on latest head still requires maintainer re-trigger for fresh required-check status.

github-actions · 2026-07-27T09:14:51Z

🎉 This pull request is included in a new release.

Release: v0.83.4

Initial plan
84bec89

CopilotAI assigned Copilot and pelikhan Jul 26, 2026

CopilotAI linked an issue Jul 26, 2026 that may be closed by this pull request
[Code Quality] Replace inline lipgloss.NewStyle() in compile_schedule_calendar.go with centralized pkg/styles vars #48217
Closed

Copilotstarted work on behalf of pelikhan July 26, 2026 20:20 View session

refactor(cli): use centralized schedule calendar styles with color de…
fe6bcd9
…gradation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Refactor compile_schedule_calendar.go to use centralized style vars~~Refactor schedule heatmap styling to use centralized theme styles with NO_COLOR-aware degradationJul 26, 2026

Copilotfinished work on behalf of pelikhan July 26, 2026 20:34

CopilotAI requested a review from pelikhan July 26, 2026 20:34

pelikhan marked this pull request as ready for review July 26, 2026 20:48

CopilotAI review requested due to automatic review settings July 26, 2026 20:48

Copilotstarted reviewing on behalf of pelikhan July 26, 2026 20:49 View session

CopilotAI reviewed Jul 26, 2026
View reviewed changes

Comment threadpkg/cli/compile_schedule_calendar.go Outdated
Comment threadpkg/cli/compile_schedule_calendar_test.go

github-actionsBot approved these changes Jul 26, 2026
View reviewed changes

Comment threadpkg/cli/compile_schedule_calendar_test.go

github-actionsBot mentioned this pull request Jul 26, 2026
[aw] No-Op Runs #43499
Closed

github-actionsBot approved these changes Jul 26, 2026
View reviewed changes

github-actionsBot reviewed Jul 26, 2026
View reviewed changes

Comment threadpkg/cli/compile_schedule_calendar.go

github-actionsBot mentioned this pull request Jul 26, 2026
[Contribution Check Report] Contribution Check — 2026-07-26 #48091
Closed

github-actionsBot mentioned this pull request Jul 26, 2026
[pr-sous-chef] pr-sous-chef run report #48081
Closed

Copilotstarted work on behalf of gh-aw-bot July 26, 2026 21:19 View session

CopilotAIand others added 3 commits July 26, 2026 21:23

Plan: address remaining PR feedback
39bfb4f
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Fix schedule calendar review feedback for wasm and terminal tests
8fa7b90
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Adjust NO_COLOR env detection and style interface naming
df7deea
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

github-actionsBot added pr-action:fast_track pr-agent:copilot pr-priority:medium pr-risk:low pr-type:refactor labels Jul 27, 2026

Copilotstarted work on behalf of gh-aw-bot July 27, 2026 01:09 View session

chore: begin pr finisher pass for unresolved threads
f42e1e9
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilotfinished work on behalf of gh-aw-bot July 27, 2026 01:21

Copilotstarted work on behalf of gh-aw-bot July 27, 2026 01:52 View session

Copilotfinished work on behalf of gh-aw-bot July 27, 2026 02:07

Copilotstarted work on behalf of gh-aw-bot July 27, 2026 02:59 View session

Merge branch 'main' into copilot/replace-inline-lipgloss-style
8ceaf55

Copilotstarted work on behalf of gh-aw-bot July 27, 2026 05:47 View session

pelikhan reviewed Jul 27, 2026
View reviewed changes

Copilotstarted work on behalf of pelikhan July 27, 2026 06:03 View session

Reuse shared no-color helper in schedule calendar renderer
4eb3843
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilotfinished work on behalf of pelikhan July 27, 2026 06:17

CopilotAI requested a review from pelikhan July 27, 2026 06:17

pelikhan merged commit 5fd0a1b into mainJul 27, 2026
27 checks passed

pelikhan deleted the copilot/replace-inline-lipgloss-style branch July 27, 2026 06:35

github-actionsBot mentioned this pull request Jul 27, 2026
Smoke Test: MAI-Code-1-Flash - 30250271731 #48331
Closed

Uh oh!

Conversation

CopilotAI commented Jul 26, 2026• edited by github-actions BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Minor Observation (inline comment)

Positive Highlights

Uh oh!

Uh oh!

github-actionsBot commented Jul 26, 2026

🧪 Test Quality Sentinel Report

Quality Signals

Verdict

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

One non-blocking issue

Uh oh!

Uh oh!

gh-aw-bot commented Jul 26, 2026

Uh oh!

github-actionsBot commented Jul 27, 2026

🤖 PR Triage

Uh oh!

gh-aw-bot commented Jul 27, 2026

Uh oh!

CopilotAI commented Jul 27, 2026

Uh oh!

gh-aw-bot commented Jul 27, 2026

Uh oh!

CopilotAI commented Jul 27, 2026

Uh oh!

gh-aw-bot commented Jul 27, 2026

Uh oh!

gh-aw-bot commented Jul 27, 2026

Uh oh!

pelikhanJul 27, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAIJul 27, 2026

Choose a reason for hiding this comment

Uh oh!

CopilotAI commented Jul 27, 2026

Uh oh!

Uh oh!

github-actionsBot commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

CopilotAI commented Jul 26, 2026•
edited by github-actions Bot
Loading

github-actionsBot commented Jul 26, 2026•
edited
Loading

github-actionsBot commented Jul 26, 2026•
edited
Loading

github-actionsBot commented Jul 26, 2026•
edited
Loading

github-actionsBot commented Jul 26, 2026•
edited
Loading