Skip to content

Add max-tool-denials: 3 to all 67 copilot-sdk workflows - #48293

Merged
pelikhan merged 2 commits into
mainfrom
copilot/copilot-cli-research-deep-analysis
Jul 27, 2026
Merged

Add max-tool-denials: 3 to all 67 copilot-sdk workflows#48293
pelikhan merged 2 commits into
mainfrom
copilot/copilot-cli-research-deep-analysis

Conversation

CopilotAI commented Jul 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

All 67 copilot-sdk: true workflows lacked an explicit max-tool-denials setting, leaving them exposed to infinite tool-permission loops that silently burn tokens. This gap was flagged across 18+ consecutive research cycles with zero remediation.

Changes

  • 67 workflow .md files — adds max-tool-denials: 3 as a top-level frontmatter field immediately after each workflow's engine: block
  • 67 corresponding .lock.yml files — recompiled to keep lock files in sync
engine:
id: copilotcopilot-sdk: truemax-tool-denials: 3# ← added; aborts after 3 consecutive denied tool calls

The value 3 is tighter than the default 5, providing an explicit circuit breaker without being overly aggressive for normal tool use.

CopilotAI linked an issue Jul 27, 2026 that may be closed by this pull request
[copilot-cli-research] Copilot CLI Deep Research - 2026-07-27 #48278
Closed
11 tasks
@github-actionsgithub-actionsBot mentioned this pull request Jul 27, 2026
Closed
@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Hey @app/copilot-swe-agent 👋 — thanks for starting work on the Copilot CLI optimization analysis from #48278! This is a solid planning PR. Here are a few suggestions as you move forward:

  • Add test coverage — when you implement the workflow changes (adding max-tool-denials: 3), include validation tests to ensure the new config is applied correctly across the 67 workflows.
  • Update PR description — as you complete each checklist item, add a summary of what was changed and why. This helps reviewers understand the scope.
  • Remove draft status — once the work is complete and all checklist items are done, mark the PR ready for review.

The research context from #48278 is clear, so you're on the right track. Keep the checklist items updated as you progress!

Once the workflow modifications are complete, add integration tests that verify `max-tool-denials: 3` is correctly set in all 67 updated workflows. Use jq or similar tooling to validate the config in the compiled workflow files.

Generated by ✅ Contribution Check · sonnet46 · 53.3 AIC · ⌖ 7.74 AIC · ⊞ 6.2K · ◷

@pelikhan
Add max-tool-denials: 3 to all 67 copilot-sdk: true workflows
55d7432
Addresses the #1 critical gap flagged for 18+ consecutive research runs:
none of the 67 copilot-sdk workflows had max-tool-denials set, allowing
potential infinite tool-permission loops that burn tokens.
All 67 workflows now include `max-tool-denials: 3` placed immediately
after their engine block. All 263 workflow files recompiled successfully
with 0 errors.
Closes#48278
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title [WIP] Analyze Copilot CLI optimization opportunitiesAdd max-tool-denials: 3 to all 67 copilot-sdk workflowsJul 27, 2026
CopilotAI requested a review from pelikhanJuly 27, 2026 06:14
@pelikhan
pelikhan marked this pull request as ready for review July 27, 2026 06:18
CopilotAI review requested due to automatic review settings July 27, 2026 06:18
@pelikhan
pelikhan merged commit 8cd73e1 into mainJul 27, 2026
@pelikhan
pelikhan deleted the copilot/copilot-cli-research-deep-analysis branch July 27, 2026 06:18
CopilotAI reviewed Jul 27, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Sets max-tool-denials: 3 across 67 Copilot SDK workflows and recompiles their generated lock files.

Changes:

  • Adds an explicit tool-denial threshold to workflow frontmatter.
  • Updates compiled hashes and GH_AW_MAX_TOOL_DENIALS.
  • Three workflows use a custom driver that currently ignores this setting.
Show a summary per file
FileDescription
.github/workflows/agent-performance-analyzer.mdAdds threshold.
.github/workflows/agent-performance-analyzer.lock.ymlRecompiled output.
.github/workflows/architecture-guardian.mdAdds threshold.
.github/workflows/architecture-guardian.lock.ymlRecompiled output.
.github/workflows/artifacts-summary.mdAdds threshold.
.github/workflows/artifacts-summary.lock.ymlRecompiled output.
.github/workflows/brave.mdAdds threshold.
.github/workflows/brave.lock.ymlRecompiled output.
.github/workflows/breaking-change-checker.mdAdds threshold.
.github/workflows/breaking-change-checker.lock.ymlRecompiled output.
.github/workflows/ci-coach.mdAdds threshold.
.github/workflows/ci-coach.lock.ymlRecompiled output.
.github/workflows/cli-consistency-checker.mdAdds threshold.
.github/workflows/cli-consistency-checker.lock.ymlRecompiled output.
.github/workflows/code-scanning-fixer.mdAdds threshold.
.github/workflows/code-scanning-fixer.lock.ymlRecompiled output.
.github/workflows/copilot-cli-deep-research.mdAdds threshold.
.github/workflows/copilot-cli-deep-research.lock.ymlRecompiled output.
.github/workflows/copilot-opt.mdAdds threshold.
.github/workflows/copilot-opt.lock.ymlRecompiled output.
.github/workflows/copilot-pr-merged-report.mdAdds threshold.
.github/workflows/copilot-pr-merged-report.lock.ymlRecompiled output.
.github/workflows/copilot-pr-nlp-analysis.mdAdds threshold.
.github/workflows/copilot-pr-nlp-analysis.lock.ymlRecompiled output.
.github/workflows/copilot-pr-prompt-analysis.mdAdds threshold.
.github/workflows/copilot-pr-prompt-analysis.lock.ymlRecompiled output.
.github/workflows/craft.mdAdds threshold.
.github/workflows/craft.lock.ymlRecompiled output.
.github/workflows/daily-agent-of-the-day-blog-writer.mdAdds threshold.
.github/workflows/daily-agent-of-the-day-blog-writer.lock.ymlRecompiled output.
.github/workflows/daily-architecture-diagram.mdAdds threshold.
.github/workflows/daily-architecture-diagram.lock.ymlRecompiled output.
.github/workflows/daily-assign-issue-to-user.mdAdds threshold.
.github/workflows/daily-assign-issue-to-user.lock.ymlRecompiled output.
.github/workflows/daily-cli-performance.mdAdds threshold.
.github/workflows/daily-cli-performance.lock.ymlRecompiled output.
.github/workflows/daily-compiler-quality.mdAdds threshold.
.github/workflows/daily-compiler-quality.lock.ymlRecompiled output.
.github/workflows/daily-compiler-threat-spec-optimizer.mdAdds threshold.
.github/workflows/daily-compiler-threat-spec-optimizer.lock.ymlRecompiled output.
.github/workflows/daily-experiment-report.mdAdds threshold.
.github/workflows/daily-experiment-report.lock.ymlRecompiled output.
.github/workflows/daily-formal-spec-verifier.mdAdds threshold.
.github/workflows/daily-formal-spec-verifier.lock.ymlRecompiled output.
.github/workflows/daily-geo-optimizer.mdAdds threshold.
.github/workflows/daily-geo-optimizer.lock.ymlRecompiled output.
.github/workflows/daily-github-docs-seo-optimizer.mdAdds threshold.
.github/workflows/daily-github-docs-seo-optimizer.lock.ymlRecompiled output.
.github/workflows/daily-issues-report.mdAdds threshold; custom driver ignores it.
.github/workflows/daily-issues-report.lock.ymlRecompiled output.
.github/workflows/daily-malicious-code-scan.mdAdds threshold.
.github/workflows/daily-malicious-code-scan.lock.ymlRecompiled output.
.github/workflows/daily-mcp-concurrency-analysis.mdAdds threshold.
.github/workflows/daily-mcp-concurrency-analysis.lock.ymlRecompiled output.
.github/workflows/daily-model-inventory.mdAdds threshold; custom driver ignores it.
.github/workflows/daily-model-inventory.lock.ymlRecompiled output.
.github/workflows/daily-model-resolution.mdAdds threshold.
.github/workflows/daily-model-resolution.lock.ymlRecompiled output.
.github/workflows/daily-performance-summary.mdAdds threshold.
.github/workflows/daily-performance-summary.lock.ymlRecompiled output.
.github/workflows/daily-repo-chronicle.mdAdds threshold.
.github/workflows/daily-repo-chronicle.lock.ymlRecompiled output.
.github/workflows/daily-safe-output-integrator.mdAdds threshold.
.github/workflows/daily-safe-output-integrator.lock.ymlRecompiled output.
.github/workflows/daily-secrets-analysis.mdAdds threshold.
.github/workflows/daily-secrets-analysis.lock.ymlRecompiled output.
.github/workflows/daily-security-observability.mdAdds threshold.
.github/workflows/daily-security-observability.lock.ymlRecompiled output.
.github/workflows/daily-sentrux-report.mdAdds threshold.
.github/workflows/daily-sentrux-report.lock.ymlRecompiled output.
.github/workflows/daily-skill-optimizer.mdAdds threshold; custom driver ignores it.
.github/workflows/daily-skill-optimizer.lock.ymlRecompiled output.
.github/workflows/daily-spdd-spec-planner.mdAdds threshold.
.github/workflows/daily-spdd-spec-planner.lock.ymlRecompiled output.
.github/workflows/daily-syntax-error-quality.mdAdds threshold.
.github/workflows/daily-syntax-error-quality.lock.ymlRecompiled output.
.github/workflows/daily-testify-uber-super-expert.mdAdds threshold.
.github/workflows/daily-testify-uber-super-expert.lock.ymlRecompiled output.
.github/workflows/daily-workflow-updater.mdAdds threshold.
.github/workflows/daily-workflow-updater.lock.ymlRecompiled output.
.github/workflows/dead-code-remover.mdAdds threshold.
.github/workflows/dead-code-remover.lock.ymlRecompiled output.
.github/workflows/delight.mdAdds threshold.
.github/workflows/delight.lock.ymlRecompiled output.
.github/workflows/deployment-incident-monitor.mdAdds threshold.
.github/workflows/deployment-incident-monitor.lock.ymlRecompiled output.
.github/workflows/dev-hawk.mdAdds threshold.
.github/workflows/dev-hawk.lock.ymlRecompiled output.
.github/workflows/dictation-prompt.mdAdds threshold.
.github/workflows/dictation-prompt.lock.ymlRecompiled output.
.github/workflows/discussion-task-miner.mdAdds threshold.
.github/workflows/discussion-task-miner.lock.ymlRecompiled output.
.github/workflows/docs-noob-tester.mdAdds threshold.
.github/workflows/docs-noob-tester.lock.ymlRecompiled output.
.github/workflows/draft-pr-cleanup.mdAdds threshold.
.github/workflows/draft-pr-cleanup.lock.ymlRecompiled output.
.github/workflows/eslint-miner.mdAdds threshold.
.github/workflows/eslint-miner.lock.ymlRecompiled output.
.github/workflows/firewall-escape.mdAdds threshold.
.github/workflows/firewall-escape.lock.ymlRecompiled output.
.github/workflows/firewall.mdAdds threshold.
.github/workflows/firewall.lock.ymlRecompiled output.
.github/workflows/jsweep.mdAdds threshold.
.github/workflows/jsweep.lock.ymlRecompiled output.
.github/workflows/layout-spec-maintainer.mdAdds threshold.
.github/workflows/layout-spec-maintainer.lock.ymlRecompiled output.
.github/workflows/linter-miner.mdAdds threshold.
.github/workflows/linter-miner.lock.ymlRecompiled output.
.github/workflows/mcp-inspector.mdAdds threshold.
.github/workflows/mcp-inspector.lock.ymlRecompiled output.
.github/workflows/mergefest.mdAdds threshold.
.github/workflows/mergefest.lock.ymlRecompiled output.
.github/workflows/metrics-collector.mdAdds threshold.
.github/workflows/metrics-collector.lock.ymlRecompiled output.
.github/workflows/org-health-report.mdAdds threshold.
.github/workflows/org-health-report.lock.ymlRecompiled output.
.github/workflows/pdf-summary.mdAdds threshold.
.github/workflows/pdf-summary.lock.ymlRecompiled output.
.github/workflows/plan.mdAdds threshold.
.github/workflows/plan.lock.ymlRecompiled output.
.github/workflows/pr-code-quality-reviewer.mdAdds threshold.
.github/workflows/pr-code-quality-reviewer.lock.ymlRecompiled output.
.github/workflows/pr-nitpick-reviewer.mdAdds threshold.
.github/workflows/pr-nitpick-reviewer.lock.ymlRecompiled output.
.github/workflows/pr-triage-agent.mdAdds threshold.
.github/workflows/pr-triage-agent.lock.ymlRecompiled output.
.github/workflows/python-data-charts.mdAdds threshold.
.github/workflows/python-data-charts.lock.ymlRecompiled output.
.github/workflows/q.mdAdds threshold.
.github/workflows/q.lock.ymlRecompiled output.
.github/workflows/smoke-copilot-sdk.mdAdds threshold.
.github/workflows/smoke-copilot-sdk.lock.ymlRecompiled output.
.github/workflows/smoke-copilot-sub-agents.mdAdds threshold.
.github/workflows/smoke-copilot-sub-agents.lock.ymlRecompiled output.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 134/134 changed files
  • Comments generated: 3
  • Review effort level: Medium

Comment thread.github/workflows/daily-skill-optimizer.md
id: copilot
copilot-sdk: true
driver: .github/drivers/copilot_sdk_driver_sample_node.cjs
max-tool-denials: 3
Comment thread.github/workflows/daily-model-inventory.md
id: copilot
copilot-sdk: true
driver: .github/drivers/copilot_sdk_driver_sample_node.cjs
max-tool-denials: 3
Comment thread.github/workflows/daily-issues-report.md
id: copilot
copilot-sdk: true
driver: .github/drivers/copilot_sdk_driver_sample_node.cjs
max-tool-denials: 3
@github-actionsgithub-actionsBot mentioned this pull request Jul 27, 2026
Closed
@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.83.4

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@pelikhanpelikhanAwaiting requested review from pelikhan

Assignees

@pelikhanpelikhan

Copilot code reviewCopilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[copilot-cli-research] Copilot CLI Deep Research - 2026-07-27

3 participants

@pelikhan