Skip to content

[test-parallel] test: add t.Parallel() to cmd/gh-aw-wasm/compile_recovery_test.go - #48309

Merged
pelikhan merged 1 commit into
mainfrom
test-parallel/wasm-compile-recovery-996e4dbbb6eb9eb6
Jul 27, 2026
Merged

[test-parallel] test: add t.Parallel() to cmd/gh-aw-wasm/compile_recovery_test.go#48309
pelikhan merged 1 commit into
mainfrom
test-parallel/wasm-compile-recovery-996e4dbbb6eb9eb6

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jul 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Adds t.Parallel() to all three test functions in cmd/gh-aw-wasm/compile_recovery_test.go, enabling the Go test runner to execute them concurrently.

Changes

FileChange
cmd/gh-aw-wasm/compile_recovery_test.goAdded t.Parallel() to TestRunCompileWithRecoverySuccess, TestRunCompileWithRecoveryError, and TestRunCompileWithRecoveryPanic

Impact

  • Scope: test-only
  • Breaking: no
  • Effect: reduces total test time by allowing these three tests to run in parallel; no change to test logic or assertions

Generated by PR Description Updater for #48309 · sonnet46 · 20.6 AIC · ⌖ 5.59 AIC · ⊞ 4.8K · ◷

@github-actions
test: add t.Parallel() to compile_recovery_test.go
120400d
All three tests in cmd/gh-aw-wasm/compile_recovery_test.go are
independently safe to run in parallel: they use only local variables,
no shared mutable globals, no environment mutation, no filesystem paths,
no ports, and no synchronization between tests.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review July 27, 2026 07:22
CopilotAI review requested due to automatic review settings July 27, 2026 07:22
@pelikhan
pelikhan merged commit 5de162b into mainJul 27, 2026
@pelikhan
pelikhan deleted the test-parallel/wasm-compile-recovery-996e4dbbb6eb9eb6 branch July 27, 2026 07:22
@github-actions

github-actionsBot commented Jul 27, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

✅ Test Quality Sentinel completed test quality analysis.

@github-actions

github-actionsBot commented Jul 27, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

PR #48309 adds t.Parallel() to 3 tests in compile_recovery_test.go. The change is correct and safe — all three tests are stateless (no shared mutable state, global vars, or race conditions). No actionable review comments to make.

CopilotAI reviewed Jul 27, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables safe parallel execution for compile recovery tests.

Changes:

  • Adds t.Parallel() to all three top-level recovery tests.
  • Tests remain isolated and use no shared mutable state.
Show a summary per file
FileDescription
cmd/gh-aw-wasm/compile_recovery_test.goRuns success, error, and panic tests in parallel.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions

github-actionsBot commented Jul 27, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories.

@github-actions

github-actionsBot commented Jul 27, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

✅ PR Code Quality Reviewer completed the code quality review.

github-actions[bot]
github-actionsBot commented Jul 27, 2026
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The t.Parallel() additions are correct and safe — no shared mutable state across the three test functions.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 12.4 AIC · ⌖ 4.47 AIC · ⊞ 5K

github-actions[bot]
github-actionsBot commented Jul 27, 2026
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — three mechanical t.Parallel() additions to local-variable-only tests.

Analysis summary

All three tests are safe for parallel execution:

  • No shared global state, no t.Setenv, no filesystem or network access, no fixed ports
  • Panic-recovery test inspects only a stable local function name, which is safe under parallelism
  • PR author confirms go test -race ./cmd/gh-aw-wasm/... passes

No blocking issues found.

🔎 Code quality review by PR Code Quality Reviewer · sonnet46 · 12.5 AIC · ⌖ 4.53 AIC · ⊞ 5.7K
Comment /review to run again

@github-actionsgithub-actionsBot mentioned this pull request Jul 27, 2026
Closed
@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 Test Quality Sentinel Report

✅ Test Quality Score: N/A — Infrastructure

Infrastructure-only change detected. No behavioral tests were added or modified.

📊 Change Summary
AspectValue
Test files changed1
Behavioral test functions added0
Behavioral test functions modified0
Change typeNon-behavioral optimization (t.Parallel() added)
Violations0

File modified:cmd/gh-aw-wasm/compile_recovery_test.go

  • TestRunCompileWithRecoverySuccess — added t.Parallel()
  • TestRunCompileWithRecoveryError — added t.Parallel()
  • TestRunCompileWithRecoveryPanic — added t.Parallel()

Analysis

This PR adds t.Parallel() directives to three existing test functions. These tests are safely parallelizable because they:

  • Use only local variables and closures
  • Have no shared mutable globals
  • Perform no environment or filesystem mutations
  • Make no port/network allocations

Adding t.Parallel() is a pure performance optimization that improves test suite speed without affecting test coverage, behavior, or assertions.

Verdict

✅ passed. Infrastructure-only PR; behavioral test ratio not applicable. All existing tests remain unchanged in coverage and assertions.

🧪 Test quality analysis by Test Quality Sentinel · haiku45 · 16.5 AIC · ⌖ 6.59 AIC · ⊞ 8.1K · ◷
Comment /review to run again

github-actions[bot]
github-actionsBot commented Jul 27, 2026
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: Infrastructure only. No behavioral tests were added or modified. All existing tests remain unchanged in coverage and assertions.

@github-actionsgithub-actionsBot mentioned this pull request Jul 27, 2026
Closed
@github-actions

github-actionsBot commented Jul 27, 2026

Copy link
Copy Markdown
ContributorAuthor

🎉 This pull request is included in a new release.

Release: v0.83.4

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

automationtesting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pelikhan