Uh oh!
There was an error while loading. Please reload this page.
pr-finisher: resolve Copilot-answered review threads before re-engaging copilot-review - #49111
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
Update pr-finisher: resolve Copilot-answered review threadspr-finisher: resolve Copilot-answered review threads before re-engaging copilot-reviewJul 30, 2026
Copilotcreated this pull request from a session on behalf of pelikhanJuly 30, 2026 10:13 View session
pelikhan
marked this pull request as ready for review
July 30, 2026 10:17
Contributor
There was a problem hiding this comment.
Pull request overview
Adds pre-delegation handling for Copilot-answered review threads in pr-finisher.
Changes:
- Adds step 2a to identify and resolve answered threads.
- Updates review conditions and completion criteria.
- Includes unrelated skill-index and generated workflow lock-file changes.
Show a summary per file
| File | Description |
|---|---|
.github/skills/pr-finisher/SKILL.md | Adds Copilot-answer thread handling. |
.github/skills/agentic-workflows/SKILL.md | Adds unrelated reference entries. |
.github/workflows/*.lock.yml | Propagates an unrelated cache-miss output across generated workflows. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 244/244 changed files
- Comments generated: 2
- Review effort level: Medium
| ```bash | ||
| # Identify unresolved threads that already have a Copilot reply | ||
| jq '.reviewThreads[]? | select(.isResolved==false) | select(any(.comments[]?; .author.login == "app/github-copilot" or (.author.login | test("copilot"; "i"))))' "$PR_SNAPSHOT" |
| http_400_response_error: ${{ steps.detect-agent-errors.outputs.http_400_response_error || 'false' }} | ||
| inference_access_error: ${{ steps.detect-agent-errors.outputs.inference_access_error || 'false' }} | ||
| invocation_cap_exceeded: ${{ steps.detect-agent-errors.outputs.invocation_cap_exceeded || 'false' }} | ||
| max_cache_misses_exceeded: ${{ steps.detect-agent-errors.outputs.max_cache_misses_exceeded || 'false' }} |
This was referenced Jul 30, 2026
Contributor
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pr-finisher skill had no explicit handling for review threads that Copilot already answered but never resolved — those would get re-delegated to
copilot-reviewunnecessarily.Changes
SKILL.md— Step 2 split into 2a/2b:copilot-review, find unresolved threads where Copilot has already left a substantive reply and resolve them immediately. Uses jq filter on the existing$PR_SNAPSHOT— no extra API calls.copilot-review.copilot-reviewdelegation.