Uh oh!
There was an error while loading. Please reload this page.
fix(daily-firewall-report): add missing create_discussion safe-output - #49460
Merged
Conversation
Add the `create-discussion` safe-output to the daily firewall report workflow so the agent can publish the report as a GitHub discussion in the "audits" category. Also enables `close-older-discussions` with a matching title prefix so stale daily reports are automatically marked as outdated, and sets a 14-day expiry. Recompiles the lock file. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix missing create_discussion tool for daily firewall logs workflowfix(daily-firewall-report): add missing create_discussion safe-outputAug 1, 2026
pelikhan
marked this pull request as ready for review
August 1, 2026 04:29
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the daily firewall workflow to publish its report as a GitHub discussion, resolving #49458.
Changes:
- Adds the scoped
create-discussionsafe output with stale-report cleanup and 14-day expiry. - Regenerates the compiled workflow with the required tool, configuration, and permissions.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/daily-firewall-report.md | Declares discussion publishing behavior. |
.github/workflows/daily-firewall-report.lock.yml | Applies the generated runtime configuration. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
This was referenced Aug 1, 2026
Contributor
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily firewall report workflow fails to publish its output because
create_discussionwas never declared insafe-outputs— the agent correctly generates the report but has no permitted write path to post it as a GitHub discussion.Changes
daily-firewall-report.md— addscreate-discussionsafe-output scoped to theauditscategory, withclose-older-discussions: true(keyed ontitle-prefix) to auto-retire stale reports and a 14-day expiryThe agent job's
discussions: readpermission is unchanged — safe-outputs use a scoped App token for writes; the agent job itself never needs write access.