Skip to content

Revert sbx to 10% of agentic workflows, set gvisor to 10% - #51294

Merged
pelikhan merged 1 commit into
mainfrom
copilot/revert-sbx-10-percentage
Aug 8, 2026
Merged

Revert sbx to 10% of agentic workflows, set gvisor to 10%#51294
pelikhan merged 1 commit into
mainfrom
copilot/revert-sbx-10-percentage

Conversation

CopilotAI commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Rebalances sandbox runtime distribution across the 283 agentic workflow files. Previously sbx had been rolled out broadly (~38%); this reverts it to ~10% and establishes gvisor at ~10%.

Runtime distribution changes

RuntimeBeforeAfter
docker-sbx108 workflows (38%)28 workflows (10%)
gvisor0 workflows (0%)28 workflows (10%)
default (none)175 workflows (62%)225 workflows (80%)

What changed

  • Reverted sbx: Removed runtime: docker-sbx + sudo: true from 80 workflows, restoring them to sudo: false with no explicit runtime
  • Added gvisor: Added runtime: gvisor to 28 workflows that previously had no runtime. Uses sudo: false (gvisor runs cleanly in strict mode without sudo)
  • Recompiled all 283 lock files (all succeed, no errors)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
CopilotAI changed the title revert sbx to 10% of agentic workflows, set gvisor to 10%Revert sbx to 10% of agentic workflows, set gvisor to 10%Aug 8, 2026
CopilotAI requested a review from pelikhanAugust 8, 2026 03:21
@pelikhan
pelikhan marked this pull request as ready for review August 8, 2026 03:22
CopilotAI balanced review requested due to automatic review settings August 8, 2026 03:22
@pelikhan
pelikhan merged commit 0de69c5 into mainAug 8, 2026
11 of 12 checks passed
@pelikhan
pelikhan deleted the copilot/revert-sbx-10-percentage branch August 8, 2026 03:23
@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (0 additions detected in default business logic dirs).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • api.individual.githubcopilot.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "api.individual.githubcopilot.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actionsBot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rebalances agent sandbox runtimes across workflows: 28 use docker-sbx, 28 use gVisor, and 227 use the default runtime.

Changes:

  • Reverts 80 workflows from docker-sbx to the default runtime.
  • Assigns gVisor to 28 workflows.
  • Regenerates affected compiled lock files.
Show a summary per file
FileDescription
.github/workflows/weekly-safe-outputs-spec-review.mdRestores default runtime.
.github/workflows/weekly-issue-summary.mdRestores default runtime.
.github/workflows/weekly-editors-health-check.mdRestores default runtime.
.github/workflows/weekly-blog-post-writer.mdRestores default runtime.
.github/workflows/smoke-workflow-call.mdRestores default runtime.
.github/workflows/smoke-workflow-call-with-inputs.mdRestores default runtime.
.github/workflows/smoke-test-tools.mdRestores default runtime.
.github/workflows/smoke-temporary-id.mdRestores default runtime.
.github/workflows/smoke-pydantic.mdRestores default runtime.
.github/workflows/smoke-otel-backends.mdRestores default runtime.
.github/workflows/smoke-opencode.mdRestores default runtime.
.github/workflows/smoke-multi-pr.mdRestores default runtime.
.github/workflows/smoke-kiro.mdRestores default runtime.
.github/workflows/smoke-goose.mdRestores default runtime.
.github/workflows/smoke-github-claude.mdRestores default runtime.
.github/workflows/smoke-gemini.mdRestores default runtime.
.github/workflows/smoke-cursor.mdRestores default runtime.
.github/workflows/smoke-crush.mdRestores default runtime.
.github/workflows/smoke-copilot.mdRestores default runtime.
.github/workflows/smoke-copilot-sub-agents.mdRestores default runtime.
.github/workflows/smoke-copilot-small.mdRestores default runtime.
.github/workflows/smoke-copilot-sdk.mdRestores default runtime.
.github/workflows/smoke-copilot-mai.mdRestores default runtime.
.github/workflows/smoke-copilot-auto.mdRestores default runtime.
.github/workflows/smoke-copilot-arm.mdRestores default runtime.
.github/workflows/smoke-copilot-aoai-entra.mdRestores default runtime.
.github/workflows/smoke-copilot-aoai-apikey.mdRestores default runtime.
.github/workflows/smoke-codex.mdRestores default runtime.
.github/workflows/smoke-claude-on-copilot.mdRestores default runtime.
.github/workflows/smoke-ci.mdRestores default runtime.
.github/workflows/smoke-checkout-pr-dispatch.mdRestores default runtime.
.github/workflows/smoke-call-workflow.mdRestores default runtime.
.github/workflows/smoke-aider.mdRestores default runtime.
.github/workflows/smoke-agent-scoped-approved.mdRestores default runtime.
.github/workflows/smoke-agent-public-none.mdRestores default runtime.
.github/workflows/smoke-agent-public-approved.mdRestores default runtime.
.github/workflows/smoke-agent-all-none.mdRestores default runtime.
.github/workflows/smoke-agent-all-merged.mdRestores default runtime.
.github/workflows/hourly-ci-cleaner.mdRestores default runtime.
.github/workflows/daily-yamllint-fixer.mdRestores default runtime.
.github/workflows/daily-workflow-updater.mdRestores default runtime.
.github/workflows/daily-vulnhunter-scan.mdRestores default runtime.
.github/workflows/daily-token-consumption-report.mdRestores default runtime.
.github/workflows/daily-testify-uber-super-expert.mdRestores default runtime.
.github/workflows/daily-team-evolution-insights.mdRestores default runtime.
.github/workflows/daily-syntax-error-quality.mdRestores default runtime.
.github/workflows/daily-spec-coverage-kiro.mdRestores default runtime.
.github/workflows/daily-spdd-spec-planner.mdRestores default runtime.
.github/workflows/daily-skill-optimizer.mdRestores default runtime.
.github/workflows/daily-sentrux-report.mdRestores default runtime.
.github/workflows/daily-security-red-team.mdRestores default runtime.
.github/workflows/daily-security-observability.mdRestores default runtime.
.github/workflows/daily-secrets-analysis.mdRestores default runtime.
.github/workflows/daily-schema-audit-cursor.mdRestores default runtime.
.github/workflows/daily-safeoutputs-git-simulator.mdRestores default runtime.
.github/workflows/daily-safe-outputs-conformance.mdRestores default runtime.
.github/workflows/daily-safe-output-optimizer.mdRestores default runtime.
.github/workflows/daily-safe-output-integrator.mdRestores default runtime.
.github/workflows/daily-repo-chronicle.mdRestores default runtime.
.github/workflows/daily-rendering-scripts-verifier.mdRestores default runtime.
.github/workflows/daily-reliability-review.mdRestores default runtime.
.github/workflows/daily-regression-audit-kiro.mdRestores default runtime.
.github/workflows/daily-pr-review-cursor.mdRestores default runtime.
.github/workflows/daily-performance-summary.mdRestores default runtime.
.github/workflows/daily-observability-report.mdRestores default runtime.
.github/workflows/daily-news.mdRestores default runtime.
.github/workflows/daily-multi-device-docs-tester.mdRestores default runtime.
.github/workflows/daily-model-resolution.mdRestores default runtime.
.github/workflows/daily-model-inventory.mdRestores default runtime.
.github/workflows/daily-mcp-concurrency-analysis.mdRestores default runtime.
.github/workflows/daily-max-ai-credits-test.mdRestores default runtime.
.github/workflows/daily-malicious-code-scan.mdRestores default runtime.
.github/workflows/daily-issues-report.mdRestores default runtime.
.github/workflows/daily-hippo-learn.mdRestores default runtime.
.github/workflows/daily-graft-intelligence.mdRestores default runtime.
.github/workflows/daily-go-test-stubs-aider.mdRestores default runtime.
.github/workflows/daily-github-docs-seo-optimizer.mdRestores default runtime.
.github/workflows/daily-geo-optimizer.mdRestores default runtime.
.github/workflows/daily-function-namer.mdRestores default runtime.
.github/workflows/daily-formal-spec-verifier.mdRestores default runtime.
.github/workflows/code-simplifier.mdAssigns gVisor.
.github/workflows/code-simplifier.lock.ymlCompiles gVisor setup.
.github/workflows/code-scanning-fixer.mdAssigns gVisor.
.github/workflows/cloclo.mdAssigns gVisor.
.github/workflows/cli-version-checker.mdAssigns gVisor.
.github/workflows/cli-consistency-checker.mdAssigns gVisor.
.github/workflows/cli-consistency-checker.lock.ymlCompiles gVisor setup.
.github/workflows/claude-code-user-docs-review.mdAssigns gVisor.
.github/workflows/ci-coach.mdAssigns gVisor.
.github/workflows/ci-coach.lock.ymlCompiles gVisor setup.
.github/workflows/chaos-pr-bundle-fuzzer.mdAssigns gVisor.
.github/workflows/changeset.mdAssigns gVisor.
.github/workflows/breaking-change-checker.mdAssigns gVisor.
.github/workflows/bot-detection.mdAssigns gVisor.
.github/workflows/bot-detection.lock.ymlCompiles gVisor setup.
.github/workflows/blog-auditor.mdAssigns gVisor.
.github/workflows/aw-failure-investigator.mdAssigns gVisor.
.github/workflows/avenger.mdAssigns gVisor.
.github/workflows/auto-triage-issues.mdAssigns gVisor.
.github/workflows/audit-workflows.mdAssigns gVisor.
.github/workflows/audit-workflows.lock.ymlCompiles gVisor setup.
.github/workflows/artifacts-summary.mdAssigns gVisor.
.github/workflows/archivx-agentic-workflows-analyzer.mdAssigns gVisor.
.github/workflows/archivx-agentic-workflows-analyzer.lock.ymlCompiles gVisor setup.
.github/workflows/architecture-guardian.mdAssigns gVisor.
.github/workflows/architecture-guardian.lock.ymlCompiles gVisor setup.
.github/workflows/archie.mdAssigns gVisor.
.github/workflows/approach-validator.mdAssigns gVisor.
.github/workflows/api-consumption-report.mdAssigns gVisor.
.github/workflows/ai-moderator.mdAssigns gVisor.
.github/workflows/agentic-token-trend-audit.mdAssigns gVisor.
.github/workflows/agent-persona-explorer.mdAssigns gVisor.
.github/workflows/agent-performance-analyzer.mdAssigns gVisor.
.github/workflows/agent-performance-analyzer.lock.ymlCompiles gVisor setup.
.github/workflows/ace-editor.mdAssigns gVisor.
.github/workflows/ace-editor.lock.ymlCompiles gVisor setup.
.github/workflows/ab-testing-advisor.mdAssigns gVisor.
.github/workflows/ab-testing-advisor.lock.ymlCompiles gVisor setup.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 84/216 changed files
  • Comments generated: 1
  • Review effort level: Balanced

@@ -57,8 +57,7 @@ features:
sandbox:
agent:
id: awf
runtime: docker-sbx
sudo: true
sudo: false

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime distribution rebalance looks correct. All 28 gvisor-added workflows correctly use sudo: false, the sbx rollbacks properly restore default settings, and the lock files are recompiled consistently. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 21.9 AIC · ⌖ 7.03 AIC · ⊞ 5.5K

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /codebase-design — one observation on the gVisor install step; no blocking issues.

📋 Key Themes & Highlights

Key Themes

  • Supply-chain verification gap: SHA-512 checksums are fetched from the same GCS bucket as the binaries, so they provide integrity-in-transit but not authenticity. The packages.cloud.google.com apt repository (already in the firewall allowlist) uses GPG-signed packages and would provide stronger guarantees.
  • gVisor version pinned (20250707.0) — good practice.
  • docker systemctl restart rationale documented — good inline comment explaining why reload is insufficient.

Positive Highlights

  • ✅ Clear distribution table in the PR description
  • ✅ All 283 lock files recompiled successfully
  • sudo: false correctly set for gVisor (no privilege escalation needed)
  • runsc --version + docker run --runtime=runsc hello-world sanity check in every generated step

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 36 AIC · ⌖ 7.49 AIC · ⊞ 7.1K
Comment /matt to run again

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.86.2

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pelikhan