Refactor engine import defaults parameters

[Copilot]

applyEngineImportDefaults exceeded the custom linter’s parameter-count limit. This refactor keeps the behavior local and unchanged while reducing the helper signature below the threshold.

• Options struct

  • Added a narrow engineImportDefaultsOptions struct for the values already passed together.
  • Kept the struct local to compiler_orchestrator_engine.go.

• Call-site clarity

  • Replaced the long positional argument list with named fields:

engineConfig, model=c.applyEngineImportDefaults(engineImportDefaultsOptions{
engineConfig: engineConfig,
model: model,
engineSetting: engineSetting,
importsResult: importsResult,
importedEngineDefinitions: importedEngineDefinitions,
preservedMaxTurns: preservedMaxTurns,
preservedMaxAICredits: preservedMaxAICredits,
preservedMaxRuns: preservedMaxRuns,
preservedMaxTurnCacheMisses: preservedMaxTurnCacheMisses,
})

• Fixes[lint-monster] lint-monster: apply options-struct refactor for applyEngineImportDefaults #51285

---

@copilot Quick triage nudge for this PR.
Please refresh the branch if GitHub can update it cleanly, address the remaining items below, and run the skill before handing back to maintainers.

Open review threads (newest first):

• unresolved review thread from : Refactor engine import defaults parameters #51295 (comment)

Run: https://github.com/github/gh-aw/actions/runs/31241108329> Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.06 AIC · ⌖ 6.39 AIC · ⊞ 8.5K · ◷

_{Comment /souschef to run again}

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 17.1 AIC · ⌖ 6.55 AIC · ⊞ 6.1K · ◷
_{Comment /souschef to run again}

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (52 additions detected, threshold is 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• api.individual.githubcopilot.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
allowed:
- defaults
- "api.individual.githubcopilot.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[Copilot]

Pull request overview

Refactors engine import default handling to satisfy the parameter-count linter without changing behavior.

Changes:

• Introduces a local options struct.
• Replaces positional arguments with named fields.

Show a summary per file

File	Description
pkg/workflow/compiler_orchestrator_engine.go	Refactors helper signature and call site.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Balanced

[github-actions]

Clean refactor: converting a 9-parameter function to an options struct. Logic is identical, call site is correctly updated, and struct field names match original parameter names. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 15.7 AIC · ⌖ 7.09 AIC · ⊞ 5.5K

[github-actions]

Skills-Based Review 🧠

Applied /codebase-design — clean mechanical refactor; approving.

📋 Highlights

• ✅ engineImportDefaultsOptions is package-private (lowercase), correctly scoped to this file
• ✅ Only engineConfig and model (the returned/mutated values) are unpacked to locals; all other fields accessed via opts.* — idiomatic Go
• ✅ Behaviour is identical to the previous positional-parameter signature
• ✅ Single focused file change; linter parameter-count threshold satisfied

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 18 AIC · ⌖ 7.36 AIC · ⊞ 7.1K
_{Comment /matt to run again}

[gh-aw-bot]

@copilot Quick triage nudge for this PR.
Please refresh the branch if GitHub can update it cleanly, address the remaining items below, and run the skill before handing back to maintainers.

Open review threads (newest first):

• unresolved review thread from : Refactor engine import defaults parameters #51295 (comment)

Run: https://github.com/github/gh-aw/actions/runs/31241108329

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 7.06 AIC · ⌖ 6.39 AIC · ⊞ 8.5K · ◷
_{Comment /souschef to run again}

[Copilot]

@copilot Quick triage nudge for this PR.
Please refresh the branch if GitHub can update it cleanly, address the remaining items below, and run the skill before handing back to maintainers.
...

Moved the applyEngineImportDefaults doc comment to sit directly above the function declaration (below the options struct) so Go's doc tooling associates it with the right symbol. Fixed in the latest commit.

[gh-aw-bot]

@copilot Quick triage nudge for this PR.

Please refresh the branch if GitHub can update it cleanly, confirm the remaining review thread you already replied to is now fully resolved, and run the pr-finisher skill before handing back to maintainers.

Open items (newest first):

• unresolved review thread with follow-up already posted by Copilot: Refactor engine import defaults parameters #51295 (comment)

Run: https://github.com/github/gh-aw/actions/runs/31242800863

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 17.1 AIC · ⌖ 6.55 AIC · ⊞ 6.1K · ◷
_{Comment /souschef to run again}

[github-actions]

PR Triage

Category: refactor | Risk: low | Score: 58 (impact 20, urgency 15, quality 23)

Recommended action:fast_track

Small internal refactor (parameter struct extraction, no behavior change), 1 file. AI reviewer approved (2x github-actions APPROVED). CI (CGO/CWI) currently in_progress after latest push; prior runs alternated pass/action_required. Good candidate for expedited human review once CI is green.

Generated by 🔧 PR Triage Agent · auto · 40.7 AIC · ⌖ 2.51 AIC · ⊞ 8K · ◷

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.86.2